From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Jason Baron <jbaron@akamai.com>, Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v3] dynamic_debug: allow to work if debugfs is disabled
Date: Thu, 23 Jan 2020 18:55:36 +0100 [thread overview]
Message-ID: <20200123175536.GA1796501@kroah.com> (raw)
In-Reply-To: <20200123155340.GD147870@mit.edu>
On Thu, Jan 23, 2020 at 10:53:40AM -0500, Theodore Y. Ts'o wrote:
> On Wed, Jan 22, 2020 at 08:31:18PM +0100, Greg Kroah-Hartman wrote:
> > With the realization that having debugfs enabled on "production" systems is
> > generally not a good idea, debugfs is being disabled from more and more
> > platforms over time. However, the functionality of dynamic debugging still is
> > needed at times, and since it relies on debugfs for its user api, having
> > debugfs disabled also forces dynamic debug to be disabled.
> >
> > To get around this, move the "control" file for dynamic_debug to procfs IFF
> > debugfs is disabled. This lets people turn on debugging as needed at runtime
> > for individual driverfs and subsystems.
>
> Instead of moving the control file IFF debugfs is enabled, what about
> always making it available in /proc, and marking the control file for
> dynamic_debug in debugfs as deprecated? It would seem to me that this
> would cause less confusion in the future....
Why deprecate it? It's fine where it is, and most developer's have
debugfs enabled so all is good. I'd rather only use /proc as a
last-resort.
thanks,
greg k-h
next prev parent reply other threads:[~2020-01-23 17:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 7:43 [PATCH] dynamic_debug: allow to work if debugfs is disabled Greg Kroah-Hartman
2020-01-22 8:03 ` Will Deacon
2020-01-22 8:12 ` Greg Kroah-Hartman
2020-01-22 13:53 ` [PATCH v2] " Greg Kroah-Hartman
2020-01-22 18:56 ` Jason Baron
2020-01-22 19:29 ` Greg Kroah-Hartman
2020-01-22 19:31 ` [PATCH v3] " Greg Kroah-Hartman
2020-01-22 21:43 ` Randy Dunlap
2020-01-23 8:48 ` Greg Kroah-Hartman
2020-01-23 8:50 ` [PATCH v4] " Greg Kroah-Hartman
2020-01-23 9:36 ` Will Deacon
2020-01-23 15:53 ` [PATCH v3] " Theodore Y. Ts'o
2020-01-23 17:55 ` Greg Kroah-Hartman [this message]
2020-01-24 6:02 ` Theodore Y. Ts'o
2020-01-24 7:29 ` Greg Kroah-Hartman
2020-01-25 1:42 ` Theodore Y. Ts'o
2020-01-25 17:11 ` Jonathan Corbet
2020-01-27 22:19 ` Saravana Kannan
2020-02-09 11:05 ` [PATCH v5] " Greg Kroah-Hartman
2020-02-09 15:53 ` Joe Perches
2020-02-09 17:03 ` Greg Kroah-Hartman
2020-02-10 21:11 ` [PATCH v6] " Greg Kroah-Hartman
2020-02-10 21:15 ` Randy Dunlap
2020-02-12 21:58 ` Greg Kroah-Hartman
2020-02-11 11:01 ` Will Deacon
2020-01-25 0:03 ` [PATCH] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123175536.GA1796501@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).