* [PATCH] net/mlx5: Remove a useless 'drain_workqueue()' call in 'mlx5e_ipsec_cleanup()'
@ 2020-01-26 17:51 Christophe JAILLET
2020-01-27 8:08 ` Boris Pismenny
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2020-01-26 17:51 UTC (permalink / raw)
To: borisp, saeedm, leon, davem
Cc: linux-rdma, netdev, linux-kernel, kernel-janitors, Christophe JAILLET
'destroy_workqueue()' already calls 'drain_workqueue()', there is no need
to call it explicitly.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
index cf58c9637904..29626c6c9c25 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
@@ -433,7 +433,6 @@ void mlx5e_ipsec_cleanup(struct mlx5e_priv *priv)
if (!ipsec)
return;
- drain_workqueue(ipsec->wq);
destroy_workqueue(ipsec->wq);
ida_destroy(&ipsec->halloc);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: Remove a useless 'drain_workqueue()' call in 'mlx5e_ipsec_cleanup()'
2020-01-26 17:51 [PATCH] net/mlx5: Remove a useless 'drain_workqueue()' call in 'mlx5e_ipsec_cleanup()' Christophe JAILLET
@ 2020-01-27 8:08 ` Boris Pismenny
2020-02-11 21:44 ` Saeed Mahameed
0 siblings, 1 reply; 3+ messages in thread
From: Boris Pismenny @ 2020-01-27 8:08 UTC (permalink / raw)
To: Christophe JAILLET, Saeed Mahameed, leon, davem
Cc: linux-rdma, netdev, linux-kernel, kernel-janitors
On 1/26/2020 7:51 PM, Christophe JAILLET wrote:
> 'destroy_workqueue()' already calls 'drain_workqueue()', there is no need
> to call it explicitly.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> index cf58c9637904..29626c6c9c25 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> @@ -433,7 +433,6 @@ void mlx5e_ipsec_cleanup(struct mlx5e_priv *priv)
> if (!ipsec)
> return;
>
> - drain_workqueue(ipsec->wq);
> destroy_workqueue(ipsec->wq);
>
> ida_destroy(&ipsec->halloc);
LGTM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: Remove a useless 'drain_workqueue()' call in 'mlx5e_ipsec_cleanup()'
2020-01-27 8:08 ` Boris Pismenny
@ 2020-02-11 21:44 ` Saeed Mahameed
0 siblings, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2020-02-11 21:44 UTC (permalink / raw)
To: Boris Pismenny
Cc: Christophe JAILLET, Saeed Mahameed, leon, davem, linux-rdma,
netdev, linux-kernel, kernel-janitors
On Mon, Jan 27, 2020 at 12:08 AM Boris Pismenny <borisp@mellanox.com> wrote:
>
>
> On 1/26/2020 7:51 PM, Christophe JAILLET wrote:
> > 'destroy_workqueue()' already calls 'drain_workqueue()', there is no need
> > to call it explicitly.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> > index cf58c9637904..29626c6c9c25 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> > @@ -433,7 +433,6 @@ void mlx5e_ipsec_cleanup(struct mlx5e_priv *priv)
> > if (!ipsec)
> > return;
> >
> > - drain_workqueue(ipsec->wq);
> > destroy_workqueue(ipsec->wq);
> >
> > ida_destroy(&ipsec->halloc);
> LGTM
applied to net-next-mlx5
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-11 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-26 17:51 [PATCH] net/mlx5: Remove a useless 'drain_workqueue()' call in 'mlx5e_ipsec_cleanup()' Christophe JAILLET
2020-01-27 8:08 ` Boris Pismenny
2020-02-11 21:44 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).