* [PATCH v2 1/2] hrtimer: Add missing annotation to lock_hrtimer_base()
@ 2020-01-27 2:30 Jules Irenge
0 siblings, 0 replies; only message in thread
From: Jules Irenge @ 2020-01-27 2:30 UTC (permalink / raw)
To: boqun.feng; +Cc: linux-kernel, tglx, Jules Irenge
Sparse reports several warnings;
warning: context imbalance in lock_hrtimer_base() - wrong count at exit
warning: context imbalance in hrtimer_start_range_ns() - unexpected unlock
warning: context imbalance in hrtimer_try_to_cancel() - unexpected unlock
warning: context imbalance in __hrtimer_get_remaining() - unexpected unlock
The root cause is a missing annotation of lock_hrtimer_base()
which also causes the "unexpected unlock" warnings.
To fix these,
an __acquires(timer) annotation is added to lock_hrtimer_base().
Given that lock_hrtimer_base() does actually call READ_ONCE(timer->base),
this fixes the warnings.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
kernel/time/hrtimer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index 8de90ea31280..d149b599bdf7 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -157,9 +157,9 @@ static inline bool is_migration_base(struct hrtimer_clock_base *base)
* possible to set timer->base = &migration_base and drop the lock: the timer
* remains locked.
*/
-static
-struct hrtimer_clock_base *lock_hrtimer_base(const struct hrtimer *timer,
- unsigned long *flags)
+static struct hrtimer_clock_base *
+lock_hrtimer_base(const struct hrtimer *timer,
+ unsigned long *flags) __acquires(timer)
{
struct hrtimer_clock_base *base;
--
2.24.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-27 2:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 2:30 [PATCH v2 1/2] hrtimer: Add missing annotation to lock_hrtimer_base() Jules Irenge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).