linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the generic-ioremap tree with the net-next tree
@ 2020-01-09  5:12 Stephen Rothwell
  2020-01-27 22:54 ` Stephen Rothwell
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-01-09  5:12 UTC (permalink / raw)
  To: Christoph Hellwig, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Alexandru-Mihai Maftei

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]

Hi all,

Today's linux-next merge of the generic-ioremap tree got a conflict in:

  drivers/net/ethernet/sfc/efx.c

between commit:

  f1826756b499 ("sfc: move struct init and fini code")

from the net-next tree and commit:

  4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")

from the generic-ioremap tree.

I fixed it up (the latter moved the code, so I applied the following
merge fix patch) and can carry the fix as necessary. This is now fixed
as far as linux-next is concerned, but any non trivial conflicts should
be mentioned to your upstream maintainer when your tree is submitted
for merging.  You may also want to consider cooperating with the
maintainer of the conflicting tree to minimise any particularly complex
conflicts.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 9 Jan 2020 16:08:52 +1100
Subject: [PATCH] fix up for "sfc: move struct init and fini code"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/sfc/efx_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
index fe74c66c8ec6..bf0126633c25 100644
--- a/drivers/net/ethernet/sfc/efx_common.c
+++ b/drivers/net/ethernet/sfc/efx_common.c
@@ -954,7 +954,7 @@ int efx_init_io(struct efx_nic *efx, int bar, dma_addr_t dma_mask,
 		goto fail3;
 	}
 
-	efx->membase = ioremap_nocache(efx->membase_phys, mem_map_size);
+	efx->membase = ioremap(efx->membase_phys, mem_map_size);
 	if (!efx->membase) {
 		netif_err(efx, probe, efx->net_dev,
 			  "could not map memory BAR at %llx+%x\n",
-- 
2.24.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the generic-ioremap tree with the net-next tree
  2020-01-09  5:12 linux-next: manual merge of the generic-ioremap tree with the net-next tree Stephen Rothwell
@ 2020-01-27 22:54 ` Stephen Rothwell
  2020-01-28 21:16   ` Stephen Rothwell
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-01-27 22:54 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Christoph Hellwig, Linux Next Mailing List,
	Linux Kernel Mailing List, Alexandru-Mihai Maftei

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

Hi all,

On Thu, 9 Jan 2020 16:12:02 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> Today's linux-next merge of the generic-ioremap tree got a conflict in:
> 
>   drivers/net/ethernet/sfc/efx.c
> 
> between commit:
> 
>   f1826756b499 ("sfc: move struct init and fini code")
> 
> from the net-next tree and commit:
> 
>   4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
> 
> from the generic-ioremap tree.
> 
> I fixed it up (the latter moved the code, so I applied the following
> merge fix patch) and can carry the fix as necessary. This is now fixed
> as far as linux-next is concerned, but any non trivial conflicts should
> be mentioned to your upstream maintainer when your tree is submitted
> for merging.  You may also want to consider cooperating with the
> maintainer of the conflicting tree to minimise any particularly complex
> conflicts.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 9 Jan 2020 16:08:52 +1100
> Subject: [PATCH] fix up for "sfc: move struct init and fini code"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/net/ethernet/sfc/efx_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
> index fe74c66c8ec6..bf0126633c25 100644
> --- a/drivers/net/ethernet/sfc/efx_common.c
> +++ b/drivers/net/ethernet/sfc/efx_common.c
> @@ -954,7 +954,7 @@ int efx_init_io(struct efx_nic *efx, int bar, dma_addr_t dma_mask,
>  		goto fail3;
>  	}
>  
> -	efx->membase = ioremap_nocache(efx->membase_phys, mem_map_size);
> +	efx->membase = ioremap(efx->membase_phys, mem_map_size);
>  	if (!efx->membase) {
>  		netif_err(efx, probe, efx->net_dev,
>  			  "could not map memory BAR at %llx+%x\n",
> -- 
> 2.24.0

This is now a conflict between the net-next tree and Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the generic-ioremap tree with the net-next tree
  2020-01-27 22:54 ` Stephen Rothwell
@ 2020-01-28 21:16   ` Stephen Rothwell
  2020-01-29 14:24     ` Kalle Valo
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-01-28 21:16 UTC (permalink / raw)
  To: David Miller, Networking, Kalle Valo, Wireless
  Cc: Christoph Hellwig, Linux Next Mailing List,
	Linux Kernel Mailing List, Alexandru-Mihai Maftei

[-- Attachment #1: Type: text/plain, Size: 2319 bytes --]

Hi all,

On Tue, 28 Jan 2020 09:54:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 9 Jan 2020 16:12:02 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > Today's linux-next merge of the generic-ioremap tree got a conflict in:
> > 
> >   drivers/net/ethernet/sfc/efx.c
> > 
> > between commit:
> > 
> >   f1826756b499 ("sfc: move struct init and fini code")
> > 
> > from the net-next tree and commit:
> > 
> >   4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
> > 
> > from the generic-ioremap tree.
> > 
> > I fixed it up (the latter moved the code, so I applied the following
> > merge fix patch) and can carry the fix as necessary. This is now fixed
> > as far as linux-next is concerned, but any non trivial conflicts should
> > be mentioned to your upstream maintainer when your tree is submitted
> > for merging.  You may also want to consider cooperating with the
> > maintainer of the conflicting tree to minimise any particularly complex
> > conflicts.
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Thu, 9 Jan 2020 16:08:52 +1100
> > Subject: [PATCH] fix up for "sfc: move struct init and fini code"
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/net/ethernet/sfc/efx_common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
> > index fe74c66c8ec6..bf0126633c25 100644
> > --- a/drivers/net/ethernet/sfc/efx_common.c
> > +++ b/drivers/net/ethernet/sfc/efx_common.c
> > @@ -954,7 +954,7 @@ int efx_init_io(struct efx_nic *efx, int bar, dma_addr_t dma_mask,
> >  		goto fail3;
> >  	}
> >  
> > -	efx->membase = ioremap_nocache(efx->membase_phys, mem_map_size);
> > +	efx->membase = ioremap(efx->membase_phys, mem_map_size);
> >  	if (!efx->membase) {
> >  		netif_err(efx, probe, efx->net_dev,
> >  			  "could not map memory BAR at %llx+%x\n",
> > -- 
> > 2.24.0  
> 
> This is now a conflict between the net-next tree and Linus' tree.

It actually turns out that this is a conflict between the
wireless-drivers tree and Linus' tree since the wireless-drivers tree
has merged most of the net-next tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the generic-ioremap tree with the net-next tree
  2020-01-28 21:16   ` Stephen Rothwell
@ 2020-01-29 14:24     ` Kalle Valo
  0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-01-29 14:24 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Wireless, Christoph Hellwig,
	Linux Next Mailing List, Linux Kernel Mailing List,
	Alexandru-Mihai Maftei

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> On Tue, 28 Jan 2020 09:54:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> On Thu, 9 Jan 2020 16:12:02 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> > 
>> > Today's linux-next merge of the generic-ioremap tree got a conflict in:
>> > 
>> >   drivers/net/ethernet/sfc/efx.c
>> > 
>> > between commit:
>> > 
>> >   f1826756b499 ("sfc: move struct init and fini code")
>> > 
>> > from the net-next tree and commit:
>> > 
>> >   4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
>> > 
>> > from the generic-ioremap tree.
>> > 
>> > I fixed it up (the latter moved the code, so I applied the following
>> > merge fix patch) and can carry the fix as necessary. This is now fixed
>> > as far as linux-next is concerned, but any non trivial conflicts should
>> > be mentioned to your upstream maintainer when your tree is submitted
>> > for merging.  You may also want to consider cooperating with the
>> > maintainer of the conflicting tree to minimise any particularly complex
>> > conflicts.
>> > 
>> > From: Stephen Rothwell <sfr@canb.auug.org.au>
>> > Date: Thu, 9 Jan 2020 16:08:52 +1100
>> > Subject: [PATCH] fix up for "sfc: move struct init and fini code"
>> > 
>> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> > ---
>> >  drivers/net/ethernet/sfc/efx_common.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > 
>> > diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
>> > index fe74c66c8ec6..bf0126633c25 100644
>> > --- a/drivers/net/ethernet/sfc/efx_common.c
>> > +++ b/drivers/net/ethernet/sfc/efx_common.c
>> > @@ -954,7 +954,7 @@ int efx_init_io(struct efx_nic *efx, int bar, dma_addr_t dma_mask,
>> >  		goto fail3;
>> >  	}
>> >  
>> > -	efx->membase = ioremap_nocache(efx->membase_phys, mem_map_size);
>> > +	efx->membase = ioremap(efx->membase_phys, mem_map_size);
>> >  	if (!efx->membase) {
>> >  		netif_err(efx, probe, efx->net_dev,
>> >  			  "could not map memory BAR at %llx+%x\n",
>> > -- 
>> > 2.24.0  
>> 
>> This is now a conflict between the net-next tree and Linus' tree.
>
> It actually turns out that this is a conflict between the
> wireless-drivers tree and Linus' tree since the wireless-drivers tree
> has merged most of the net-next tree.

Yeah, I fast forwarded wireless-drivers to top of net-next so that I can
easily apply fixes and send them to Dave later this week. But as I don't
touch drivers/net/ethernet I don't think there's nothing I can do to fix
this conflict.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-29 14:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-09  5:12 linux-next: manual merge of the generic-ioremap tree with the net-next tree Stephen Rothwell
2020-01-27 22:54 ` Stephen Rothwell
2020-01-28 21:16   ` Stephen Rothwell
2020-01-29 14:24     ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).