From: Steven Rostedt <rostedt@goodmis.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
syzkaller <syzkaller@googlegroups.com>,
Eric Dumazet <edumazet@google.com>,
Hillf Danton <hdanton@sina.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
syzbot <syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com>,
Andrey Konovalov <andreyknvl@google.com>,
ingrassia@epigenesys.com, LKML <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [PATCH] usb: core: urb: change a dev_WARN() to dev_err() for syzbot
Date: Fri, 31 Jan 2020 09:25:27 -0500 [thread overview]
Message-ID: <20200131092527.3f05a679@gandalf.local.home> (raw)
In-Reply-To: <CACT4Y+YmUBUzZQNrHZtCV-LDxvmgoJtaoPYYP9OgRpAa59qF-g@mail.gmail.com>
On Fri, 31 Jan 2020 12:19:39 +0100
Dmitry Vyukov <dvyukov@google.com> wrote:
> +Eric, Steve, who got these WARNING-not-a-kernel-bug reports recently too
I've been trying to convert all WARN_ON() in my code to be only
triggered if something happens where I don't expect it to happen, and
there's either a bug in the code, or I missed something in the design
of the code. That is, if a WARN_ON() triggers, it means I need to have
a good look at the code to figure out why.
I like the idea of a NOTICE() that can be used for hardware bugs or bad
user input. Something to say, "the kernel code is fine, but we received
something we did not expect", which to me is different than a bug in
the kernel. Although, it could lead to finding a bug.
-- Steve
prev parent reply other threads:[~2020-01-31 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:27 WARNING in ar5523_cmd/usb_submit_urb syzbot
2020-01-31 5:06 ` [PATCH] usb: core: urb: change a dev_WARN() to dev_err() for syzbot Dan Carpenter
2020-01-31 13:30 ` Johan Hovold
2020-01-31 13:39 ` Dan Carpenter
2020-02-10 19:04 ` Greg KH
2020-02-10 21:11 ` Alan Stern
2020-02-10 21:50 ` Greg KH
2020-02-11 6:03 ` Dan Carpenter
[not found] ` <20200131090510.7112-1-hdanton@sina.com>
2020-01-31 10:16 ` Dan Carpenter
2020-01-31 11:19 ` Dmitry Vyukov
2020-01-31 13:37 ` Johan Hovold
2020-01-31 14:25 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131092527.3f05a679@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andreyknvl@google.com \
--cc=dan.carpenter@oracle.com \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=ingrassia@epigenesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).