From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hillf Danton <hdanton@sina.com>
Cc: gregkh@linuxfoundation.org,
Alan Stern <stern@rowland.harvard.edu>,
syzbot <syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com>,
andreyknvl@google.com, ingrassia@epigenesys.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] usb: core: urb: change a dev_WARN() to dev_err() for syzbot
Date: Fri, 31 Jan 2020 13:16:44 +0300 [thread overview]
Message-ID: <20200131101644.GE11068@kadam> (raw)
In-Reply-To: <20200131090510.7112-1-hdanton@sina.com>
On Fri, Jan 31, 2020 at 05:05:10PM +0800, Hillf Danton wrote:
>
> On Fri, 31 Jan 2020 08:06:52 +0300 Dan Carpenter wrote:
> > We changed this from dev_err() to dev_WARN() in commit 0cb54a3e47cb
> > ("USB: debugging code shouldn't alter control flow").
> >
> > The difference between dev_WARN() and dev_err() is that dev_WARN()
> > prints a stack trace and if you have panic on OOPS enabled then it leads
> > to a panic. The dev_err() function just prints the error message.
> >
> > Back in the day we didn't have usb emulators fuzz testing the kernel
> > so dev_WARN() didn't cause a problem for anyone, but these days the
>
> Another free option is perhaps to keep the devoted bot agile if it's
> difficult to list anybody who was mauled by its articulate reports.
It's difficult to parse this email. I get that you're being sarcastic
but I can't tell what you're being sarcastic about. :P
I think you're basically saying that syzbot should maintain a white
list of ignored Oopses. There are two problems with this: 1) Other
people run syzbot so everyone has to run into this bug and then add it
to their own white list. 2) If the kernel OOpes here then we cannot
test what happens next so it could be hiding bugs.
One idea is that there could be a kernel function which generates a
stack trace but is not an Oops.
regards,
dan carpenter
next prev parent reply other threads:[~2020-01-31 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:27 WARNING in ar5523_cmd/usb_submit_urb syzbot
2020-01-31 5:06 ` [PATCH] usb: core: urb: change a dev_WARN() to dev_err() for syzbot Dan Carpenter
2020-01-31 13:30 ` Johan Hovold
2020-01-31 13:39 ` Dan Carpenter
2020-02-10 19:04 ` Greg KH
2020-02-10 21:11 ` Alan Stern
2020-02-10 21:50 ` Greg KH
2020-02-11 6:03 ` Dan Carpenter
[not found] ` <20200131090510.7112-1-hdanton@sina.com>
2020-01-31 10:16 ` Dan Carpenter [this message]
2020-01-31 11:19 ` Dmitry Vyukov
2020-01-31 13:37 ` Johan Hovold
2020-01-31 14:25 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131101644.GE11068@kadam \
--to=dan.carpenter@oracle.com \
--cc=andreyknvl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=ingrassia@epigenesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).