* [PATCH] platform/x86: pmc_atom: Add Lex 2I385SW to critclk_systems DMI table
@ 2020-02-03 20:11 Georg Müller
2020-02-03 21:17 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Georg Müller @ 2020-02-03 20:11 UTC (permalink / raw)
To: linux-kernel, platform-driver-x86, Hans de Goede, Darren Hart,
Andy Shevchenko
Cc: Georg Müller
The Lex 2I385SW board has two Intel I211 ethernet controllers. Without
this patch, only the first port is usable. The second port fails to
start with the following message:
igb: probe of 0000:02:00.0 failed with error -2
Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Tested-by: Georg Müller <georgmueller@gmx.net>
Signed-off-by: Georg Müller <georgmueller@gmx.net>
---
drivers/platform/x86/pmc_atom.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index 3e3c66dfec2e..ca684ed760d1 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -383,6 +383,14 @@ static const struct dmi_system_id critclk_systems[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "3I380D"),
},
},
+ {
+ /* pmc_plt_clk* - are used for ethernet controllers */
+ .ident = "Lex 2I385SW",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Lex BayTrail"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "2I385SW"),
+ },
+ },
{
/* pmc_plt_clk* - are used for ethernet controllers */
.ident = "Beckhoff CB3163",
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: pmc_atom: Add Lex 2I385SW to critclk_systems DMI table
2020-02-03 20:11 [PATCH] platform/x86: pmc_atom: Add Lex 2I385SW to critclk_systems DMI table Georg Müller
@ 2020-02-03 21:17 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2020-02-03 21:17 UTC (permalink / raw)
To: Georg Müller, linux-kernel, platform-driver-x86,
Darren Hart, Andy Shevchenko
Hi,
On 03-02-2020 21:11, Georg Müller wrote:
> The Lex 2I385SW board has two Intel I211 ethernet controllers. Without
> this patch, only the first port is usable. The second port fails to
> start with the following message:
>
> igb: probe of 0000:02:00.0 failed with error -2
>
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Tested-by: Georg Müller <georgmueller@gmx.net>
> Signed-off-by: Georg Müller <georgmueller@gmx.net>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/pmc_atom.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index 3e3c66dfec2e..ca684ed760d1 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -383,6 +383,14 @@ static const struct dmi_system_id critclk_systems[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "3I380D"),
> },
> },
> + {
> + /* pmc_plt_clk* - are used for ethernet controllers */
> + .ident = "Lex 2I385SW",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Lex BayTrail"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "2I385SW"),
> + },
> + },
> {
> /* pmc_plt_clk* - are used for ethernet controllers */
> .ident = "Beckhoff CB3163",
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-03 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 20:11 [PATCH] platform/x86: pmc_atom: Add Lex 2I385SW to critclk_systems DMI table Georg Müller
2020-02-03 21:17 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).