From: David Miller <davem@davemloft.net>
To: harini.katakam@xilinx.com
Cc: nicolas.ferre@microchip.com, claudiu.beznea@microchip.com,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@xilinx.com,
harinikatakamlinux@gmail.com
Subject: Re: [PATCH v2 1/2] net: macb: Remove unnecessary alignment check for TSO
Date: Tue, 04 Feb 2020 10:37:18 +0100 (CET) [thread overview]
Message-ID: <20200204.103718.1343105885567379294.davem@davemloft.net> (raw)
In-Reply-To: <1580735882-7429-2-git-send-email-harini.katakam@xilinx.com>
From: Harini Katakam <harini.katakam@xilinx.com>
Date: Mon, 3 Feb 2020 18:48:01 +0530
> The IP TSO implementation does NOT require the length to be a
> multiple of 8. That is only a requirement for UFO as per IP
> documentation.
>
> Fixes: 1629dd4f763c ("cadence: Add LSO support.")
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> ---
> v2:
> Added Fixes tag
Several problems with this.
The subject talks about alignemnt check, but you are not changing
the alignment check. Instead you are modifying the linear buffer
check:
> @@ -1792,7 +1792,7 @@ static netdev_features_t macb_features_check(struct sk_buff *skb,
> /* Validate LSO compatibility */
>
> /* there is only one buffer */
> - if (!skb_is_nonlinear(skb))
> + if (!skb_is_nonlinear(skb) || (ip_hdr(skb)->protocol != IPPROTO_UDP))
> return features;
So either your explanation is wrong or the code change is wrong.
Furthermore, if you add this condition then there is now dead code
below this. The code that checks for example:
/* length of header */
hdrlen = skb_transport_offset(skb);
if (ip_hdr(skb)->protocol == IPPROTO_TCP)
hdrlen += tcp_hdrlen(skb);
will never trigger this IPPROTO_TCP condition after your change.
A lot of things about this patch do not add up.
next prev parent reply other threads:[~2020-02-04 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 13:18 [PATCH v2 0/2] TSO bug fixes Harini Katakam
2020-02-03 13:18 ` [PATCH v2 1/2] net: macb: Remove unnecessary alignment check for TSO Harini Katakam
2020-02-04 9:37 ` David Miller [this message]
[not found] ` <BN7PR02MB5121912B4AE8633C50D6DE98C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
2020-02-04 10:22 ` Harini Katakam
2020-02-04 11:43 ` David Miller
2020-02-03 13:18 ` [PATCH v2 2/2] net: macb: Limit maximum GEM TX length in TSO Harini Katakam
2020-02-04 9:37 ` David Miller
[not found] ` <BN7PR02MB51215810D1240E98E81F6176C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
2020-02-04 10:26 ` Harini Katakam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204.103718.1343105885567379294.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.beznea@microchip.com \
--cc=harini.katakam@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).