From: Harini Katakam <harinik@xilinx.com>
To: David Miller <davem@davemloft.net>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michal Simek <michal.simek@xilinx.com>,
Harini Katakam <harini.katakam@xilinx.com>,
Harini Katakam <harinikatakamlinux@gmail.com>
Subject: Re: [PATCH v2 2/2] net: macb: Limit maximum GEM TX length in TSO
Date: Tue, 4 Feb 2020 15:56:51 +0530 [thread overview]
Message-ID: <CAFcVECKXoG5Cdi2Ef2D13zj7afx4ZVVyTRRm0H84dzEAYFvHnA@mail.gmail.com> (raw)
In-Reply-To: <BN7PR02MB51215810D1240E98E81F6176C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
Hi David,
<snip>
> > > v2:
> > > Use 0x3FC0 by default
> >
> > You should add a comment above the definition which explains how this value
> > was derived. It looks magic currently.
I'll add a comment. The value was specified in the errata document that Cadence
provided to us.
Regards,
Harini
prev parent reply other threads:[~2020-02-04 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 13:18 [PATCH v2 0/2] TSO bug fixes Harini Katakam
2020-02-03 13:18 ` [PATCH v2 1/2] net: macb: Remove unnecessary alignment check for TSO Harini Katakam
2020-02-04 9:37 ` David Miller
[not found] ` <BN7PR02MB5121912B4AE8633C50D6DE98C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
2020-02-04 10:22 ` Harini Katakam
2020-02-04 11:43 ` David Miller
2020-02-03 13:18 ` [PATCH v2 2/2] net: macb: Limit maximum GEM TX length in TSO Harini Katakam
2020-02-04 9:37 ` David Miller
[not found] ` <BN7PR02MB51215810D1240E98E81F6176C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
2020-02-04 10:26 ` Harini Katakam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFcVECKXoG5Cdi2Ef2D13zj7afx4ZVVyTRRm0H84dzEAYFvHnA@mail.gmail.com \
--to=harinik@xilinx.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=harini.katakam@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).