* [PATCH] ASoC: soc-core: fix an uninitialized use
@ 2020-02-06 20:03 Jian Cai
2020-02-06 23:28 ` Nick Desaulniers
0 siblings, 1 reply; 3+ messages in thread
From: Jian Cai @ 2020-02-06 20:03 UTC (permalink / raw)
Cc: caij2003, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-kernel
Fixed the uninitialized use of a signed integer variable ret in
soc_probe_component when all its definitions are not executed. This
caused -ftrivial-auto-var-init=pattern to initialize the variable to
repeated 0xAA (i.e. a negative value) and triggered the following code
unintentionally.
err_probe:
if (ret < 0)
soc_cleanup_component(component);
Signed-off-by: Jian Cai <caij2003@gmail.com>
---
sound/soc/soc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 068d809c349a..bfb813ba34f3 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1180,7 +1180,7 @@ static int soc_probe_component(struct snd_soc_card *card,
snd_soc_component_get_dapm(component);
struct snd_soc_dai *dai;
int probed = 0;
- int ret;
+ int ret = 0;
if (!strcmp(component->name, "snd-soc-dummy"))
return 0;
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] ASoC: soc-core: fix an uninitialized use
2020-02-06 20:03 [PATCH] ASoC: soc-core: fix an uninitialized use Jian Cai
@ 2020-02-06 23:28 ` Nick Desaulniers
[not found] ` <CAOHxzjGiO54BwUDR4zz6MwvFT3-XXDx830cQcQAcVUPA1N_emA@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2020-02-06 23:28 UTC (permalink / raw)
To: caij2003
Cc: alsa-devel, broonie, lgirdwood, linux-kernel, perex, tiwai,
clang-built-linux
> Fixed the uninitialized use of a signed integer variable ret in
> soc_probe_component when all its definitions are not executed. This
> caused -ftrivial-auto-var-init=pattern to initialize the variable to
> repeated 0xAA (i.e. a negative value) and triggered the following code
> unintentionally.
> Signed-off-by: Jian Cai <caij2003@gmail.com>
Hi Jian,
I don't quite follow; it looks like `ret` is assigned to multiple times in
`soc_probe_component`. Are one of the return values of one of the functions
that are called then assigned to `ret` undefined? What control flow path leaves
`ret` unitialized?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-07 0:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 20:03 [PATCH] ASoC: soc-core: fix an uninitialized use Jian Cai
2020-02-06 23:28 ` Nick Desaulniers
[not found] ` <CAOHxzjGiO54BwUDR4zz6MwvFT3-XXDx830cQcQAcVUPA1N_emA@mail.gmail.com>
2020-02-07 0:04 ` Nick Desaulniers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).