* [PATCH next] mptcp: make the symbol 'mptcp_sk_clone_lock' static
@ 2020-02-10 8:27 Chen Wandun
2020-02-10 9:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chen Wandun @ 2020-02-10 8:27 UTC (permalink / raw)
To: mathew.j.martineau, matthieu.baerts, davem, kuba, fw, netdev,
mptcp, linux-kernel
Cc: chenwandun
Fix the following sparse warning:
net/mptcp/protocol.c:646:13: warning: symbol 'mptcp_sk_clone_lock' was not declared. Should it be static?
Fixes: b0519de8b3f1 ("mptcp: fix use-after-free for ipv6")
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
net/mptcp/protocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 73780b4cb108..030dee668e0a 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -643,7 +643,7 @@ static struct ipv6_pinfo *mptcp_inet6_sk(const struct sock *sk)
}
#endif
-struct sock *mptcp_sk_clone_lock(const struct sock *sk)
+static struct sock *mptcp_sk_clone_lock(const struct sock *sk)
{
struct sock *nsk = sk_clone_lock(sk, GFP_ATOMIC);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] mptcp: make the symbol 'mptcp_sk_clone_lock' static
2020-02-10 8:27 [PATCH next] mptcp: make the symbol 'mptcp_sk_clone_lock' static Chen Wandun
@ 2020-02-10 9:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-10 9:24 UTC (permalink / raw)
To: chenwandun
Cc: mathew.j.martineau, matthieu.baerts, kuba, fw, netdev, mptcp,
linux-kernel
From: Chen Wandun <chenwandun@huawei.com>
Date: Mon, 10 Feb 2020 16:27:59 +0800
> Fix the following sparse warning:
> net/mptcp/protocol.c:646:13: warning: symbol 'mptcp_sk_clone_lock' was not declared. Should it be static?
>
> Fixes: b0519de8b3f1 ("mptcp: fix use-after-free for ipv6")
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-10 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 8:27 [PATCH next] mptcp: make the symbol 'mptcp_sk_clone_lock' static Chen Wandun
2020-02-10 9:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).