From: Peter Zijlstra <peterz@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Will Deacon <will@kernel.org>,
Michael Schmitz <schmitzmic@gmail.com>,
Greg Ungerer <gerg@linux-m68k.org>,
sean.j.christopherson@intel.com
Subject: Re: Checkpatch being daft, Was: [PATCH -v2 08/10] m68k,mm: Extend table allocator for multiple sizes
Date: Mon, 10 Feb 2020 17:38:43 +0100 [thread overview]
Message-ID: <20200210163843.GL14897@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <3f8a8a2f89bfd2d4cca9ac176ef41abf3a0ed4ab.camel@perches.com>
On Sun, Feb 09, 2020 at 10:24:15AM -0800, Joe Perches wrote:
> Maybe this?
This isn't anywhere near RFC compliant, but I do think it greatly
improves the current situation, so:
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
one little nit below..
> ---
> scripts/checkpatch.pl | 39 +++++++++++++++++++++++++++++----------
> 1 file changed, 29 insertions(+), 10 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f3b8434..17637d0 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1132,6 +1132,7 @@ sub parse_email {
> my ($formatted_email) = @_;
>
> my $name = "";
> + my $name_comment = "";
> my $address = "";
> my $comment = "";
>
> @@ -1164,6 +1165,10 @@ sub parse_email {
>
> $name = trim($name);
> $name =~ s/^\"|\"$//g;
> + $name =~ s/(\s*\([^\)]+\))\s*//;
> + if (defined($1)) {
> + $name_comment = trim($1);
> + }
> $address = trim($address);
> $address =~ s/^\<|\>$//g;
>
> @@ -1172,7 +1177,7 @@ sub parse_email {
> $name = "\"$name\"";
> }
>
> - return ($name, $address, $comment);
> + return ($name, $name_comment, $address, $comment);
> }
>
> sub format_email {
> @@ -1198,6 +1203,23 @@ sub format_email {
> return $formatted_email;
> }
>
> +sub reformat_email {
> + my ($email) = @_;
> +
> + my ($email_name, $name_comment, $email_address, $comment) = parse_email($email);
> + return format_email($email_name, $email_address);
> +}
> +
> +sub same_email_addresses {
> + my ($email1, $email2) = @_;
> +
> + my ($email1_name, $name1_comment, $email1_address, $comment1) = parse_email($email1);
> + my ($email2_name, $name2_comment, $email2_address, $comment2) = parse_email($email2);
> +
> + return $email1_name eq $email2_name &&
> + $email1_address eq $email2_address;
strictly speaking only _address needs be the same for the whole thing to
arrive at the same inbox, but I suppose that for sanity's sake, this
comparison makes sense.
> +}
next prev parent reply other threads:[~2020-02-10 16:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 12:45 [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 01/10] m68k,mm: Remove stray nocache in ColdFire pgalloc Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 02/10] m68k,mm: Fix ColdFire pgd_alloc() Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 03/10] m68k,mm: Unify Motorola MMU page setup Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 04/10] m68k,mm: Move the pointer table allocator to motorola.c Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 05/10] m68k,mm: Restructure Motorola MMU page-table layout Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 06/10] m68k,mm: Improve kernel_page_table() Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 07/10] m68k,mm: Use table allocator for pgtables Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 08/10] m68k,mm: Extend table allocator for multiple sizes Peter Zijlstra
2020-02-07 10:56 ` Geert Uytterhoeven
2020-02-07 11:34 ` Peter Zijlstra
2020-02-07 12:11 ` Geert Uytterhoeven
2020-02-07 12:30 ` Checkpatch being daft, Was: " Peter Zijlstra
2020-02-07 12:33 ` Peter Zijlstra
2020-02-09 18:24 ` Joe Perches
2020-02-10 16:38 ` Peter Zijlstra [this message]
2020-02-10 17:12 ` Joe Perches
2020-02-10 18:52 ` [PATCH] checkpatch: Remove email address comment from email address comparisons Joe Perches
2020-02-10 22:25 ` Andrew Morton
2020-02-10 23:08 ` Joe Perches
2020-02-07 12:57 ` Checkpatch being daft, Was: [PATCH -v2 08/10] m68k,mm: Extend table allocator for multiple sizes Joe Perches
2020-01-31 12:45 ` [PATCH -v2 09/10] m68k,mm: Fully initialize the page-table allocator Peter Zijlstra
2020-02-07 10:58 ` Geert Uytterhoeven
2020-02-07 11:37 ` Peter Zijlstra
2020-01-31 12:45 ` [PATCH -v2 10/10] m68k,mm: Change ColdFire pgtable_t Peter Zijlstra
2020-01-31 13:19 ` [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout Greg Ungerer
2020-02-03 1:20 ` Greg Ungerer
2020-02-01 8:07 ` Michael Schmitz
2020-02-03 9:50 ` Will Deacon
2020-02-10 11:16 ` Geert Uytterhoeven
2020-03-09 10:15 ` Geert Uytterhoeven
2020-03-09 11:46 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210163843.GL14897@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schmitzmic@gmail.com \
--cc=sean.j.christopherson@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).