From: Greg KH <firstname.lastname@example.org> To: Wu Hao <email@example.com> Cc: Will Deacon <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, Luwei Kang <firstname.lastname@example.org> Subject: Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support Date: Wed, 12 Feb 2020 05:20:45 -0800 [thread overview] Message-ID: <20200212132045.GC1789899@kroah.com> (raw) In-Reply-To: <20200212100211.GA10436@hao-dev> On Wed, Feb 12, 2020 at 06:02:11PM +0800, Wu Hao wrote: > On Tue, Feb 11, 2020 at 09:30:35PM -0800, Greg KH wrote: > > On Wed, Feb 12, 2020 at 11:19:29AM +0800, Wu Hao wrote: > > > On Mon, Feb 10, 2020 at 04:34:01PM +0000, Will Deacon wrote: > > > > Hi, > > > > > > > > On Mon, Feb 10, 2020 at 11:47:49AM +0800, Wu Hao wrote: > > > > > This patch adds support for performance reporting private feature > > > > > for FPGA Management Engine (FME). Now it supports several different > > > > > performance counters, including 'basic', 'cache', 'fabric', 'vtd' > > > > > and 'vtd_sip'. It allows user to use standard linux tools to access > > > > > these performance counters. > > > > > > > > I had a quick look at this, and it mostly looks alright to me. Just a few > > > > high-level comments/questions: > > > > > > Hi Will > > > > > > Thanks a lot for the review! :) > > > > > > > > > > > - I would still prefer for the PMU drivers to live under drivers/perf/ > > > > > > Hm.. one possible way is to create a platform device, and introduce a new > > > platform device driver under drivers/perf/. > > > > No, do not abuse platform drivers, you have a real device, use it. > > Sure, thanks for the comments. Then I don't have any other idea to move code to > drivers/perf/ directory, so probably only can live with current code. The location of the file in the kernel tree has no bearing on if you use a platform device, a USB device, or a PCI device. It is just a location of a file. You are interacting with the perf api as the driver's primary userspace api, so put the driver into the drivers/perf/ directory. That's all that Will is asking you to do here. greg k-h
next prev parent reply other threads:[~2020-02-12 13:20 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-10 3:47 [PATCH v7 0/2] add performance reporting support to FPGA DFL drivers Wu Hao 2020-02-10 3:47 ` [PATCH v7 1/2] Documentation: fpga: dfl: add description for performance reporting support Wu Hao 2020-02-10 3:47 ` [PATCH v7 2/2] fpga: dfl: fme: add " Wu Hao 2020-02-10 16:34 ` Will Deacon 2020-02-12 3:19 ` Wu Hao 2020-02-12 5:30 ` Greg KH 2020-02-12 10:02 ` Wu Hao 2020-02-12 13:20 ` Greg KH [this message] 2020-02-13 2:51 ` Wu Hao 2020-02-10 20:56 ` Greg KH 2020-02-12 2:39 ` Wu Hao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200212132045.GC1789899@kroah.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).