From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Prashant Malani <pmalani@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
heikki.krogerus@intel.com,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Guenter Roeck <groeck@chromium.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: Add cros-ec Type C port driver
Date: Wed, 12 Feb 2020 17:53:09 +0200 [thread overview]
Message-ID: <20200212155309.GG1498@kuha.fi.intel.com> (raw)
In-Reply-To: <CAL_JsqKnQDhnb14TsOeHhXS0UAX6kexe44pfOntrbEcxB0CC9A@mail.gmail.com>
Hi Rob,
On Tue, Feb 11, 2020 at 05:25:13PM -0600, Rob Herring wrote:
> > +examples:
> > + - |+
> > + typec {
> > + compatible = "google,cros-ec-typec";
> > +
> > + port@0 {
>
> 'port' is reserved for OF graph binding which this is not.
>
> > + port-number = <0>;
> > + power-role = "dual";
> > + data-role = "dual";
> > + try-power-role = "source";
>
> These are usb-connector binding properties, but this is not a
> usb-connector node. However, I think it should be. The main thing to
> work out seems to be have multiple connectors.
>
> With your binding, how does one associate the USB host controller with
> each port/connector? That's a solved problem with the connector
> binding.
It looks like OF graph is required to be used for that. The plan was
actually to propose that we use device properties "usb2-port" and
"usb3-port" that directly reference the port nodes under the USB host
controller, but I guess that's too late for that.
OF graph creates one problem. We are going to need to identify the
endpoints somehow in the USB Type-C drivers, so how do we know which
endpoint is for example the USB2 port, which is USB3, which is
DisplayPort, etc?
Does the remote-endpoint parent need to have a specific compatible
property, like the USB2 port needs to have compatible = "usb2-port"
and so on?
thanks,
--
heikki
next prev parent reply other threads:[~2020-02-12 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 20:37 [PATCH v2 0/4] platform/chrome: Add Type C connector class driver Prashant Malani
2020-02-07 20:37 ` [PATCH v2 1/4] dt-bindings: Add cros-ec Type C port driver Prashant Malani
2020-02-11 10:28 ` Enric Balletbo i Serra
[not found] ` <CACeCKac-OjvCLZ4FefsGbH9JR_suB3nL5CVLa_N0o9qnSqi3-g@mail.gmail.com>
2020-02-11 19:01 ` Prashant Malani
2020-02-11 23:25 ` Rob Herring
2020-02-12 15:53 ` Heikki Krogerus [this message]
2020-02-07 20:37 ` [PATCH v2 2/4] platform/chrome: Add Type C connector class driver Prashant Malani
2020-02-11 11:26 ` Enric Balletbo i Serra
2020-02-12 16:53 ` Heikki Krogerus
2020-02-07 20:37 ` [PATCH v2 3/4] platform/chrome: typec: Get PD_CONTROL cmd version Prashant Malani
2020-02-11 10:52 ` Enric Balletbo i Serra
2020-02-07 20:37 ` [PATCH v2 4/4] platform/chrome: typec: Update port info from EC Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212155309.GG1498@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmalani@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).