From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Prashant Malani <pmalani@chromium.org>, linux-kernel@vger.kernel.org
Cc: heikki.krogerus@intel.com, bleung@chromium.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Guenter Roeck <groeck@chromium.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: Add cros-ec Type C port driver
Date: Tue, 11 Feb 2020 11:28:16 +0100 [thread overview]
Message-ID: <dd9a8fa7-db6b-87a0-889d-b56a626a3078@collabora.com> (raw)
In-Reply-To: <20200207203752.209296-2-pmalani@chromium.org>
Hi Prashant,
On 7/2/20 21:37, Prashant Malani wrote:
> Some Chrome OS devices with Embedded Controllers (EC) can read and
> modify Type C port state.
>
> Add an entry in the DT Bindings documentation that lists out the logical
> device and describes the relevant port information, to be used by the
> corresponding driver.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
>
> Changes in v2:
> - No changes. Patch first introduced in v2 of series.
>
> .../bindings/chrome/google,cros-ec-typec.yaml | 77 +++++++++++++++++++
> 1 file changed, 77 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml
>
> diff --git a/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml
> new file mode 100644
> index 00000000000000..46ebcbe76db3c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: GPL-2.0
I think that Google is fine with the dual licensing here. Would be good if this
can be (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/chrome/google,cros-ec-typec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Google Chrome OS EC(Embedded Controller) Type C port driver.
> +
> +maintainers:
> + - Benson Leung <bleung@chromium.org>
> + - Prashant Malani <pmalani@chromium.org>
> +
> +description:
> + Chrome OS devices have an Embedded Controller(EC) which has access to
> + Type C port state. This node is intended to allow the host to read and
> + control the Type C ports. The node for this device should be under a
> + cros-ec node like google,cros-ec-spi.
> +
> +properties:
> + compatible:
> + const: google,cros-ec-typec
> +
> + port:
> + description: A node that represents a physical Type C port on the
> + device.
> + type: object
> + properties:
> + port-number:
> + description: The number used by the Chrome OS EC to identify
> + this type C port.
> + $ref: /schemas/types.yaml#/definitions/uint32
Any range of values allowed? 0 is okay?
> + power-role:
Sorry if this question is silly, aren't this and below properties the same as
provided by usb-connector? Can't this be usb-c-connector?
Documentation/devicetree/bindings/connector/usb-connector.txt
> + description: Determines the power role that the Type C port will
> + adopt.
> + oneOf:
> + - items:
> + - const: sink
> + - const: source
> + - const: dual
> + data-role:
> + description: Determines the data role that the Type C port will
> + adopt.
> + oneOf:
> + - items:
> + - const: host
> + - const: device
> + - const: dual
> + try-power-role:
> + description: Determines the preferred power role of the Type C port.
> + oneOf:
> + - items:
> + - const: sink
> + - const: source
> + - const: dual
> +
> + required:
> + - port-number
> + - power-role
> + - data-role
> + - try-power-role
> +
> +required:
> + - compatible
> + - port
> +
> +examples:
> + - |+
Rob can confirm, but I think is a good practice add the parent node, so add the
cros-ec-spi node here?
> + typec {
> + compatible = "google,cros-ec-typec";
> +
> + port@0 {
You can run:
make dt_binding_check DT_SCHEMA_FILES=<...>/chrome/google,cros-ec-typec.yaml
And you'll get an error:
typec: 'port' is a required property
> + port-number = <0>;
> + power-role = "dual";
> + data-role = "dual";
> + try-power-role = "source";
> + };
> + };
>
Thanks,
Enric
next prev parent reply other threads:[~2020-02-11 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 20:37 [PATCH v2 0/4] platform/chrome: Add Type C connector class driver Prashant Malani
2020-02-07 20:37 ` [PATCH v2 1/4] dt-bindings: Add cros-ec Type C port driver Prashant Malani
2020-02-11 10:28 ` Enric Balletbo i Serra [this message]
[not found] ` <CACeCKac-OjvCLZ4FefsGbH9JR_suB3nL5CVLa_N0o9qnSqi3-g@mail.gmail.com>
2020-02-11 19:01 ` Prashant Malani
2020-02-11 23:25 ` Rob Herring
2020-02-12 15:53 ` Heikki Krogerus
2020-02-07 20:37 ` [PATCH v2 2/4] platform/chrome: Add Type C connector class driver Prashant Malani
2020-02-11 11:26 ` Enric Balletbo i Serra
2020-02-12 16:53 ` Heikki Krogerus
2020-02-07 20:37 ` [PATCH v2 3/4] platform/chrome: typec: Get PD_CONTROL cmd version Prashant Malani
2020-02-11 10:52 ` Enric Balletbo i Serra
2020-02-07 20:37 ` [PATCH v2 4/4] platform/chrome: typec: Update port info from EC Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd9a8fa7-db6b-87a0-889d-b56a626a3078@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmalani@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).