linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	Oleg Nesterov <oleg@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v6 0/6] clone3 & cgroups: allow spawning processes into cgroups
Date: Thu, 13 Feb 2020 13:52:31 +0100	[thread overview]
Message-ID: <20200213125231.3vod5lckaej6na7w@wittgenstein> (raw)
In-Reply-To: <20200212230127.GA88887@mtj.thefacebook.com>

On Wed, Feb 12, 2020 at 06:01:27PM -0500, Tejun Heo wrote:
> On Wed, Feb 05, 2020 at 02:26:17PM +0100, Christian Brauner wrote:
> > Hey Tejun,
> > 
> > This is v6 of the promised series to enable spawning processes into a
> > target cgroup different from the parent's cgroup.
> 
> Applied 1-6 to cgroup/for-5.7. There was a conflict with 0cd9d33ace33
> ("cgroup: init_tasks shouldn't be linked to the root cgroup") which
> got fixed up while applying. I'd really appreciate if you can take a
> look to see everything is ok.

Looked at it just now and all seems sane.
The reference to init_tasks threw me off at first. I initially thought
you're talking about pid namespace inits but you mean tasks created via
fork_idle() here. Since those tasks can't be created with
CLONE_INTO_CGROUP set it's perfectly safe to set cset = NULL
unconditionally.
Thanks for fixing the merge conflict!
> 
> Thanks a lot for working on this. This is really great.

Thanks, I think so too!
Christian

      reply	other threads:[~2020-02-13 12:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 13:26 [PATCH v6 0/6] clone3 & cgroups: allow spawning processes into cgroups Christian Brauner
2020-02-05 13:26 ` [PATCH v6 1/6] cgroup: unify attach permission checking Christian Brauner
2020-02-05 13:26 ` [PATCH v6 2/6] cgroup: add cgroup_get_from_file() helper Christian Brauner
2020-02-05 13:26 ` [PATCH v6 3/6] cgroup: refactor fork helpers Christian Brauner
2020-02-05 13:26 ` [PATCH v6 4/6] cgroup: add cgroup_may_write() helper Christian Brauner
2020-02-05 13:26 ` [PATCH v6 5/6] clone3: allow spawning processes into cgroups Christian Brauner
2020-02-05 13:26 ` [PATCH v6 6/6] selftests/cgroup: add tests for cloning " Christian Brauner
2020-02-12 23:01 ` [PATCH v6 0/6] clone3 & cgroups: allow spawning processes " Tejun Heo
2020-02-13 12:52   ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213125231.3vod5lckaej6na7w@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).