* [PATCH] usb: typec: ucsi: remove redundant assignment to variable num
@ 2020-02-08 16:50 Colin King
2020-02-13 11:34 ` Heikki Krogerus
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2020-02-08 16:50 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable num is being assigned with a value that is never read, it is
assigned a new value later in a for-loop. The assignment is redundant
and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/typec/ucsi/ucsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
index d5a6aac86327..b1b72cb7af10 100644
--- a/drivers/usb/typec/ucsi/ucsi.c
+++ b/drivers/usb/typec/ucsi/ucsi.c
@@ -400,7 +400,7 @@ static int ucsi_register_altmodes(struct ucsi_connector *con, u8 recipient)
struct typec_altmode_desc desc;
struct ucsi_altmode alt[2];
u64 command;
- int num = 1;
+ int num;
int ret;
int len;
int j;
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: typec: ucsi: remove redundant assignment to variable num
2020-02-08 16:50 [PATCH] usb: typec: ucsi: remove redundant assignment to variable num Colin King
@ 2020-02-13 11:34 ` Heikki Krogerus
2020-02-13 13:04 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Heikki Krogerus @ 2020-02-13 11:34 UTC (permalink / raw)
To: Colin King, Greg Kroah-Hartman; +Cc: linux-usb, kernel-janitors, linux-kernel
On Sat, Feb 08, 2020 at 04:50:22PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable num is being assigned with a value that is never read, it is
> assigned a new value later in a for-loop. The assignment is redundant
> and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/typec/ucsi/ucsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index d5a6aac86327..b1b72cb7af10 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -400,7 +400,7 @@ static int ucsi_register_altmodes(struct ucsi_connector *con, u8 recipient)
> struct typec_altmode_desc desc;
> struct ucsi_altmode alt[2];
> u64 command;
> - int num = 1;
> + int num;
> int ret;
> int len;
> int j;
Greg! I'll pick this, and to you with a few other patches that I have
in my queue for the ucsi driver. I hope that's OK.
thanks,
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: typec: ucsi: remove redundant assignment to variable num
2020-02-13 11:34 ` Heikki Krogerus
@ 2020-02-13 13:04 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-02-13 13:04 UTC (permalink / raw)
To: Heikki Krogerus; +Cc: Colin King, linux-usb, kernel-janitors, linux-kernel
On Thu, Feb 13, 2020 at 01:34:23PM +0200, Heikki Krogerus wrote:
> On Sat, Feb 08, 2020 at 04:50:22PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Variable num is being assigned with a value that is never read, it is
> > assigned a new value later in a for-loop. The assignment is redundant
> > and can be removed.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/usb/typec/ucsi/ucsi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> > index d5a6aac86327..b1b72cb7af10 100644
> > --- a/drivers/usb/typec/ucsi/ucsi.c
> > +++ b/drivers/usb/typec/ucsi/ucsi.c
> > @@ -400,7 +400,7 @@ static int ucsi_register_altmodes(struct ucsi_connector *con, u8 recipient)
> > struct typec_altmode_desc desc;
> > struct ucsi_altmode alt[2];
> > u64 command;
> > - int num = 1;
> > + int num;
> > int ret;
> > int len;
> > int j;
>
> Greg! I'll pick this, and to you with a few other patches that I have
> in my queue for the ucsi driver. I hope that's OK.
Thats fine.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-13 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 16:50 [PATCH] usb: typec: ucsi: remove redundant assignment to variable num Colin King
2020-02-13 11:34 ` Heikki Krogerus
2020-02-13 13:04 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).