linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] virtio_balloon: Adjust label in virtballoon_probe
@ 2020-02-16  0:40 Nathan Chancellor
  2020-02-16  7:36 ` David Hildenbrand
  2020-02-17  8:37 ` David Hildenbrand
  0 siblings, 2 replies; 5+ messages in thread
From: Nathan Chancellor @ 2020-02-16  0:40 UTC (permalink / raw)
  To: Michael S. Tsirkin, Jason Wang
  Cc: David Hildenbrand, virtualization, linux-kernel,
	clang-built-linux, Nathan Chancellor

Clang warns when CONFIG_BALLOON_COMPACTION is unset:

../drivers/virtio/virtio_balloon.c:963:1: warning: unused label
'out_del_vqs' [-Wunused-label]
out_del_vqs:
^~~~~~~~~~~~
1 warning generated.

Move the label within the preprocessor block since it is only used when
CONFIG_BALLOON_COMPACTION is set.

Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()")
Link: https://github.com/ClangBuiltLinux/linux/issues/886
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 drivers/virtio/virtio_balloon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 7bfe365d9372..341458fd95ca 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -959,8 +959,8 @@ static int virtballoon_probe(struct virtio_device *vdev)
 	iput(vb->vb_dev_info.inode);
 out_kern_unmount:
 	kern_unmount(balloon_mnt);
-#endif
 out_del_vqs:
+#endif
 	vdev->config->del_vqs(vdev);
 out_free_vb:
 	kfree(vb);
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_balloon: Adjust label in virtballoon_probe
  2020-02-16  0:40 [PATCH] virtio_balloon: Adjust label in virtballoon_probe Nathan Chancellor
@ 2020-02-16  7:36 ` David Hildenbrand
  2020-02-16  7:47   ` Nathan Chancellor
  2020-02-17  8:37 ` David Hildenbrand
  1 sibling, 1 reply; 5+ messages in thread
From: David Hildenbrand @ 2020-02-16  7:36 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: Michael S. Tsirkin, Jason Wang, David Hildenbrand,
	virtualization, linux-kernel, clang-built-linux



> Am 16.02.2020 um 01:41 schrieb Nathan Chancellor <natechancellor@gmail.com>:
> 
> Clang warns when CONFIG_BALLOON_COMPACTION is unset:
> 
> ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label
> 'out_del_vqs' [-Wunused-label]
> out_del_vqs:
> ^~~~~~~~~~~~
> 1 warning generated.
> 

Thanks, there is already „ [PATCH] virtio_balloon: Fix unused label warning“ from Boris on the list.

Cheers!

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_balloon: Adjust label in virtballoon_probe
  2020-02-16  7:36 ` David Hildenbrand
@ 2020-02-16  7:47   ` Nathan Chancellor
  2020-02-16  8:06     ` David Hildenbrand
  0 siblings, 1 reply; 5+ messages in thread
From: Nathan Chancellor @ 2020-02-16  7:47 UTC (permalink / raw)
  To: David Hildenbrand
  Cc: Michael S. Tsirkin, Jason Wang, virtualization, linux-kernel,
	clang-built-linux

On Sun, Feb 16, 2020 at 08:36:45AM +0100, David Hildenbrand wrote:
> 
> 
> > Am 16.02.2020 um 01:41 schrieb Nathan Chancellor <natechancellor@gmail.com>:
> > 
> > Clang warns when CONFIG_BALLOON_COMPACTION is unset:
> > 
> > ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label
> > 'out_del_vqs' [-Wunused-label]
> > out_del_vqs:
> > ^~~~~~~~~~~~
> > 1 warning generated.
> > 
> 
> Thanks, there is already „ [PATCH] virtio_balloon: Fix unused label warning“ from Boris on the list.
> 
> Cheers!
> 

Sorry for the noise, I thought I did a search for duplicate patches but
seems I missed it :/ I've commented on that patch.

Cheers,
Nathan

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_balloon: Adjust label in virtballoon_probe
  2020-02-16  7:47   ` Nathan Chancellor
@ 2020-02-16  8:06     ` David Hildenbrand
  0 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2020-02-16  8:06 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: David Hildenbrand, Michael S. Tsirkin, Jason Wang,
	virtualization, linux-kernel, clang-built-linux



> Am 16.02.2020 um 08:47 schrieb Nathan Chancellor <natechancellor@gmail.com>:
> 
> On Sun, Feb 16, 2020 at 08:36:45AM +0100, David Hildenbrand wrote:
>> 
>> 
>>>> Am 16.02.2020 um 01:41 schrieb Nathan Chancellor <natechancellor@gmail.com>:
>>> 
>>> Clang warns when CONFIG_BALLOON_COMPACTION is unset:
>>> 
>>> ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label
>>> 'out_del_vqs' [-Wunused-label]
>>> out_del_vqs:
>>> ^~~~~~~~~~~~
>>> 1 warning generated.
>>> 
>> 
>> Thanks, there is already „ [PATCH] virtio_balloon: Fix unused label warning“ from Boris on the list.
>> 
>> Cheers!
>> 
> 
> Sorry for the noise, I thought I did a search for duplicate patches but
> seems I missed it :/ I've commented on that patch.

Your patch should be the correct one! :)

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_balloon: Adjust label in virtballoon_probe
  2020-02-16  0:40 [PATCH] virtio_balloon: Adjust label in virtballoon_probe Nathan Chancellor
  2020-02-16  7:36 ` David Hildenbrand
@ 2020-02-17  8:37 ` David Hildenbrand
  1 sibling, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2020-02-17  8:37 UTC (permalink / raw)
  To: Nathan Chancellor, Michael S. Tsirkin, Jason Wang
  Cc: virtualization, linux-kernel, clang-built-linux

On 16.02.20 01:40, Nathan Chancellor wrote:
> Clang warns when CONFIG_BALLOON_COMPACTION is unset:
> 
> ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label
> 'out_del_vqs' [-Wunused-label]
> out_del_vqs:
> ^~~~~~~~~~~~
> 1 warning generated.
> 
> Move the label within the preprocessor block since it is only used when
> CONFIG_BALLOON_COMPACTION is set.
> 
> Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()")
> Link: https://github.com/ClangBuiltLinux/linux/issues/886
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>  drivers/virtio/virtio_balloon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 7bfe365d9372..341458fd95ca 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -959,8 +959,8 @@ static int virtballoon_probe(struct virtio_device *vdev)
>  	iput(vb->vb_dev_info.inode);
>  out_kern_unmount:
>  	kern_unmount(balloon_mnt);
> -#endif
>  out_del_vqs:
> +#endif
>  	vdev->config->del_vqs(vdev);
>  out_free_vb:
>  	kfree(vb);
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-17  8:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-16  0:40 [PATCH] virtio_balloon: Adjust label in virtballoon_probe Nathan Chancellor
2020-02-16  7:36 ` David Hildenbrand
2020-02-16  7:47   ` Nathan Chancellor
2020-02-16  8:06     ` David Hildenbrand
2020-02-17  8:37 ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).