* [PATCH net-next] net: ena: remove set but not used variable 'hash_key'
@ 2020-02-18 6:21 YueHaibing
2020-02-18 6:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-02-18 6:21 UTC (permalink / raw)
To: netanel, akiyano, gtzalik, saeedb, zorik, davem, sameehj, kuba
Cc: netdev, linux-kernel, YueHaibing
drivers/net/ethernet/amazon/ena/ena_com.c: In function ena_com_hash_key_allocate:
drivers/net/ethernet/amazon/ena/ena_com.c:1070:50:
warning: variable hash_key set but not used [-Wunused-but-set-variable]
commit 6a4f7dc82d1e ("net: ena: rss: do not allocate key when not supported")
introduced this, but not used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/amazon/ena/ena_com.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
index 1fb58f9..a250046 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
@@ -1067,18 +1067,14 @@ static void ena_com_hash_key_fill_default_key(struct ena_com_dev *ena_dev)
static int ena_com_hash_key_allocate(struct ena_com_dev *ena_dev)
{
struct ena_rss *rss = &ena_dev->rss;
- struct ena_admin_feature_rss_flow_hash_control *hash_key;
struct ena_admin_get_feat_resp get_resp;
int rc;
- hash_key = (ena_dev->rss).hash_key;
-
rc = ena_com_get_feature_ex(ena_dev, &get_resp,
ENA_ADMIN_RSS_HASH_FUNCTION,
ena_dev->rss.hash_key_dma_addr,
sizeof(ena_dev->rss.hash_key), 0);
if (unlikely(rc)) {
- hash_key = NULL;
return -EOPNOTSUPP;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: ena: remove set but not used variable 'hash_key'
2020-02-18 6:21 [PATCH net-next] net: ena: remove set but not used variable 'hash_key' YueHaibing
@ 2020-02-18 6:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-18 6:33 UTC (permalink / raw)
To: yuehaibing
Cc: netanel, akiyano, gtzalik, saeedb, zorik, sameehj, kuba, netdev,
linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 18 Feb 2020 14:21:54 +0800
> drivers/net/ethernet/amazon/ena/ena_com.c: In function ena_com_hash_key_allocate:
> drivers/net/ethernet/amazon/ena/ena_com.c:1070:50:
> warning: variable hash_key set but not used [-Wunused-but-set-variable]
>
> commit 6a4f7dc82d1e ("net: ena: rss: do not allocate key when not supported")
> introduced this, but not used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-18 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18 6:21 [PATCH net-next] net: ena: remove set but not used variable 'hash_key' YueHaibing
2020-02-18 6:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).