linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* drm/bridge and lockup on boot
@ 2020-02-17 20:09 Dominik Brodowski
  2020-02-17 21:08 ` Boris Brezillon
  0 siblings, 1 reply; 6+ messages in thread
From: Dominik Brodowski @ 2020-02-17 20:09 UTC (permalink / raw)
  To: boris.brezillon, narmstrong, laurent.pinchart, jernej.skrabec, jonas
  Cc: linux-kernel

On my old Dell XPS 13 laptop with

00:00.0 Host bridge: Intel Corporation Broadwell-U Host Bridge -OPI (rev 09)
00:02.0 VGA compatible controller: Intel Corporation HD Graphics 5500 (rev 09) (prog-if 00 [VGA controller])

booting 5.6-rc1 and -rc2 fails after the dmesg line

	fb0: switching to inteldrmfb from simple

while the next lines should be something like (v5.5):

	Console: switching to colour dummy device 80x25
	i915 0000:00:02.0: vgaarb: deactivate vga console
	[drm] ACPI BIOS requests an excessive sleep of 25000 ms, using 1500 ms instead
	[drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
	[drm] Driver supports precise vblank timestamp query.
	i915 0000:00:02.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=io+mem:owns=io+mem

A git bisect lead to

	commit b86d895524ab ("drm/bridge: Add an ->atomic_check() hook")

as the first bad commit, as unlikely as that sounds. f7619a58ef92 is good,
as is bf046007641a, and 3cacb2086e41 is definitely broken on my setup.
Any ideas?

Oh, and this might be the same issue as reported here:

	https://lore.kernel.org/lkml/99fb887f-4a1b-6c15-64a6-9d089773cdd4@4net.rs/

though I do not see such a warning, but nothing new once the line "fb0: switching
to inteldrmfb from simple" is printed.

Thanks,
	Dominik

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: drm/bridge and lockup on boot
  2020-02-17 20:09 drm/bridge and lockup on boot Dominik Brodowski
@ 2020-02-17 21:08 ` Boris Brezillon
  2020-02-18 11:48   ` lockup on boot -- drm/i915/display: Force the state compute phase once to enable PSR Dominik Brodowski
  0 siblings, 1 reply; 6+ messages in thread
From: Boris Brezillon @ 2020-02-17 21:08 UTC (permalink / raw)
  To: Dominik Brodowski
  Cc: narmstrong, laurent.pinchart, jernej.skrabec, jonas, linux-kernel

On Mon, 17 Feb 2020 21:09:42 +0100
Dominik Brodowski <linux@dominikbrodowski.net> wrote:

> On my old Dell XPS 13 laptop with
> 
> 00:00.0 Host bridge: Intel Corporation Broadwell-U Host Bridge -OPI (rev 09)
> 00:02.0 VGA compatible controller: Intel Corporation HD Graphics 5500 (rev 09) (prog-if 00 [VGA controller])
> 
> booting 5.6-rc1 and -rc2 fails after the dmesg line
> 
> 	fb0: switching to inteldrmfb from simple
> 
> while the next lines should be something like (v5.5):
> 
> 	Console: switching to colour dummy device 80x25
> 	i915 0000:00:02.0: vgaarb: deactivate vga console
> 	[drm] ACPI BIOS requests an excessive sleep of 25000 ms, using 1500 ms instead
> 	[drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> 	[drm] Driver supports precise vblank timestamp query.
> 	i915 0000:00:02.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=io+mem:owns=io+mem
> 
> A git bisect lead to
> 
> 	commit b86d895524ab ("drm/bridge: Add an ->atomic_check() hook")

This commit has been reverted: you should ignore any failures between
b86d895524ab ("drm/bridge: Add an ->atomic_check() hook") and
099126352303 ("Revert "drm/bridge: Add a drm_bridge_state object").

> 
> as the first bad commit, as unlikely as that sounds. f7619a58ef92 is good,
> as is bf046007641a, and 3cacb2086e41 is definitely broken on my setup.
> Any ideas?
> 
> Oh, and this might be the same issue as reported here:
> 
> 	https://lore.kernel.org/lkml/99fb887f-4a1b-6c15-64a6-9d089773cdd4@4net.rs/
> 
> though I do not see such a warning, but nothing new once the line "fb0: switching
> to inteldrmfb from simple" is printed.
> 
> Thanks,
> 	Dominik


^ permalink raw reply	[flat|nested] 6+ messages in thread
* lockup on boot -- drm/i915/display: Force the state compute phase once to enable PSR
  2020-02-17 21:08 ` Boris Brezillon
@ 2020-02-18 11:48   ` Dominik Brodowski
  2020-02-18 18:01     ` Souza, Jose
  0 siblings, 1 reply; 6+ messages in thread
From: Dominik Brodowski @ 2020-02-18 11:48 UTC (permalink / raw)
  To: Boris Brezillon, jose.souza, s.zharkoff, gwan-gyeong.mun, jani.nikula
  Cc: narmstrong, laurent.pinchart, jernej.skrabec, jonas,
	linux-kernel, airlied

On Mon, Feb 17, 2020 at 10:08:52PM +0100, Boris Brezillon wrote:
> On Mon, 17 Feb 2020 21:09:42 +0100
> Dominik Brodowski <linux@dominikbrodowski.net> wrote:
> 
> > On my old Dell XPS 13 laptop with
> > 
> > 00:00.0 Host bridge: Intel Corporation Broadwell-U Host Bridge -OPI (rev 09)
> > 00:02.0 VGA compatible controller: Intel Corporation HD Graphics 5500 (rev 09) (prog-if 00 [VGA controller])
> > 
> > booting 5.6-rc1 and -rc2 fails after the dmesg line
> > 
> > 	fb0: switching to inteldrmfb from simple
> > 
> > while the next lines should be something like (v5.5):
> > 
> > 	Console: switching to colour dummy device 80x25
> > 	i915 0000:00:02.0: vgaarb: deactivate vga console
> > 	[drm] ACPI BIOS requests an excessive sleep of 25000 ms, using 1500 ms instead
> > 	[drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> > 	[drm] Driver supports precise vblank timestamp query.
> > 	i915 0000:00:02.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=io+mem:owns=io+mem
> > 
> > A git bisect lead to
> > 
> > 	commit b86d895524ab ("drm/bridge: Add an ->atomic_check() hook")
> 
> This commit has been reverted: you should ignore any failures between
> b86d895524ab ("drm/bridge: Add an ->atomic_check() hook") and
> 099126352303 ("Revert "drm/bridge: Add a drm_bridge_state object").

A new bisect now points to

	60c6a14b489b ("drm/i915/display: Force the state compute phase
	once to enable PSR").

Please note that bisecting this is quite a hassle, in particular due to
various reverts in between and back-merges (such as ec027b33c8bb, which has
two parents in "bad" state). As 60c6a14b489b does not revert cleanly, I
can't test a revert on top of 5.6-rc2.

Thanks,
	Dominik

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: lockup on boot -- drm/i915/display: Force the state compute phase once to enable PSR
  2020-02-18 11:48   ` lockup on boot -- drm/i915/display: Force the state compute phase once to enable PSR Dominik Brodowski
@ 2020-02-18 18:01     ` Souza, Jose
  2020-02-18 18:58       ` Dominik Brodowski
  0 siblings, 1 reply; 6+ messages in thread
From: Souza, Jose @ 2020-02-18 18:01 UTC (permalink / raw)
  To: Mun, Gwan-gyeong, Nikula, Jani, linux, s.zharkoff, boris.brezillon
  Cc: airlied, laurent.pinchart, jernej.skrabec, narmstrong,
	linux-kernel, jonas

Hi

Yes this patch has a issue and we have a fix, I'm trying to find
someone to review it, more information: 
https://gitlab.freedesktop.org/drm/intel/issues/1151

On Tue, 2020-02-18 at 12:48 +0100, Dominik Brodowski wrote:
> On Mon, Feb 17, 2020 at 10:08:52PM +0100, Boris Brezillon wrote:
> > On Mon, 17 Feb 2020 21:09:42 +0100
> > Dominik Brodowski <linux@dominikbrodowski.net> wrote:
> > 
> > > On my old Dell XPS 13 laptop with
> > > 
> > > 00:00.0 Host bridge: Intel Corporation Broadwell-U Host Bridge
> > > -OPI (rev 09)
> > > 00:02.0 VGA compatible controller: Intel Corporation HD Graphics
> > > 5500 (rev 09) (prog-if 00 [VGA controller])
> > > 
> > > booting 5.6-rc1 and -rc2 fails after the dmesg line
> > > 
> > > 	fb0: switching to inteldrmfb from simple
> > > 
> > > while the next lines should be something like (v5.5):
> > > 
> > > 	Console: switching to colour dummy device 80x25
> > > 	i915 0000:00:02.0: vgaarb: deactivate vga console
> > > 	[drm] ACPI BIOS requests an excessive sleep of 25000 ms, using
> > > 1500 ms instead
> > > 	[drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> > > 	[drm] Driver supports precise vblank timestamp query.
> > > 	i915 0000:00:02.0: vgaarb: changed VGA decodes:
> > > olddecodes=io+mem,decodes=io+mem:owns=io+mem
> > > 
> > > A git bisect lead to
> > > 
> > > 	commit b86d895524ab ("drm/bridge: Add an ->atomic_check()
> > > hook")
> > 
> > This commit has been reverted: you should ignore any failures
> > between
> > b86d895524ab ("drm/bridge: Add an ->atomic_check() hook") and
> > 099126352303 ("Revert "drm/bridge: Add a drm_bridge_state object").
> 
> A new bisect now points to
> 
> 	60c6a14b489b ("drm/i915/display: Force the state compute phase
> 	once to enable PSR").
> 
> Please note that bisecting this is quite a hassle, in particular due
> to
> various reverts in between and back-merges (such as ec027b33c8bb,
> which has
> two parents in "bad" state). As 60c6a14b489b does not revert cleanly,
> I
> can't test a revert on top of 5.6-rc2.
> 
> Thanks,
> 	Dominik

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: lockup on boot -- drm/i915/display: Force the state compute phase once to enable PSR
  2020-02-18 18:01     ` Souza, Jose
@ 2020-02-18 18:58       ` Dominik Brodowski
  2020-03-01 15:15         ` 5.5.6-rc1+: " Dominik Brodowski
  0 siblings, 1 reply; 6+ messages in thread
From: Dominik Brodowski @ 2020-02-18 18:58 UTC (permalink / raw)
  To: Souza, Jose
  Cc: Mun, Gwan-gyeong, Nikula, Jani, s.zharkoff, boris.brezillon,
	airlied, laurent.pinchart, jernej.skrabec, narmstrong,
	linux-kernel, jonas

On Tue, Feb 18, 2020 at 06:01:37PM +0000, Souza, Jose wrote:
> Hi
> 
> Yes this patch has a issue and we have a fix, I'm trying to find
> someone to review it, more information: 
> https://gitlab.freedesktop.org/drm/intel/issues/1151

Alas, that patch does not apply cleanly to -master.

Thanks,
	Dominik

^ permalink raw reply	[flat|nested] 6+ messages in thread
* 5.5.6-rc1+: lockup on boot -- drm/i915/display: Force the state compute phase once to enable PSR
  2020-02-18 18:58       ` Dominik Brodowski
@ 2020-03-01 15:15         ` Dominik Brodowski
  0 siblings, 0 replies; 6+ messages in thread
From: Dominik Brodowski @ 2020-03-01 15:15 UTC (permalink / raw)
  To: Souza, Jose, airlied
  Cc: Mun, Gwan-gyeong, Nikula, Jani, s.zharkoff, boris.brezillon,
	airlied, laurent.pinchart, jernej.skrabec, narmstrong,
	linux-kernel, jonas

On Tue, Feb 18, 2020 at 07:58:47PM +0100, Dominik Brodowski wrote:
> On Tue, Feb 18, 2020 at 06:01:37PM +0000, Souza, Jose wrote:
> > Hi
> > 
> > Yes this patch has a issue and we have a fix, I'm trying to find
> > someone to review it, more information: 
> > https://gitlab.freedesktop.org/drm/intel/issues/1151
> 
> Alas, that patch does not apply cleanly to -master.

Any update on this patch? It doesn't seem to have landed in -master yet,
though it solves a clear regression and without such a patch, my laptops
refuse to boot. So it'd be much appreciated if that patch (or a variant
thereof) is pushed upstream rather sooner than later.

Thanks,
	Dominik

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-01 15:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 20:09 drm/bridge and lockup on boot Dominik Brodowski
2020-02-17 21:08 ` Boris Brezillon
2020-02-18 11:48   ` lockup on boot -- drm/i915/display: Force the state compute phase once to enable PSR Dominik Brodowski
2020-02-18 18:01     ` Souza, Jose
2020-02-18 18:58       ` Dominik Brodowski
2020-03-01 15:15         ` 5.5.6-rc1+: " Dominik Brodowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).