* [PATCH] io_uring: remove unnecessary NULL checks
@ 2020-02-17 14:39 Dan Carpenter
2020-02-18 12:31 ` Stefano Garzarella
2020-02-18 18:22 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-02-17 14:39 UTC (permalink / raw)
To: Jens Axboe
Cc: Alexander Viro, io-uring, linux-fsdevel, linux-kernel, kernel-janitors
The "kmsg" pointer can't be NULL and we have already dereferenced it so
a check here would be useless.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
fs/io_uring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 72bc378edebc..e9f339453ddb 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -3065,7 +3065,7 @@ static int io_sendmsg(struct io_kiocb *req, struct io_kiocb **nxt,
if (req->io)
return -EAGAIN;
if (io_alloc_async_ctx(req)) {
- if (kmsg && kmsg->iov != kmsg->fast_iov)
+ if (kmsg->iov != kmsg->fast_iov)
kfree(kmsg->iov);
return -ENOMEM;
}
@@ -3219,7 +3219,7 @@ static int io_recvmsg(struct io_kiocb *req, struct io_kiocb **nxt,
if (req->io)
return -EAGAIN;
if (io_alloc_async_ctx(req)) {
- if (kmsg && kmsg->iov != kmsg->fast_iov)
+ if (kmsg->iov != kmsg->fast_iov)
kfree(kmsg->iov);
return -ENOMEM;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring: remove unnecessary NULL checks
2020-02-17 14:39 [PATCH] io_uring: remove unnecessary NULL checks Dan Carpenter
@ 2020-02-18 12:31 ` Stefano Garzarella
2020-02-18 18:22 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2020-02-18 12:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jens Axboe, Alexander Viro, io-uring, linux-fsdevel,
linux-kernel, kernel-janitors
On Mon, Feb 17, 2020 at 05:39:45PM +0300, Dan Carpenter wrote:
> The "kmsg" pointer can't be NULL and we have already dereferenced it so
> a check here would be useless.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/io_uring.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 72bc378edebc..e9f339453ddb 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -3065,7 +3065,7 @@ static int io_sendmsg(struct io_kiocb *req, struct io_kiocb **nxt,
> if (req->io)
> return -EAGAIN;
> if (io_alloc_async_ctx(req)) {
> - if (kmsg && kmsg->iov != kmsg->fast_iov)
> + if (kmsg->iov != kmsg->fast_iov)
> kfree(kmsg->iov);
> return -ENOMEM;
> }
> @@ -3219,7 +3219,7 @@ static int io_recvmsg(struct io_kiocb *req, struct io_kiocb **nxt,
> if (req->io)
> return -EAGAIN;
> if (io_alloc_async_ctx(req)) {
> - if (kmsg && kmsg->iov != kmsg->fast_iov)
> + if (kmsg->iov != kmsg->fast_iov)
> kfree(kmsg->iov);
> return -ENOMEM;
> }
Make sense.
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring: remove unnecessary NULL checks
2020-02-17 14:39 [PATCH] io_uring: remove unnecessary NULL checks Dan Carpenter
2020-02-18 12:31 ` Stefano Garzarella
@ 2020-02-18 18:22 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-02-18 18:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alexander Viro, io-uring, linux-fsdevel, linux-kernel, kernel-janitors
On 2/17/20 7:39 AM, Dan Carpenter wrote:
> The "kmsg" pointer can't be NULL and we have already dereferenced it so
> a check here would be useless.
Applied, thanks Dan.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-18 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 14:39 [PATCH] io_uring: remove unnecessary NULL checks Dan Carpenter
2020-02-18 12:31 ` Stefano Garzarella
2020-02-18 18:22 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).