From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Fabien Parent <fparent@baylibre.com>
Cc: "fengping.yu" <fengping.yu@mediatek.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Marco Felsch <m.felsch@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
DTML <devicetree@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 2/2] drivers: input: keyboard: add mtk keypad driver
Date: Tue, 18 Feb 2020 17:51:48 +0200 [thread overview]
Message-ID: <20200218155148.GJ10400@smile.fi.intel.com> (raw)
In-Reply-To: <CAOwMV_w=Ad8gt1rftFw_EbtaZ2uCz=oWpm_P5YMHLNpok7Q09Q@mail.gmail.com>
On Tue, Feb 18, 2020 at 04:14:24PM +0100, Fabien Parent wrote:
> On Tue, Jan 14, 2020 at 1:39 PM fengping.yu <fengping.yu@mediatek.com> wrote:
...
> > +#define KP_STA 0x0000
> > +#define KP_MEM1 0x0004
> > +#define KP_MEM2 0x0008
> > +#define KP_MEM3 0x000c
> > +#define KP_MEM4 0x0010
> > +#define KP_MEM5 0x0014
> > +#define KP_DEBOUNCE 0x0018
> > +#define KP_SEL 0x0020
> > +#define KP_EN 0x0024
...
> > +#define KPD_NUM_MEMS 5
> > +#define KPD_MEM5_BITS 8
> > +#define KPD_NUM_KEYS 72 /* 4 * 16 + KPD_MEM5_BITS */
> > + kpd_get_keymap_state(keypad->base, new_state);
>
> kpd_get_keymap_state(keypad->base + KP_MEM1, new_state);
Why?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-02-18 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200114122738.103344-1-fengping.yu@mediatek.com>
[not found] ` <20200114122738.103344-3-fengping.yu@mediatek.com>
2020-01-14 16:36 ` [PATCH V3 2/2] drivers: input: keyboard: add mtk keypad driver Andy Shevchenko
2020-01-22 6:24 ` Dmitry Torokhov
2020-02-18 15:14 ` Fabien Parent
2020-02-18 15:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218155148.GJ10400@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=fparent@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).