From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Dan Murphy <dmurphy@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
andrew@lunn.ch, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: phy: dp83867: Add speed optimization feature
Date: Wed, 19 Feb 2020 00:06:05 +0000 [thread overview]
Message-ID: <20200219000604.GO25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <f5c42936-98a6-8221-a244-ed61840c9c81@ti.com>
On Tue, Feb 18, 2020 at 11:38:33AM -0600, Dan Murphy wrote:
> Russell
>
> On 2/18/20 11:33 AM, Russell King - ARM Linux admin wrote:
> > As I mentioned, the PHY on either end of the link can be the one
> > which decides to downshift, and the partner PHY has no idea that
> > a downshift has happened.
> >
> Exactly so we can only report that if the PHY on our end caused the
> downshift. If this PHY does not cause the downshift then the message will
> not be presented even though a downshift occurred. So what is the value in
> presenting this message?
I think we are in agreement over questioning the value of reporting
the downshift!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2020-02-19 0:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 18:13 [PATCH net-next v2] net: phy: dp83867: Add speed optimization feature Dan Murphy
2020-02-04 20:08 ` Heiner Kallweit
2020-02-04 20:30 ` Dan Murphy
2020-02-05 21:16 ` Heiner Kallweit
2020-02-05 21:51 ` Dan Murphy
2020-02-05 22:00 ` Florian Fainelli
2020-02-05 22:01 ` Dan Murphy
2020-02-14 18:32 ` Grygorii Strashko
2020-02-14 18:31 ` Dan Murphy
2020-02-18 14:07 ` Dan Murphy
2020-02-18 16:25 ` Russell King - ARM Linux admin
2020-02-18 16:36 ` Dan Murphy
2020-02-18 16:49 ` Russell King - ARM Linux admin
2020-02-18 17:12 ` Dan Murphy
2020-02-18 17:33 ` Russell King - ARM Linux admin
2020-02-18 17:38 ` Dan Murphy
2020-02-19 0:06 ` Russell King - ARM Linux admin [this message]
2020-02-06 22:13 ` Dan Murphy
2020-02-06 22:28 ` Heiner Kallweit
2020-02-06 22:36 ` Dan Murphy
2020-02-06 23:04 ` Heiner Kallweit
2020-02-06 23:23 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219000604.GO25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).