[PATCH 00/20] usb: remove useless cast for driver.name

[PATCH 00/20] usb: remove useless cast for driver.name

[Corentin Labbe]

This serie remove a useless (char*) cast for some xxx_driver.name.
pci_driver, device_driver, usb_composite_driver structures have a "name"
member which is const char * and all the driver patched assigned to it a
const char[] name, so the cast was bad and unnecessary.

Corentin Labbe (20):
  usb: gadget: legacy: gmidi: remove useless cast for driver.name
  usb: gadget: legacy: inode: remove useless cast for driver.name
  usb: gadget: udc: amd5536udc_pci: remove useless cast for driver.name
  usb: gadget: at91_udc: remove useless cast for driver.name
  usb: gadget: dummy_hcd: remove useless cast for driver.name
  usb: gadget: fotg210-udc: remove useless cast for driver.name
  usb: gadget: fusb300_udc: remove useless cast for driver.name
  usb: gadget: goku_udc: remove useless cast for driver.name
  usb: gadget: lpc32xx_udc: remove useless cast for driver.name
  usb: gadget: m66592-udc: remove useless cast for driver.name
  usb: gadget: net2280: remove useless cast for driver.name
  usb: gadget: omap_udc: remove useless cast for driver.name
  usb: gadget: r8a66597-udc: remove useless cast for driver.name
  usb: gadget: renesas_usb3: remove useless cast for driver.name
  usb: host: ehci-pci: remove useless cast for driver.name
  usb: host: ohci-pci: remove useless cast for driver.name
  usb: host: sl811-hcd: remove useless cast for driver.name
  usb: host: uhci-pci: remove useless cast for driver.name
  usb: host: xhci-pci: remove useless cast for driver.name
  usb: musb: core: remove useless cast for driver.name

 drivers/usb/gadget/legacy/gmidi.c       | 2 +-
 drivers/usb/gadget/legacy/inode.c       | 2 +-
 drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
 drivers/usb/gadget/udc/at91_udc.c       | 2 +-
 drivers/usb/gadget/udc/dummy_hcd.c      | 4 ++--
 drivers/usb/gadget/udc/fotg210-udc.c    | 2 +-
 drivers/usb/gadget/udc/fusb300_udc.c    | 2 +-
 drivers/usb/gadget/udc/goku_udc.c       | 2 +-
 drivers/usb/gadget/udc/lpc32xx_udc.c    | 2 +-
 drivers/usb/gadget/udc/m66592-udc.c     | 2 +-
 drivers/usb/gadget/udc/net2280.c        | 2 +-
 drivers/usb/gadget/udc/omap_udc.c       | 2 +-
 drivers/usb/gadget/udc/r8a66597-udc.c   | 2 +-
 drivers/usb/gadget/udc/renesas_usb3.c   | 2 +-
 drivers/usb/host/ehci-pci.c             | 2 +-
 drivers/usb/host/ohci-pci.c             | 2 +-
 drivers/usb/host/sl811-hcd.c            | 2 +-
 drivers/usb/host/uhci-pci.c             | 2 +-
 drivers/usb/host/xhci-pci.c             | 2 +-
 drivers/usb/musb/musb_core.c            | 2 +-
 20 files changed, 21 insertions(+), 21 deletions(-)

-- 
2.24.1

[PATCH 01/20] usb: gadget: legacy: gmidi: remove useless cast for driver.name

[Corentin Labbe]

usb_composite_driver name is const char pointer, so it not useful to cast
longname (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/legacy/gmidi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/legacy/gmidi.c b/drivers/usb/gadget/legacy/gmidi.c
index 9eea2d18f2bf..265c392810d7 100644
--- a/drivers/usb/gadget/legacy/gmidi.c
+++ b/drivers/usb/gadget/legacy/gmidi.c
@@ -174,7 +174,7 @@ static int midi_bind(struct usb_composite_dev *cdev)
 }
 
 static struct usb_composite_driver midi_driver = {
-	.name		= (char *) longname,
+	.name		= longname,
 	.dev		= &device_desc,
 	.strings	= dev_strings,
 	.max_speed	= USB_SPEED_HIGH,
-- 
2.24.1

[PATCH 02/20] usb: gadget: legacy: inode: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
shortname (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/legacy/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
index b47938dff1a2..e3dfc2180555 100644
--- a/drivers/usb/gadget/legacy/inode.c
+++ b/drivers/usb/gadget/legacy/inode.c
@@ -1736,7 +1736,7 @@ static struct usb_gadget_driver gadgetfs_driver = {
 	.suspend	= gadgetfs_suspend,
 
 	.driver	= {
-		.name		= (char *) shortname,
+		.name		= shortname,
 	},
 };
 
-- 
2.24.1

[PATCH 03/20] usb: gadget: udc: amd5536udc_pci: remove useless cast for driver.name

[Corentin Labbe]

pci_driver name is const char pointer, so it not useful to cast
name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/amd5536udc_pci.c b/drivers/usb/gadget/udc/amd5536udc_pci.c
index bfd1c9e80a1f..80685e4306f3 100644
--- a/drivers/usb/gadget/udc/amd5536udc_pci.c
+++ b/drivers/usb/gadget/udc/amd5536udc_pci.c
@@ -202,7 +202,7 @@ MODULE_DEVICE_TABLE(pci, pci_id);
 
 /* PCI functions */
 static struct pci_driver udc_pci_driver = {
-	.name =		(char *) name,
+	.name =		name,
 	.id_table =	pci_id,
 	.probe =	udc_pci_probe,
 	.remove =	udc_pci_remove,
-- 
2.24.1

[PATCH 04/20] usb: gadget: at91_udc: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/at91_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index 1b2b548c59a0..eede5cedacb4 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -2021,7 +2021,7 @@ static struct platform_driver at91_udc_driver = {
 	.suspend	= at91udc_suspend,
 	.resume		= at91udc_resume,
 	.driver		= {
-		.name	= (char *) driver_name,
+		.name	= driver_name,
 		.of_match_table	= at91_udc_dt_ids,
 	},
 };
-- 
2.24.1

[PATCH 05/20] usb: gadget: dummy_hcd: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/dummy_hcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 4c9d1e49d5ed..6e3e3ebf715f 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -1134,7 +1134,7 @@ static struct platform_driver dummy_udc_driver = {
 	.suspend	= dummy_udc_suspend,
 	.resume		= dummy_udc_resume,
 	.driver		= {
-		.name	= (char *) gadget_name,
+		.name	= gadget_name,
 	},
 };
 
@@ -2720,7 +2720,7 @@ static struct platform_driver dummy_hcd_driver = {
 	.suspend	= dummy_hcd_suspend,
 	.resume		= dummy_hcd_resume,
 	.driver		= {
-		.name	= (char *) driver_name,
+		.name	= driver_name,
 	},
 };
 
-- 
2.24.1

[PATCH 06/20] usb: gadget: fotg210-udc: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
udc_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/fotg210-udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c
index 21f3e6c4e4d6..d6ca50f01985 100644
--- a/drivers/usb/gadget/udc/fotg210-udc.c
+++ b/drivers/usb/gadget/udc/fotg210-udc.c
@@ -1199,7 +1199,7 @@ static int fotg210_udc_probe(struct platform_device *pdev)
 
 static struct platform_driver fotg210_driver = {
 	.driver		= {
-		.name =	(char *)udc_name,
+		.name =	udc_name,
 	},
 	.probe		= fotg210_udc_probe,
 	.remove		= fotg210_udc_remove,
-- 
2.24.1

[PATCH 07/20] usb: gadget: fusb300_udc: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
udc_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/fusb300_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c
index 00e3f66836a9..9af8b415f303 100644
--- a/drivers/usb/gadget/udc/fusb300_udc.c
+++ b/drivers/usb/gadget/udc/fusb300_udc.c
@@ -1507,7 +1507,7 @@ static int fusb300_probe(struct platform_device *pdev)
 static struct platform_driver fusb300_driver = {
 	.remove =	fusb300_remove,
 	.driver		= {
-		.name =	(char *) udc_name,
+		.name =	udc_name,
 	},
 };
 
-- 
2.24.1

[PATCH 08/20] usb: gadget: goku_udc: remove useless cast for driver.name

[Corentin Labbe]

pci_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/goku_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c
index 4a46f661d0e4..91dcb1995c27 100644
--- a/drivers/usb/gadget/udc/goku_udc.c
+++ b/drivers/usb/gadget/udc/goku_udc.c
@@ -1844,7 +1844,7 @@ static const struct pci_device_id pci_ids[] = { {
 MODULE_DEVICE_TABLE (pci, pci_ids);
 
 static struct pci_driver goku_pci_driver = {
-	.name =		(char *) driver_name,
+	.name =		driver_name,
 	.id_table =	pci_ids,
 
 	.probe =	goku_probe,
-- 
2.24.1

[PATCH 09/20] usb: gadget: lpc32xx_udc: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index d14b2bb3f67c..cb997b82c008 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -3267,7 +3267,7 @@ static struct platform_driver lpc32xx_udc_driver = {
 	.suspend	= lpc32xx_udc_suspend,
 	.resume		= lpc32xx_udc_resume,
 	.driver		= {
-		.name	= (char *) driver_name,
+		.name	= driver_name,
 		.of_match_table = of_match_ptr(lpc32xx_udc_of_match),
 	},
 };
-- 
2.24.1

[PATCH 10/20] usb: gadget: m66592-udc: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
udc_name (which is already const char).
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/m66592-udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c
index a8288df6aadf..75d16a8902e6 100644
--- a/drivers/usb/gadget/udc/m66592-udc.c
+++ b/drivers/usb/gadget/udc/m66592-udc.c
@@ -1691,7 +1691,7 @@ static int m66592_probe(struct platform_device *pdev)
 static struct platform_driver m66592_driver = {
 	.remove =	m66592_remove,
 	.driver		= {
-		.name =	(char *) udc_name,
+		.name =	udc_name,
 	},
 };
 
-- 
2.24.1

[PATCH 11/20] usb: gadget: net2280: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/net2280.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 1fd1b9186e46..4a815aab8f5b 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget/udc/net2280.c
@@ -3857,7 +3857,7 @@ MODULE_DEVICE_TABLE(pci, pci_ids);
 
 /* pci driver glue; this is a "new style" PCI driver module */
 static struct pci_driver net2280_pci_driver = {
-	.name =		(char *) driver_name,
+	.name =		driver_name,
 	.id_table =	pci_ids,
 
 	.probe =	net2280_probe,
-- 
2.24.1

[PATCH 12/20] usb: gadget: omap_udc: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/omap_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c
index bd12417996db..bf87c6c0d7f6 100644
--- a/drivers/usb/gadget/udc/omap_udc.c
+++ b/drivers/usb/gadget/udc/omap_udc.c
@@ -3001,7 +3001,7 @@ static struct platform_driver udc_driver = {
 	.suspend	= omap_udc_suspend,
 	.resume		= omap_udc_resume,
 	.driver		= {
-		.name	= (char *) driver_name,
+		.name	= driver_name,
 	},
 };
 
-- 
2.24.1

[PATCH 13/20] usb: gadget: r8a66597-udc: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
udc_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/r8a66597-udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c
index 582a16165ea9..537094b485bf 100644
--- a/drivers/usb/gadget/udc/r8a66597-udc.c
+++ b/drivers/usb/gadget/udc/r8a66597-udc.c
@@ -1968,7 +1968,7 @@ static int r8a66597_probe(struct platform_device *pdev)
 static struct platform_driver r8a66597_driver = {
 	.remove =	r8a66597_remove,
 	.driver		= {
-		.name =	(char *) udc_name,
+		.name =	udc_name,
 	},
 };
 
-- 
2.24.1

[PATCH 14/20] usb: gadget: renesas_usb3: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
udc_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index c5c3c14df67a..42ae99ad9b25 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2906,7 +2906,7 @@ static struct platform_driver renesas_usb3_driver = {
 	.probe		= renesas_usb3_probe,
 	.remove		= renesas_usb3_remove,
 	.driver		= {
-		.name =	(char *)udc_name,
+		.name =	udc_name,
 		.pm		= &renesas_usb3_pm_ops,
 		.of_match_table = of_match_ptr(usb3_of_match),
 	},
-- 
2.24.1

[PATCH 15/20] usb: host: ehci-pci: remove useless cast for driver.name

[Corentin Labbe]

pci_driver name is const char pointer, so it not useful to cast
hcd_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/host/ehci-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index b0882c13a1d1..1a48ab1bd3b2 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -384,7 +384,7 @@ MODULE_DEVICE_TABLE(pci, pci_ids);
 
 /* pci driver glue; this is a "new style" PCI driver module */
 static struct pci_driver ehci_pci_driver = {
-	.name =		(char *) hcd_name,
+	.name =		hcd_name,
 	.id_table =	pci_ids,
 
 	.probe =	ehci_pci_probe,
-- 
2.24.1

[PATCH 16/20] usb: host: ohci-pci: remove useless cast for driver.name

[Corentin Labbe]

pci_driver name is const char pointer, so it not useful to cast
hcd_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/host/ohci-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c
index f4e13a3fddee..22117a6aeb4a 100644
--- a/drivers/usb/host/ohci-pci.c
+++ b/drivers/usb/host/ohci-pci.c
@@ -288,7 +288,7 @@ MODULE_DEVICE_TABLE (pci, pci_ids);
 
 /* pci driver glue; this is a "new style" PCI driver module */
 static struct pci_driver ohci_pci_driver = {
-	.name =		(char *) hcd_name,
+	.name =		hcd_name,
 	.id_table =	pci_ids,
 
 	.probe =	usb_hcd_pci_probe,
-- 
2.24.1

[PATCH 17/20] usb: host: sl811-hcd: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
hcd_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/host/sl811-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c
index 72a34a1eb618..adaf4063690a 100644
--- a/drivers/usb/host/sl811-hcd.c
+++ b/drivers/usb/host/sl811-hcd.c
@@ -1792,7 +1792,7 @@ struct platform_driver sl811h_driver = {
 	.suspend =	sl811h_suspend,
 	.resume =	sl811h_resume,
 	.driver = {
-		.name =	(char *) hcd_name,
+		.name =	hcd_name,
 	},
 };
 EXPORT_SYMBOL(sl811h_driver);
-- 
2.24.1

[PATCH 18/20] usb: host: uhci-pci: remove useless cast for driver.name

[Corentin Labbe]

pci_driver name is const char pointer, so it not useful to cast
hcd_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/host/uhci-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/uhci-pci.c b/drivers/usb/host/uhci-pci.c
index 0fa3d72bae26..957c87efc746 100644
--- a/drivers/usb/host/uhci-pci.c
+++ b/drivers/usb/host/uhci-pci.c
@@ -294,7 +294,7 @@ static const struct pci_device_id uhci_pci_ids[] = { {
 MODULE_DEVICE_TABLE(pci, uhci_pci_ids);
 
 static struct pci_driver uhci_pci_driver = {
-	.name =		(char *)hcd_name,
+	.name =		hcd_name,
 	.id_table =	uhci_pci_ids,
 
 	.probe =	usb_hcd_pci_probe,
-- 
2.24.1

[PATCH 19/20] usb: host: xhci-pci: remove useless cast for driver.name

[Corentin Labbe]

pci_driver name is const char pointer, so it not useful to cast
hcd_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/host/xhci-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 5e9b537df631..0715a2e75413 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -549,7 +549,7 @@ MODULE_DEVICE_TABLE(pci, pci_ids);
 
 /* pci driver glue; this is a "new style" PCI driver module */
 static struct pci_driver xhci_pci_driver = {
-	.name =		(char *) hcd_name,
+	.name =		hcd_name,
 	.id_table =	pci_ids,
 
 	.probe =	xhci_pci_probe,
-- 
2.24.1

[PATCH 20/20] usb: musb: core: remove useless cast for driver.name

[Corentin Labbe]

device_driver name is const char pointer, so it not useful to cast
xx_driver_name (which is already const char).

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/usb/musb/musb_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index f616fb489542..d590110539ab 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2945,7 +2945,7 @@ static const struct dev_pm_ops musb_dev_pm_ops = {
 
 static struct platform_driver musb_driver = {
 	.driver = {
-		.name		= (char *)musb_driver_name,
+		.name		= musb_driver_name,
 		.bus		= &platform_bus_type,
 		.pm		= MUSB_DEV_PM_OPS,
 		.dev_groups	= musb_groups,
-- 
2.24.1

Re: [PATCH 04/20] usb: gadget: at91_udc: remove useless cast for driver.name

[Alexandre Belloni]

On 18/02/2020 19:32:47+0000, Corentin Labbe wrote:
> device_driver name is const char pointer, so it not useful to cast
> driver_name (which is already const char).
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/usb/gadget/udc/at91_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index 1b2b548c59a0..eede5cedacb4 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -2021,7 +2021,7 @@ static struct platform_driver at91_udc_driver = {
>  	.suspend	= at91udc_suspend,
>  	.resume		= at91udc_resume,
>  	.driver		= {
> -		.name	= (char *) driver_name,
> +		.name	= driver_name,
>  		.of_match_table	= at91_udc_dt_ids,
>  	},
>  };
> -- 
> 2.24.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 09/20] usb: gadget: lpc32xx_udc: remove useless cast for driver.name

[Alexandre Belloni]

On 18/02/2020 19:32:52+0000, Corentin Labbe wrote:
> device_driver name is const char pointer, so it not useful to cast
> driver_name (which is already const char).
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
> index d14b2bb3f67c..cb997b82c008 100644
> --- a/drivers/usb/gadget/udc/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
> @@ -3267,7 +3267,7 @@ static struct platform_driver lpc32xx_udc_driver = {
>  	.suspend	= lpc32xx_udc_suspend,
>  	.resume		= lpc32xx_udc_resume,
>  	.driver		= {
> -		.name	= (char *) driver_name,
> +		.name	= driver_name,
>  		.of_match_table = of_match_ptr(lpc32xx_udc_of_match),
>  	},
>  };
> -- 
> 2.24.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

RE: [PATCH 14/20] usb: gadget: renesas_usb3: remove useless cast for driver.name

[Yoshihiro Shimoda]

Hi,

> From: Corentin Labbe, Sent: Wednesday, February 19, 2020 4:33 AM
> 
> device_driver name is const char pointer, so it not useful to cast
> udc_name (which is already const char).
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

RE: [PATCH 13/20] usb: gadget: r8a66597-udc: remove useless cast for driver.name

[Yoshihiro Shimoda]

Hi,

> From: Corentin Labbe, Sent: Wednesday, February 19, 2020 4:33 AM
> 
> device_driver name is const char pointer, so it not useful to cast
> udc_name (which is already const char).
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

Re: [PATCH 00/20] usb: remove useless cast for driver.name

[Johan Hovold]

On Tue, Feb 18, 2020 at 07:32:43PM +0000, Corentin Labbe wrote:
> This serie remove a useless (char*) cast for some xxx_driver.name.
> pci_driver, device_driver, usb_composite_driver structures have a "name"
> member which is const char * and all the driver patched assigned to it a
> const char[] name, so the cast was bad and unnecessary.
> 
> Corentin Labbe (20):
>   usb: gadget: legacy: gmidi: remove useless cast for driver.name
>   usb: gadget: legacy: inode: remove useless cast for driver.name
>   usb: gadget: udc: amd5536udc_pci: remove useless cast for driver.name
>   usb: gadget: at91_udc: remove useless cast for driver.name
>   usb: gadget: dummy_hcd: remove useless cast for driver.name
>   usb: gadget: fotg210-udc: remove useless cast for driver.name
>   usb: gadget: fusb300_udc: remove useless cast for driver.name
>   usb: gadget: goku_udc: remove useless cast for driver.name
>   usb: gadget: lpc32xx_udc: remove useless cast for driver.name
>   usb: gadget: m66592-udc: remove useless cast for driver.name
>   usb: gadget: net2280: remove useless cast for driver.name
>   usb: gadget: omap_udc: remove useless cast for driver.name
>   usb: gadget: r8a66597-udc: remove useless cast for driver.name
>   usb: gadget: renesas_usb3: remove useless cast for driver.name
>   usb: host: ehci-pci: remove useless cast for driver.name
>   usb: host: ohci-pci: remove useless cast for driver.name
>   usb: host: sl811-hcd: remove useless cast for driver.name
>   usb: host: uhci-pci: remove useless cast for driver.name
>   usb: host: xhci-pci: remove useless cast for driver.name
>   usb: musb: core: remove useless cast for driver.name

Please do trivial conversions like this one in one patch per subsystem
(e.g. all of USB) instead of 20 one-line patches.

You may also want to refer to commit 8d790d740858 ("[PATCH] make
driver's name be const char *") for the historical background for this
in the commit message.

>  drivers/usb/gadget/legacy/gmidi.c       | 2 +-
>  drivers/usb/gadget/legacy/inode.c       | 2 +-
>  drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
>  drivers/usb/gadget/udc/at91_udc.c       | 2 +-
>  drivers/usb/gadget/udc/dummy_hcd.c      | 4 ++--
>  drivers/usb/gadget/udc/fotg210-udc.c    | 2 +-
>  drivers/usb/gadget/udc/fusb300_udc.c    | 2 +-
>  drivers/usb/gadget/udc/goku_udc.c       | 2 +-
>  drivers/usb/gadget/udc/lpc32xx_udc.c    | 2 +-
>  drivers/usb/gadget/udc/m66592-udc.c     | 2 +-
>  drivers/usb/gadget/udc/net2280.c        | 2 +-
>  drivers/usb/gadget/udc/omap_udc.c       | 2 +-
>  drivers/usb/gadget/udc/r8a66597-udc.c   | 2 +-
>  drivers/usb/gadget/udc/renesas_usb3.c   | 2 +-
>  drivers/usb/host/ehci-pci.c             | 2 +-
>  drivers/usb/host/ohci-pci.c             | 2 +-
>  drivers/usb/host/sl811-hcd.c            | 2 +-
>  drivers/usb/host/uhci-pci.c             | 2 +-
>  drivers/usb/host/xhci-pci.c             | 2 +-
>  drivers/usb/musb/musb_core.c            | 2 +-
>  20 files changed, 21 insertions(+), 21 deletions(-)

Thanks,
Johan