linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf stat: Align the output for interval aggregation mode
@ 2020-02-18  7:16 Jin Yao
  2020-02-20 10:53 ` Jiri Olsa
  2020-04-04  8:42 ` [tip: perf/urgent] " tip-bot2 for Jin Yao
  0 siblings, 2 replies; 4+ messages in thread
From: Jin Yao @ 2020-02-18  7:16 UTC (permalink / raw)
  To: acme, jolsa, peterz, mingo, alexander.shishkin
  Cc: Linux-kernel, ak, kan.liang, yao.jin, Jin Yao

There is a slight misalignment in -A -I output.

For example,

 perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000

 #           time CPU                    counts unit events
      1.000440863 CPU0               1,068,388      cpu/event=cpu-cycles/
      1.000440863 CPU1                 875,954      cpu/event=cpu-cycles/
      1.000440863 CPU2               3,072,538      cpu/event=cpu-cycles/
      1.000440863 CPU3               4,026,870      cpu/event=cpu-cycles/
      1.000440863 CPU4               5,919,630      cpu/event=cpu-cycles/
      1.000440863 CPU5               2,714,260      cpu/event=cpu-cycles/
      1.000440863 CPU6               2,219,240      cpu/event=cpu-cycles/
      1.000440863 CPU7               1,299,232      cpu/event=cpu-cycles/

The value of counts is not aligned with the column "counts" and
the event name is not aligned with the column "events".

With this patch, the output is,

 perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000

 #           time CPU                    counts unit events
      1.000423009 CPU0                  997,421      cpu/event=cpu-cycles/
      1.000423009 CPU1                1,422,042      cpu/event=cpu-cycles/
      1.000423009 CPU2                  484,651      cpu/event=cpu-cycles/
      1.000423009 CPU3                  525,791      cpu/event=cpu-cycles/
      1.000423009 CPU4                1,370,100      cpu/event=cpu-cycles/
      1.000423009 CPU5                  442,072      cpu/event=cpu-cycles/
      1.000423009 CPU6                  205,643      cpu/event=cpu-cycles/
      1.000423009 CPU7                1,302,250      cpu/event=cpu-cycles/

Now output is aligned.

Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
---
 tools/perf/util/stat-display.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index bc31fccc0057..95b29c9cba36 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -114,11 +114,11 @@ static void aggr_printout(struct perf_stat_config *config,
 			fprintf(config->output, "S%d-D%d-C%*d%s",
 				cpu_map__id_to_socket(id),
 				cpu_map__id_to_die(id),
-				config->csv_output ? 0 : -5,
+				config->csv_output ? 0 : -3,
 				cpu_map__id_to_cpu(id), config->csv_sep);
 		} else {
-			fprintf(config->output, "CPU%*d%s ",
-				config->csv_output ? 0 : -5,
+			fprintf(config->output, "CPU%*d%s",
+				config->csv_output ? 0 : -7,
 				evsel__cpus(evsel)->map[id],
 				config->csv_sep);
 		}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] perf stat: Align the output for interval aggregation mode
  2020-02-18  7:16 [PATCH] perf stat: Align the output for interval aggregation mode Jin Yao
@ 2020-02-20 10:53 ` Jiri Olsa
  2020-03-18 19:00   ` Arnaldo Carvalho de Melo
  2020-04-04  8:42 ` [tip: perf/urgent] " tip-bot2 for Jin Yao
  1 sibling, 1 reply; 4+ messages in thread
From: Jiri Olsa @ 2020-02-20 10:53 UTC (permalink / raw)
  To: Jin Yao
  Cc: acme, jolsa, peterz, mingo, alexander.shishkin, Linux-kernel, ak,
	kan.liang, yao.jin

On Tue, Feb 18, 2020 at 03:16:14PM +0800, Jin Yao wrote:
> There is a slight misalignment in -A -I output.
> 
> For example,
> 
>  perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> 
>  #           time CPU                    counts unit events
>       1.000440863 CPU0               1,068,388      cpu/event=cpu-cycles/
>       1.000440863 CPU1                 875,954      cpu/event=cpu-cycles/
>       1.000440863 CPU2               3,072,538      cpu/event=cpu-cycles/
>       1.000440863 CPU3               4,026,870      cpu/event=cpu-cycles/
>       1.000440863 CPU4               5,919,630      cpu/event=cpu-cycles/
>       1.000440863 CPU5               2,714,260      cpu/event=cpu-cycles/
>       1.000440863 CPU6               2,219,240      cpu/event=cpu-cycles/
>       1.000440863 CPU7               1,299,232      cpu/event=cpu-cycles/
> 
> The value of counts is not aligned with the column "counts" and
> the event name is not aligned with the column "events".
> 
> With this patch, the output is,
> 
>  perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> 
>  #           time CPU                    counts unit events
>       1.000423009 CPU0                  997,421      cpu/event=cpu-cycles/
>       1.000423009 CPU1                1,422,042      cpu/event=cpu-cycles/
>       1.000423009 CPU2                  484,651      cpu/event=cpu-cycles/
>       1.000423009 CPU3                  525,791      cpu/event=cpu-cycles/
>       1.000423009 CPU4                1,370,100      cpu/event=cpu-cycles/
>       1.000423009 CPU5                  442,072      cpu/event=cpu-cycles/
>       1.000423009 CPU6                  205,643      cpu/event=cpu-cycles/
>       1.000423009 CPU7                1,302,250      cpu/event=cpu-cycles/
> 
> Now output is aligned.
> 
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
>  tools/perf/util/stat-display.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index bc31fccc0057..95b29c9cba36 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -114,11 +114,11 @@ static void aggr_printout(struct perf_stat_config *config,
>  			fprintf(config->output, "S%d-D%d-C%*d%s",
>  				cpu_map__id_to_socket(id),
>  				cpu_map__id_to_die(id),
> -				config->csv_output ? 0 : -5,
> +				config->csv_output ? 0 : -3,
>  				cpu_map__id_to_cpu(id), config->csv_sep);
>  		} else {
> -			fprintf(config->output, "CPU%*d%s ",
> -				config->csv_output ? 0 : -5,
> +			fprintf(config->output, "CPU%*d%s",
> +				config->csv_output ? 0 : -7,
>  				evsel__cpus(evsel)->map[id],
>  				config->csv_sep);
>  		}
> -- 
> 2.17.1
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] perf stat: Align the output for interval aggregation mode
  2020-02-20 10:53 ` Jiri Olsa
@ 2020-03-18 19:00   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-03-18 19:00 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Jin Yao, jolsa, peterz, mingo, alexander.shishkin, Linux-kernel,
	ak, kan.liang, yao.jin

Em Thu, Feb 20, 2020 at 11:53:55AM +0100, Jiri Olsa escreveu:
> On Tue, Feb 18, 2020 at 03:16:14PM +0800, Jin Yao wrote:
> > There is a slight misalignment in -A -I output.
> > 
> > For example,
> > 
> >  perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> > 
> >  #           time CPU                    counts unit events
> >       1.000440863 CPU0               1,068,388      cpu/event=cpu-cycles/
> >       1.000440863 CPU1                 875,954      cpu/event=cpu-cycles/
> >       1.000440863 CPU2               3,072,538      cpu/event=cpu-cycles/
> >       1.000440863 CPU3               4,026,870      cpu/event=cpu-cycles/
> >       1.000440863 CPU4               5,919,630      cpu/event=cpu-cycles/
> >       1.000440863 CPU5               2,714,260      cpu/event=cpu-cycles/
> >       1.000440863 CPU6               2,219,240      cpu/event=cpu-cycles/
> >       1.000440863 CPU7               1,299,232      cpu/event=cpu-cycles/
> > 
> > The value of counts is not aligned with the column "counts" and
> > the event name is not aligned with the column "events".
> > 
> > With this patch, the output is,
> > 
> >  perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> > 
> >  #           time CPU                    counts unit events
> >       1.000423009 CPU0                  997,421      cpu/event=cpu-cycles/
> >       1.000423009 CPU1                1,422,042      cpu/event=cpu-cycles/
> >       1.000423009 CPU2                  484,651      cpu/event=cpu-cycles/
> >       1.000423009 CPU3                  525,791      cpu/event=cpu-cycles/
> >       1.000423009 CPU4                1,370,100      cpu/event=cpu-cycles/
> >       1.000423009 CPU5                  442,072      cpu/event=cpu-cycles/
> >       1.000423009 CPU6                  205,643      cpu/event=cpu-cycles/
> >       1.000423009 CPU7                1,302,250      cpu/event=cpu-cycles/
> > 
> > Now output is aligned.
> > 
> > Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks, tested and applied.

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip: perf/urgent] perf stat: Align the output for interval aggregation mode
  2020-02-18  7:16 [PATCH] perf stat: Align the output for interval aggregation mode Jin Yao
  2020-02-20 10:53 ` Jiri Olsa
@ 2020-04-04  8:42 ` tip-bot2 for Jin Yao
  1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Jin Yao @ 2020-04-04  8:42 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Jin Yao, Jiri Olsa, Arnaldo Carvalho de Melo, Alexander Shishkin,
	Andi Kleen, Kan Liang, Peter Zijlstra, x86, LKML

The following commit has been merged into the perf/urgent branch of tip:

Commit-ID:     d13e9e413e5b470c4364bbbce559383081201811
Gitweb:        https://git.kernel.org/tip/d13e9e413e5b470c4364bbbce559383081201811
Author:        Jin Yao <yao.jin@linux.intel.com>
AuthorDate:    Tue, 18 Feb 2020 15:16:14 +08:00
Committer:     Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Tue, 24 Mar 2020 09:37:27 -03:00

perf stat: Align the output for interval aggregation mode

There is a slight misalignment in -A -I output.

For example:

 # perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000

 #           time CPU                    counts unit events
      1.000440863 CPU0               1,068,388      cpu/event=cpu-cycles/
      1.000440863 CPU1                 875,954      cpu/event=cpu-cycles/
      1.000440863 CPU2               3,072,538      cpu/event=cpu-cycles/
      1.000440863 CPU3               4,026,870      cpu/event=cpu-cycles/
      1.000440863 CPU4               5,919,630      cpu/event=cpu-cycles/
      1.000440863 CPU5               2,714,260      cpu/event=cpu-cycles/
      1.000440863 CPU6               2,219,240      cpu/event=cpu-cycles/
      1.000440863 CPU7               1,299,232      cpu/event=cpu-cycles/

The value of counts is not aligned with the column "counts" and
the event name is not aligned with the column "events".

With this patch, the output is,

 # perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000

 #           time CPU                    counts unit events
      1.000423009 CPU0                  997,421      cpu/event=cpu-cycles/
      1.000423009 CPU1                1,422,042      cpu/event=cpu-cycles/
      1.000423009 CPU2                  484,651      cpu/event=cpu-cycles/
      1.000423009 CPU3                  525,791      cpu/event=cpu-cycles/
      1.000423009 CPU4                1,370,100      cpu/event=cpu-cycles/
      1.000423009 CPU5                  442,072      cpu/event=cpu-cycles/
      1.000423009 CPU6                  205,643      cpu/event=cpu-cycles/
      1.000423009 CPU7                1,302,250      cpu/event=cpu-cycles/

Now output is aligned.

Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20200218071614.25736-1-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/stat-display.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 76c6052..9e757d1 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -115,11 +115,11 @@ static void aggr_printout(struct perf_stat_config *config,
 			fprintf(config->output, "S%d-D%d-C%*d%s",
 				cpu_map__id_to_socket(id),
 				cpu_map__id_to_die(id),
-				config->csv_output ? 0 : -5,
+				config->csv_output ? 0 : -3,
 				cpu_map__id_to_cpu(id), config->csv_sep);
 		} else {
-			fprintf(config->output, "CPU%*d%s ",
-				config->csv_output ? 0 : -5,
+			fprintf(config->output, "CPU%*d%s",
+				config->csv_output ? 0 : -7,
 				evsel__cpus(evsel)->map[id],
 				config->csv_sep);
 		}

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-04  8:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18  7:16 [PATCH] perf stat: Align the output for interval aggregation mode Jin Yao
2020-02-20 10:53 ` Jiri Olsa
2020-03-18 19:00   ` Arnaldo Carvalho de Melo
2020-04-04  8:42 ` [tip: perf/urgent] " tip-bot2 for Jin Yao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).