* [PATCH] power/supply: ingenic-battery: Don't print error on -EPROBE_DEFER
@ 2020-02-21 0:58 Paul Cercueil
2020-02-27 21:00 ` Artur Rojek
0 siblings, 1 reply; 2+ messages in thread
From: Paul Cercueil @ 2020-02-21 0:58 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: od, linux-pm, linux-kernel, Paul Cercueil
Don't print an error message if devm_power_supply_register() returns
-EPROBE_DEFER, since the driver will simply re-probe later.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/power/supply/ingenic-battery.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/ingenic-battery.c b/drivers/power/supply/ingenic-battery.c
index 2748715c4c75..dd3d93dfe3eb 100644
--- a/drivers/power/supply/ingenic-battery.c
+++ b/drivers/power/supply/ingenic-battery.c
@@ -148,7 +148,8 @@ static int ingenic_battery_probe(struct platform_device *pdev)
bat->battery = devm_power_supply_register(dev, desc, &psy_cfg);
if (IS_ERR(bat->battery)) {
- dev_err(dev, "Unable to register battery\n");
+ if (PTR_ERR(bat->battery) != -EPROBE_DEFER)
+ dev_err(dev, "Unable to register battery\n");
return PTR_ERR(bat->battery);
}
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power/supply: ingenic-battery: Don't print error on -EPROBE_DEFER
2020-02-21 0:58 [PATCH] power/supply: ingenic-battery: Don't print error on -EPROBE_DEFER Paul Cercueil
@ 2020-02-27 21:00 ` Artur Rojek
0 siblings, 0 replies; 2+ messages in thread
From: Artur Rojek @ 2020-02-27 21:00 UTC (permalink / raw)
To: Paul Cercueil; +Cc: Sebastian Reichel, od, linux-pm, linux-kernel
On 2020-02-21 01:58, Paul Cercueil wrote:
> Don't print an error message if devm_power_supply_register() returns
> -EPROBE_DEFER, since the driver will simply re-probe later.
Hi Paul.
This looks alright.
Acked-by: Artur Rojek <contact@artur-rojek.eu>
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/power/supply/ingenic-battery.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/ingenic-battery.c
> b/drivers/power/supply/ingenic-battery.c
> index 2748715c4c75..dd3d93dfe3eb 100644
> --- a/drivers/power/supply/ingenic-battery.c
> +++ b/drivers/power/supply/ingenic-battery.c
> @@ -148,7 +148,8 @@ static int ingenic_battery_probe(struct
> platform_device *pdev)
>
> bat->battery = devm_power_supply_register(dev, desc, &psy_cfg);
> if (IS_ERR(bat->battery)) {
> - dev_err(dev, "Unable to register battery\n");
> + if (PTR_ERR(bat->battery) != -EPROBE_DEFER)
> + dev_err(dev, "Unable to register battery\n");
> return PTR_ERR(bat->battery);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-27 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 0:58 [PATCH] power/supply: ingenic-battery: Don't print error on -EPROBE_DEFER Paul Cercueil
2020-02-27 21:00 ` Artur Rojek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).