* [PATCH] iwlegacy: Remove unneeded variable ret
@ 2020-02-21 10:43 Xu Wang
2020-02-22 13:24 ` Stanislaw Gruszka
2020-03-12 13:41 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Xu Wang @ 2020-02-21 10:43 UTC (permalink / raw)
To: stf_xl, kvalo, davem; +Cc: linux-wireless, linux-kernel
Remove unneeded variable ret used to store return value.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/net/wireless/intel/iwlegacy/3945-mac.c | 4 +---
drivers/net/wireless/intel/iwlegacy/4965.c | 3 +--
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
index 206b43b9dff8..9167c3d2711d 100644
--- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
@@ -228,9 +228,7 @@ il3945_set_dynamic_key(struct il_priv *il, struct ieee80211_key_conf *keyconf,
static int
il3945_remove_static_key(struct il_priv *il)
{
- int ret = -EOPNOTSUPP;
-
- return ret;
+ return -EOPNOTSUPP;
}
static int
diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c
index 34d0579132ce..fc8fa5818de7 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965.c
@@ -416,7 +416,6 @@ il4965_set_ucode_ptrs(struct il_priv *il)
{
dma_addr_t pinst;
dma_addr_t pdata;
- int ret = 0;
/* bits 35:4 for 4965 */
pinst = il->ucode_code.p_addr >> 4;
@@ -433,7 +432,7 @@ il4965_set_ucode_ptrs(struct il_priv *il)
il->ucode_code.len | BSM_DRAM_INST_LOAD);
D_INFO("Runtime uCode pointers are set.\n");
- return ret;
+ return 0;
}
/**
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: Remove unneeded variable ret
2020-02-21 10:43 [PATCH] iwlegacy: Remove unneeded variable ret Xu Wang
@ 2020-02-22 13:24 ` Stanislaw Gruszka
2020-03-12 13:41 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2020-02-22 13:24 UTC (permalink / raw)
To: Xu Wang; +Cc: kvalo, davem, linux-wireless, linux-kernel
On Fri, Feb 21, 2020 at 06:43:03PM +0800, Xu Wang wrote:
> Remove unneeded variable ret used to store return value.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: Remove unneeded variable ret
2020-02-21 10:43 [PATCH] iwlegacy: Remove unneeded variable ret Xu Wang
2020-02-22 13:24 ` Stanislaw Gruszka
@ 2020-03-12 13:41 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-03-12 13:41 UTC (permalink / raw)
To: Xu Wang; +Cc: stf_xl, davem, linux-wireless, linux-kernel
Xu Wang <vulab@iscas.ac.cn> wrote:
> Remove unneeded variable ret used to store return value.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Patch applied to wireless-drivers-next.git, thanks.
310443268b29 iwlegacy: Remove unneeded variable ret
--
https://patchwork.kernel.org/patch/11396229/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-12 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 10:43 [PATCH] iwlegacy: Remove unneeded variable ret Xu Wang
2020-02-22 13:24 ` Stanislaw Gruszka
2020-03-12 13:41 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).