* linux-next: build failure after merge of the hwmon-fixes tree
@ 2020-02-25 21:12 Stephen Rothwell
2020-02-25 21:25 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-02-25 21:12 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Vadim Pasternak
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
Hi all,
After merging the hwmon-fixes tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/pmbus/xdpe12284.c: In function 'xdpe122_read_word_data':
drivers/hwmon/pmbus/xdpe12284.c:33:9: error: too many arguments to function 'pmbus_read_word_data'
33 | ret = pmbus_read_word_data(client, page, phase, reg);
| ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/hwmon/pmbus/xdpe12284.c:13:
drivers/hwmon/pmbus/pmbus.h:458:5: note: declared here
458 | int pmbus_read_word_data(struct i2c_client *client, int page, u8 reg);
| ^~~~~~~~~~~~~~~~~~~~
drivers/hwmon/pmbus/xdpe12284.c: At top level:
drivers/hwmon/pmbus/xdpe12284.c:127:20: error: initialization of 'int (*)(struct i2c_client *, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int, int)' [-Werror=incompatible-pointer-types]
127 | .read_word_data = xdpe122_read_word_data,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/hwmon/pmbus/xdpe12284.c:127:20: note: (near initialization for 'xdpe122_info.read_word_data')
Caused by commit
47555027eae2 ("hwmon: (pmbus/xdpe12284) Add callback for vout limits conversion")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the hwmon-fixes tree
2020-02-25 21:12 linux-next: build failure after merge of the hwmon-fixes tree Stephen Rothwell
@ 2020-02-25 21:25 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-02-25 21:25 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Vadim Pasternak
On Wed, Feb 26, 2020 at 08:12:28AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-fixes tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/pmbus/xdpe12284.c: In function 'xdpe122_read_word_data':
> drivers/hwmon/pmbus/xdpe12284.c:33:9: error: too many arguments to function 'pmbus_read_word_data'
> 33 | ret = pmbus_read_word_data(client, page, phase, reg);
> | ^~~~~~~~~~~~~~~~~~~~
> In file included from drivers/hwmon/pmbus/xdpe12284.c:13:
> drivers/hwmon/pmbus/pmbus.h:458:5: note: declared here
> 458 | int pmbus_read_word_data(struct i2c_client *client, int page, u8 reg);
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/hwmon/pmbus/xdpe12284.c: At top level:
> drivers/hwmon/pmbus/xdpe12284.c:127:20: error: initialization of 'int (*)(struct i2c_client *, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int, int)' [-Werror=incompatible-pointer-types]
> 127 | .read_word_data = xdpe122_read_word_data,
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/hwmon/pmbus/xdpe12284.c:127:20: note: (near initialization for 'xdpe122_info.read_word_data')
>
> Caused by commit
>
> 47555027eae2 ("hwmon: (pmbus/xdpe12284) Add callback for vout limits conversion")
>
> I have reverted that commit for today.
>
Bummer. My fault; sorry for that. Fixed up now.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the hwmon-fixes tree
2019-06-05 22:30 Stephen Rothwell
@ 2019-06-05 22:50 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2019-06-05 22:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Krzysztof Adamski, Alexander Sverdlin
On Thu, Jun 06, 2019 at 08:30:34AM +1000, Stephen Rothwell wrote:
> Hi Guenter,
>
> After merging the hwmon-fixes tree, today's linux-next build
> (x86_64 allmodconfig) failed like this:
>
> In file included from include/linux/notifier.h:14,
> from arch/x86/include/asm/uprobes.h:13,
> from include/linux/uprobes.h:49,
> from include/linux/mm_types.h:14,
> from include/linux/mmzone.h:21,
> from include/linux/gfp.h:6,
> from include/linux/xarray.h:14,
> from include/linux/radix-tree.h:18,
> from include/linux/fs.h:15,
> from include/linux/debugfs.h:15,
> from drivers/hwmon/pmbus/pmbus_core.c:9:
> drivers/hwmon/pmbus/pmbus_core.c: In function 'pmbus_set_samples':
> drivers/hwmon/pmbus/pmbus_core.c:1975:14: error: 'data' undeclared (first use in this function); did you mean '_data'?
> mutex_lock(&data->update_lock);
> ^~~~
> include/linux/mutex.h:166:44: note: in definition of macro 'mutex_lock'
> #define mutex_lock(lock) mutex_lock_nested(lock, 0)
> ^~~~
> drivers/hwmon/pmbus/pmbus_core.c:1975:14: note: each undeclared identifier is reported only once for each function it appears in
> mutex_lock(&data->update_lock);
> ^~~~
> include/linux/mutex.h:166:44: note: in definition of macro 'mutex_lock'
> #define mutex_lock(lock) mutex_lock_nested(lock, 0)
> ^~~~
>
> Caused by commit
>
> 8d719d6f3e97 ("hwmon: (pmbus/core) mutex_lock write in pmbus_set_samples")
>
Fixed. Thanks for the note, and sorry for the trouble.
Guenter
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: build failure after merge of the hwmon-fixes tree
@ 2019-06-05 22:30 Stephen Rothwell
2019-06-05 22:50 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2019-06-05 22:30 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Krzysztof Adamski, Alexander Sverdlin
[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]
Hi Guenter,
After merging the hwmon-fixes tree, today's linux-next build
(x86_64 allmodconfig) failed like this:
In file included from include/linux/notifier.h:14,
from arch/x86/include/asm/uprobes.h:13,
from include/linux/uprobes.h:49,
from include/linux/mm_types.h:14,
from include/linux/mmzone.h:21,
from include/linux/gfp.h:6,
from include/linux/xarray.h:14,
from include/linux/radix-tree.h:18,
from include/linux/fs.h:15,
from include/linux/debugfs.h:15,
from drivers/hwmon/pmbus/pmbus_core.c:9:
drivers/hwmon/pmbus/pmbus_core.c: In function 'pmbus_set_samples':
drivers/hwmon/pmbus/pmbus_core.c:1975:14: error: 'data' undeclared (first use in this function); did you mean '_data'?
mutex_lock(&data->update_lock);
^~~~
include/linux/mutex.h:166:44: note: in definition of macro 'mutex_lock'
#define mutex_lock(lock) mutex_lock_nested(lock, 0)
^~~~
drivers/hwmon/pmbus/pmbus_core.c:1975:14: note: each undeclared identifier is reported only once for each function it appears in
mutex_lock(&data->update_lock);
^~~~
include/linux/mutex.h:166:44: note: in definition of macro 'mutex_lock'
#define mutex_lock(lock) mutex_lock_nested(lock, 0)
^~~~
Caused by commit
8d719d6f3e97 ("hwmon: (pmbus/core) mutex_lock write in pmbus_set_samples")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-25 21:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25 21:12 linux-next: build failure after merge of the hwmon-fixes tree Stephen Rothwell
2020-02-25 21:25 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2019-06-05 22:30 Stephen Rothwell
2019-06-05 22:50 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).