* [PATCH net] net: phy: mscc: fix firmware paths
@ 2020-02-26 15:26 Antoine Tenart
2020-02-26 15:45 ` Andrew Lunn
2020-02-27 4:53 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Antoine Tenart @ 2020-02-26 15:26 UTC (permalink / raw)
To: davem, andrew, f.fainelli, hkallweit1
Cc: Antoine Tenart, netdev, linux-kernel, foss
The firmware paths for the VSC8584 PHYs not not contain the leading
'microchip/' directory, as used in linux-firmware, resulting in an
error when probing the driver. This patch fixes it.
Fixes: a5afc1678044 ("net: phy: mscc: add support for VSC8584 PHY")
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
---
drivers/net/phy/mscc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c
index 937ac7da2789..f686f40f6bdc 100644
--- a/drivers/net/phy/mscc.c
+++ b/drivers/net/phy/mscc.c
@@ -345,11 +345,11 @@ enum macsec_bank {
BIT(VSC8531_FORCE_LED_OFF) | \
BIT(VSC8531_FORCE_LED_ON))
-#define MSCC_VSC8584_REVB_INT8051_FW "mscc_vsc8584_revb_int8051_fb48.bin"
+#define MSCC_VSC8584_REVB_INT8051_FW "microchip/mscc_vsc8584_revb_int8051_fb48.bin"
#define MSCC_VSC8584_REVB_INT8051_FW_START_ADDR 0xe800
#define MSCC_VSC8584_REVB_INT8051_FW_CRC 0xfb48
-#define MSCC_VSC8574_REVB_INT8051_FW "mscc_vsc8574_revb_int8051_29e8.bin"
+#define MSCC_VSC8574_REVB_INT8051_FW "microchip/mscc_vsc8574_revb_int8051_29e8.bin"
#define MSCC_VSC8574_REVB_INT8051_FW_START_ADDR 0x4000
#define MSCC_VSC8574_REVB_INT8051_FW_CRC 0x29e8
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: mscc: fix firmware paths
2020-02-26 15:26 [PATCH net] net: phy: mscc: fix firmware paths Antoine Tenart
@ 2020-02-26 15:45 ` Andrew Lunn
2020-02-27 4:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-02-26 15:45 UTC (permalink / raw)
To: Antoine Tenart; +Cc: davem, f.fainelli, hkallweit1, netdev, linux-kernel, foss
On Wed, Feb 26, 2020 at 04:26:50PM +0100, Antoine Tenart wrote:
> The firmware paths for the VSC8584 PHYs not not contain the leading
> 'microchip/' directory, as used in linux-firmware, resulting in an
> error when probing the driver. This patch fixes it.
>
> Fixes: a5afc1678044 ("net: phy: mscc: add support for VSC8584 PHY")
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: mscc: fix firmware paths
2020-02-26 15:26 [PATCH net] net: phy: mscc: fix firmware paths Antoine Tenart
2020-02-26 15:45 ` Andrew Lunn
@ 2020-02-27 4:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-02-27 4:53 UTC (permalink / raw)
To: antoine.tenart; +Cc: andrew, f.fainelli, hkallweit1, netdev, linux-kernel, foss
From: Antoine Tenart <antoine.tenart@bootlin.com>
Date: Wed, 26 Feb 2020 16:26:50 +0100
> The firmware paths for the VSC8584 PHYs not not contain the leading
> 'microchip/' directory, as used in linux-firmware, resulting in an
> error when probing the driver. This patch fixes it.
>
> Fixes: a5afc1678044 ("net: phy: mscc: add support for VSC8584 PHY")
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Applied, thanks Antoine.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-27 4:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 15:26 [PATCH net] net: phy: mscc: fix firmware paths Antoine Tenart
2020-02-26 15:45 ` Andrew Lunn
2020-02-27 4:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).