From: Mel Gorman <mgorman@techsingularity.net>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com
Subject: Re: [PATCH] sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA
Date: Thu, 27 Feb 2020 14:00:57 +0000 [thread overview]
Message-ID: <20200227140057.GG3818@techsingularity.net> (raw)
In-Reply-To: <74d75844-e710-6df8-30a9-acd440394c2e@arm.com>
On Thu, Feb 27, 2020 at 12:08:46PM +0000, Lukasz Luba wrote:
> Hi Valentin,
>
> On 2/27/20 11:04 AM, Valentin Schneider wrote:
> > Hi Lukasz,
> >
> > On 2/27/20 11:00 AM, Lukasz Luba wrote:
> > > Fix kernel build warning in kernel/sched/fair.c when CONFIG_SCHED_SMT is
> > > not set and CONFIG_NUMA_BALANCING is set.
> > >
> > > kernel/sched/fair.c:1524:20: warning: ???test_idle_cores??? declared ???static??? but never defined [-Wunused-function]
> > >
> >
> > I've sent a similar fix yesterday at:
> >
> > https://lore.kernel.org/lkml/20200226121244.7524-1-valentin.schneider@arm.com/
> >
>
> I've missed it. You are referring in the commit message to wrong change
> (probably HEAD of that branch), while when you try to bisect, it
> will point you to
> ff7db0bf24db sched/numa: Prefer using an idle CPU as a migration target
> instead of comparing tasks
>
> I think Mel can simply resend the patches with correct build if Ingo
> is OK.
>
> If Mel would decide to go with extended approach of ifdefs, then maybe
> it's also good to put in there numa_idle_core(), which actually uses
> these test_idle_cores() and is_core_idle()
>
I preferred the first fix. I'll send just it on with an editted changelog
to identify the exact patch that caused the problem. Ingo will hopefully
let me know if he prefers to pick up the fix on top or a resend of the
series with the fix folded in.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2020-02-27 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 11:00 [PATCH] sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA Lukasz Luba
2020-02-27 11:04 ` Valentin Schneider
2020-02-27 12:08 ` Lukasz Luba
2020-02-27 14:00 ` Mel Gorman [this message]
2020-02-27 14:02 Mel Gorman
2020-02-28 10:02 ` Lukasz Luba
2020-03-03 10:08 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227140057.GG3818@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).