linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] zte:zx-spdif:remove redundant dev_err message
@ 2020-02-27 15:07 tangbin
  2020-02-27 15:15 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: tangbin @ 2020-02-27 15:07 UTC (permalink / raw)
  To: jun.nie
  Cc: shawnguo, lgirdwood, broonie, perex, tiwai, linux-arm-kernel,
	alsa-devel, linux-kernel, tangbin

devm_ioremap_resource has already contains error message, so remove
the redundant dev_err message

Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
---
 sound/soc/zte/zx-spdif.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/zte/zx-spdif.c b/sound/soc/zte/zx-spdif.c
index 60382ec23..a3a07c073 100644
--- a/sound/soc/zte/zx-spdif.c
+++ b/sound/soc/zte/zx-spdif.c
@@ -322,7 +322,6 @@ static int zx_spdif_probe(struct platform_device *pdev)
 	zx_spdif->mapbase = res->start;
 	zx_spdif->reg_base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(zx_spdif->reg_base)) {
-		dev_err(&pdev->dev, "ioremap failed!\n");
 		return PTR_ERR(zx_spdif->reg_base);
 	}
 
-- 
2.20.1.windows.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] zte:zx-spdif:remove redundant dev_err message
  2020-02-27 15:07 [PATCH] zte:zx-spdif:remove redundant dev_err message tangbin
@ 2020-02-27 15:15 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-02-27 15:15 UTC (permalink / raw)
  To: tangbin
  Cc: jun.nie, shawnguo, lgirdwood, perex, tiwai, linux-arm-kernel,
	alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

On Thu, Feb 27, 2020 at 11:07:01PM +0800, tangbin wrote:
> devm_ioremap_resource has already contains error message, so remove
> the redundant dev_err message

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-27 15:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 15:07 [PATCH] zte:zx-spdif:remove redundant dev_err message tangbin
2020-02-27 15:15 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).