* [PATCH] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()
@ 2020-02-27 15:50 George Wilson
2020-02-27 16:23 ` Jarkko Sakkinen
0 siblings, 1 reply; 3+ messages in thread
From: George Wilson @ 2020-02-27 15:50 UTC (permalink / raw)
To: linux-integrity
Cc: Alexey Kardashevskiy, Stefan Berger, Jarkko Sakkinen, Nayna Jain,
Jason Gunthorpe, linux-kernel, George Wilson, Linh Pham
tpm_ibmvtpm_send() can fail during LPM resume with an H_CLOSED return
from ibmvtpm_send_crq(). The PAPR says, 'The “partner partition
suspended” transport event disables the associated CRQ such that any
H_SEND_CRQ hcall() to the associated CRQ returns H_Closed until the CRQ
has been explicitly enabled using the H_ENABLE_CRQ hcall.' This patch
adds a check in tpm_ibmvtpm_send() for an H_CLOSED return from
ibmvtpm_send_crq() and in that case calls tpm_ibmvtpm_resume() and
retries the ibmvtpm_send_crq() once.
Reported-by: Linh Pham <phaml@us.ibm.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: George Wilson <gcwilson@linux.ibm.com>
---
drivers/char/tpm/tpm_ibmvtpm.c | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index 78cc52690177..ba3bd503e080 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * Copyright (C) 2012 IBM Corporation
+ * Copyright (C) 2012-2020 IBM Corporation
*
* Author: Ashley Lai <ashleydlai@gmail.com>
*
@@ -25,6 +25,8 @@
#include "tpm.h"
#include "tpm_ibmvtpm.h"
+static int tpm_ibmvtpm_resume(struct device *dev);
+
static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";
static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
@@ -147,6 +149,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
{
struct ibmvtpm_dev *ibmvtpm = dev_get_drvdata(&chip->dev);
int rc, sig;
+ bool retry = true;
if (!ibmvtpm->rtce_buf) {
dev_err(ibmvtpm->dev, "ibmvtpm device is not ready\n");
@@ -179,18 +182,28 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
*/
ibmvtpm->tpm_processing_cmd = true;
+again:
rc = ibmvtpm_send_crq(ibmvtpm->vdev,
IBMVTPM_VALID_CMD, VTPM_TPM_COMMAND,
count, ibmvtpm->rtce_dma_handle);
+
if (rc != H_SUCCESS) {
+ /*
+ * H_CLOSED can be returned after LPM resume. Call
+ * tpm_ibmvtpm_resume() to re-enable the CRQ then retry
+ * ibmvtpm_send_crq() once before failing.
+ */
+ if (rc == H_CLOSED && retry) {
+ tpm_ibmvtpm_resume(ibmvtpm->dev);
+ retry = false;
+ goto again;
+ }
dev_err(ibmvtpm->dev, "tpm_ibmvtpm_send failed rc=%d\n", rc);
- rc = 0;
ibmvtpm->tpm_processing_cmd = false;
- } else
- rc = 0;
+ }
spin_unlock(&ibmvtpm->rtce_lock);
- return rc;
+ return 0;
}
static void tpm_ibmvtpm_cancel(struct tpm_chip *chip)
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()
2020-02-27 15:50 [PATCH] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send() George Wilson
@ 2020-02-27 16:23 ` Jarkko Sakkinen
2020-02-27 16:40 ` George Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2020-02-27 16:23 UTC (permalink / raw)
To: George Wilson
Cc: linux-integrity, Alexey Kardashevskiy, Stefan Berger, Nayna Jain,
Jason Gunthorpe, linux-kernel, Linh Pham
On Thu, Feb 27, 2020 at 10:50:03AM -0500, George Wilson wrote:
> tpm_ibmvtpm_send() can fail during LPM resume with an H_CLOSED return
> from ibmvtpm_send_crq(). The PAPR says, 'The “partner partition
> suspended” transport event disables the associated CRQ such that any
> H_SEND_CRQ hcall() to the associated CRQ returns H_Closed until the CRQ
> has been explicitly enabled using the H_ENABLE_CRQ hcall.' This patch
> adds a check in tpm_ibmvtpm_send() for an H_CLOSED return from
> ibmvtpm_send_crq() and in that case calls tpm_ibmvtpm_resume() and
> retries the ibmvtpm_send_crq() once.
>
> Reported-by: Linh Pham <phaml@us.ibm.com>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: George Wilson <gcwilson@linux.ibm.com>
What is LPM anyway?
/Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()
2020-02-27 16:23 ` Jarkko Sakkinen
@ 2020-02-27 16:40 ` George Wilson
0 siblings, 0 replies; 3+ messages in thread
From: George Wilson @ 2020-02-27 16:40 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: linux-integrity, Alexey Kardashevskiy, Stefan Berger, Nayna Jain,
Jason Gunthorpe, linux-kernel, Linh Pham
On Thu, Feb 27, 2020 at 06:23:39PM +0200, Jarkko Sakkinen wrote:
> On Thu, Feb 27, 2020 at 10:50:03AM -0500, George Wilson wrote:
> > tpm_ibmvtpm_send() can fail during LPM resume with an H_CLOSED return
> > from ibmvtpm_send_crq(). The PAPR says, 'The “partner partition
> > suspended” transport event disables the associated CRQ such that any
> > H_SEND_CRQ hcall() to the associated CRQ returns H_Closed until the CRQ
> > has been explicitly enabled using the H_ENABLE_CRQ hcall.' This patch
> > adds a check in tpm_ibmvtpm_send() for an H_CLOSED return from
> > ibmvtpm_send_crq() and in that case calls tpm_ibmvtpm_resume() and
> > retries the ibmvtpm_send_crq() once.
> >
> > Reported-by: Linh Pham <phaml@us.ibm.com>
> > Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> > Signed-off-by: George Wilson <gcwilson@linux.ibm.com>
>
> What is LPM anyway?
It's PowerVM Live Partition Mobility.
>
> /Jarkko
--
George Wilson
IBM Linux Technology Center
Security Development
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-27 16:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 15:50 [PATCH] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send() George Wilson
2020-02-27 16:23 ` Jarkko Sakkinen
2020-02-27 16:40 ` George Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).