linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version
@ 2020-02-27 16:48 Tomasz Maciej Nowak
  2020-02-27 16:48 ` [PATCH 2/2] arm64: dts: marvell: build ESPRESSObin variants Tomasz Maciej Nowak
  2020-03-13 20:32 ` [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version Gregory CLEMENT
  0 siblings, 2 replies; 4+ messages in thread
From: Tomasz Maciej Nowak @ 2020-02-27 16:48 UTC (permalink / raw)
  To: robh+dt, mark.rutland, gregory.clement, devicetree, linux-kernel

The commit introducing ESPRESSObin variants didn't specify dts version,
and because of that they are treated by dtc as legacy ones. Fix that by
properly specifying version in each dts.

Fixes: 447b878935 ("arm64: dts: marvell: add ESPRESSObin variants")
Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>
---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts    | 2 ++
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts | 2 ++
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts      | 2 ++
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi        | 2 --
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
index bd9ed9dc9c3e..ec72a11ed80f 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
@@ -11,6 +11,8 @@
  * Schematic available at http://espressobin.net/wp-content/uploads/2017/08/ESPRESSObin_V5_Schematics.pdf
  */
 
+/dts-v1/;
+
 #include "armada-3720-espressobin.dtsi"
 
 / {
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
index 6e876a6d9532..03733fd92732 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
@@ -11,6 +11,8 @@
  * Schematic available at http://wiki.espressobin.net/tiki-download_file.php?fileId=200
  */
 
+/dts-v1/;
+
 #include "armada-3720-espressobin.dtsi"
 
 / {
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
index 0f8405d085fd..8570c5f47d7d 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
@@ -11,6 +11,8 @@
  * Schematic available at http://wiki.espressobin.net/tiki-download_file.php?fileId=200
  */
 
+/dts-v1/;
+
 #include "armada-3720-espressobin.dtsi"
 
 / {
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
index 53b8ac55a7f3..c8e2e993c69c 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
@@ -7,8 +7,6 @@
  *
  */
 
-/dts-v1/;
-
 #include <dt-bindings/gpio/gpio.h>
 #include "armada-372x.dtsi"
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: marvell: build ESPRESSObin variants
  2020-02-27 16:48 [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version Tomasz Maciej Nowak
@ 2020-02-27 16:48 ` Tomasz Maciej Nowak
  2020-03-13 20:32   ` Gregory CLEMENT
  2020-03-13 20:32 ` [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version Gregory CLEMENT
  1 sibling, 1 reply; 4+ messages in thread
From: Tomasz Maciej Nowak @ 2020-02-27 16:48 UTC (permalink / raw)
  To: robh+dt, mark.rutland, gregory.clement, devicetree, linux-kernel

The commit adding ESPRESSObin variants didn't include those in Makefile to
be built.

Fixes: 447b878935 ("arm64: dts: marvell: add ESPRESSObin variants")
Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>
---
 arch/arm64/boot/dts/marvell/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
index f1b5127f0b89..3e5f2e7a040c 100644
--- a/arch/arm64/boot/dts/marvell/Makefile
+++ b/arch/arm64/boot/dts/marvell/Makefile
@@ -2,6 +2,9 @@
 # Mvebu SoC Family
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
+dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
+dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7.dtb
+dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7-emmc.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-turris-mox.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-uDPU.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-7040-db.dtb
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version
  2020-02-27 16:48 [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version Tomasz Maciej Nowak
  2020-02-27 16:48 ` [PATCH 2/2] arm64: dts: marvell: build ESPRESSObin variants Tomasz Maciej Nowak
@ 2020-03-13 20:32 ` Gregory CLEMENT
  1 sibling, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2020-03-13 20:32 UTC (permalink / raw)
  To: Tomasz Maciej Nowak, robh+dt, mark.rutland, devicetree, linux-kernel

Hi Tomasz,

> The commit introducing ESPRESSObin variants didn't specify dts version,
> and because of that they are treated by dtc as legacy ones. Fix that by
> properly specifying version in each dts.
>
> Fixes: 447b878935 ("arm64: dts: marvell: add ESPRESSObin variants")
> Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts    | 2 ++
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts | 2 ++
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts      | 2 ++
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi        | 2 --
>  4 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
> index bd9ed9dc9c3e..ec72a11ed80f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
> @@ -11,6 +11,8 @@
>   * Schematic available at http://espressobin.net/wp-content/uploads/2017/08/ESPRESSObin_V5_Schematics.pdf
>   */
>  
> +/dts-v1/;
> +
>  #include "armada-3720-espressobin.dtsi"
>  
>  / {
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 6e876a6d9532..03733fd92732 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -11,6 +11,8 @@
>   * Schematic available at http://wiki.espressobin.net/tiki-download_file.php?fileId=200
>   */
>  
> +/dts-v1/;
> +
>  #include "armada-3720-espressobin.dtsi"
>  
>  / {
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index 0f8405d085fd..8570c5f47d7d 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -11,6 +11,8 @@
>   * Schematic available at http://wiki.espressobin.net/tiki-download_file.php?fileId=200
>   */
>  
> +/dts-v1/;
> +
>  #include "armada-3720-espressobin.dtsi"
>  
>  / {
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index 53b8ac55a7f3..c8e2e993c69c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -7,8 +7,6 @@
>   *
>   */
>  
> -/dts-v1/;
> -
>  #include <dt-bindings/gpio/gpio.h>
>  #include "armada-372x.dtsi"
>  
> -- 
> 2.25.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm64: dts: marvell: build ESPRESSObin variants
  2020-02-27 16:48 ` [PATCH 2/2] arm64: dts: marvell: build ESPRESSObin variants Tomasz Maciej Nowak
@ 2020-03-13 20:32   ` Gregory CLEMENT
  0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2020-03-13 20:32 UTC (permalink / raw)
  To: Tomasz Maciej Nowak, robh+dt, mark.rutland, devicetree, linux-kernel

Hi Tomasz,

> The commit adding ESPRESSObin variants didn't include those in Makefile to
> be built.
>
> Fixes: 447b878935 ("arm64: dts: marvell: add ESPRESSObin variants")
> Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>


Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> index f1b5127f0b89..3e5f2e7a040c 100644
> --- a/arch/arm64/boot/dts/marvell/Makefile
> +++ b/arch/arm64/boot/dts/marvell/Makefile
> @@ -2,6 +2,9 @@
>  # Mvebu SoC Family
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7-emmc.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-turris-mox.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-uDPU.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-7040-db.dtb
> -- 
> 2.25.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-13 20:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 16:48 [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version Tomasz Maciej Nowak
2020-02-27 16:48 ` [PATCH 2/2] arm64: dts: marvell: build ESPRESSObin variants Tomasz Maciej Nowak
2020-03-13 20:32   ` Gregory CLEMENT
2020-03-13 20:32 ` [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).