* [PATCH -next] MIPS: pic32mzda: Drop pointless static qualifier
@ 2020-02-27 7:05 YueHaibing
2020-02-28 11:45 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-02-27 7:05 UTC (permalink / raw)
To: ralf, paulburton, tglx, sboyd, geert+renesas, f4bug, Thomas Bogendoerfer
Cc: YueHaibing, linux-mips, linux-kernel, kernel-janitors
There is no need to have the 'struct device_node *node' variable static
since new value always be assigned before use it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/mips/pic32/pic32mzda/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/pic32/pic32mzda/time.c b/arch/mips/pic32/pic32mzda/time.c
index 754924f26089..7174e9abbb1b 100644
--- a/arch/mips/pic32/pic32mzda/time.c
+++ b/arch/mips/pic32/pic32mzda/time.c
@@ -23,7 +23,7 @@ static const struct of_device_id pic32_infra_match[] = {
static unsigned int pic32_xlate_core_timer_irq(void)
{
- static struct device_node *node;
+ struct device_node *node;
unsigned int irq;
node = of_find_matching_node(NULL, pic32_infra_match);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] MIPS: pic32mzda: Drop pointless static qualifier
2020-02-27 7:05 [PATCH -next] MIPS: pic32mzda: Drop pointless static qualifier YueHaibing
@ 2020-02-28 11:45 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2020-02-28 11:45 UTC (permalink / raw)
To: YueHaibing
Cc: ralf, paulburton, tglx, sboyd, geert+renesas, f4bug, linux-mips,
linux-kernel, kernel-janitors
On Thu, Feb 27, 2020 at 07:05:02AM +0000, YueHaibing wrote:
> There is no need to have the 'struct device_node *node' variable static
> since new value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> arch/mips/pic32/pic32mzda/time.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-28 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 7:05 [PATCH -next] MIPS: pic32mzda: Drop pointless static qualifier YueHaibing
2020-02-28 11:45 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).