* [PATCH] mtd: rawnand: ingenic: Fix unmet dependency if COMPILE_TEST
@ 2020-02-29 16:04 Paul Cercueil
2020-03-02 9:26 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Paul Cercueil @ 2020-02-29 16:04 UTC (permalink / raw)
To: Harvey Hunt, Miquel Raynal, Richard Weinberger
Cc: Vignesh Raghavendra, od, linux-mtd, linux-kernel, Paul Cercueil, stable
Commit 7c779cf7c1f7 ("mtd: rawnand: ingenic: Allow to compile test the
new Ingenic driver") dropped the dependency on JZ4780_NEMC when
COMPILE_TEST was set, which is wrong, as the driver requires symbols
provided by the jz4780-nemc driver.
Change the dependency to (MIPS || COMPILE_TEST) && JZ4780_NEMC to
address the issue.
Fixes: 7c779cf7c1f7 ("mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver")
Cc: stable@vger.kernel.org
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/mtd/nand/raw/ingenic/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig b/drivers/mtd/nand/raw/ingenic/Kconfig
index 485abfa3f80b..96c5ae8b1bbc 100644
--- a/drivers/mtd/nand/raw/ingenic/Kconfig
+++ b/drivers/mtd/nand/raw/ingenic/Kconfig
@@ -1,7 +1,8 @@
# SPDX-License-Identifier: GPL-2.0-only
config MTD_NAND_JZ4780
tristate "JZ4780 NAND controller"
- depends on JZ4780_NEMC || COMPILE_TEST
+ depends on MIPS || COMPILE_TEST
+ depends on JZ4780_NEMC
help
Enables support for NAND Flash connected to the NEMC on JZ4780 SoC
based boards, using the BCH controller for hardware error correction.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: ingenic: Fix unmet dependency if COMPILE_TEST
2020-02-29 16:04 [PATCH] mtd: rawnand: ingenic: Fix unmet dependency if COMPILE_TEST Paul Cercueil
@ 2020-03-02 9:26 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2020-03-02 9:26 UTC (permalink / raw)
To: Paul Cercueil
Cc: Harvey Hunt, Richard Weinberger, Vignesh Raghavendra, od,
linux-mtd, linux-kernel, stable
Hi Paul,
Paul Cercueil <paul@crapouillou.net> wrote on Sat, 29 Feb 2020 13:04:43
-0300:
> Commit 7c779cf7c1f7 ("mtd: rawnand: ingenic: Allow to compile test the
> new Ingenic driver") dropped the dependency on JZ4780_NEMC when
> COMPILE_TEST was set, which is wrong, as the driver requires symbols
> provided by the jz4780-nemc driver.
>
> Change the dependency to (MIPS || COMPILE_TEST) && JZ4780_NEMC to
> address the issue.
That was simple actually, thanks for finding the solution. Actually I
don't think I mergeg my own patch as it was creating this build issue
(unless I messed with something :) ) so can you please send a patch
just adding COMPILE_TEST support without any Fixes mention?
>
> Fixes: 7c779cf7c1f7 ("mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/mtd/nand/raw/ingenic/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig b/drivers/mtd/nand/raw/ingenic/Kconfig
> index 485abfa3f80b..96c5ae8b1bbc 100644
> --- a/drivers/mtd/nand/raw/ingenic/Kconfig
> +++ b/drivers/mtd/nand/raw/ingenic/Kconfig
> @@ -1,7 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config MTD_NAND_JZ4780
> tristate "JZ4780 NAND controller"
> - depends on JZ4780_NEMC || COMPILE_TEST
> + depends on MIPS || COMPILE_TEST
> + depends on JZ4780_NEMC
> help
> Enables support for NAND Flash connected to the NEMC on JZ4780 SoC
> based boards, using the BCH controller for hardware error correction.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-02 9:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-29 16:04 [PATCH] mtd: rawnand: ingenic: Fix unmet dependency if COMPILE_TEST Paul Cercueil
2020-03-02 9:26 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).