linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/1] Fix silent output on Gigabyte X570 Aorus Master
@ 2020-03-03 15:36 Christian Lachner
  2020-03-03 15:36 ` [PATCH v2 1/1] ALSA: hda/realtek - " Christian Lachner
  0 siblings, 1 reply; 4+ messages in thread
From: Christian Lachner @ 2020-03-03 15:36 UTC (permalink / raw)
  To: perex, tiwai, kailang; +Cc: alsa-devel, linux-kernel, Christian Lachner

The Gigabyte X570 Aorus Master motherboard with ALC1220 codec
requires a similar workaround for Clevo laptops to enforce the
DAC/mixer connection path. This patch sets up a quirk entry for
that. It was tested by myself on my own hardware for some time
and it works just fine. We should probably rename
ALC1220_FIXUP_CLEVO_P950 at some point as the amount of
non-Clevo hardware needing this workaround is growing.

Christian Lachner (1):
  ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)


base-commit: 98d54f81e36ba3bf92172791eba5ca5bd813989b
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master
  2020-03-03 15:36 [PATCH v2 0/1] Fix silent output on Gigabyte X570 Aorus Master Christian Lachner
@ 2020-03-03 15:36 ` Christian Lachner
  2020-03-05 14:52   ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Christian Lachner @ 2020-03-03 15:36 UTC (permalink / raw)
  To: perex, tiwai, kailang; +Cc: alsa-devel, linux-kernel, Christian Lachner

The Gigabyte X570 Aorus Master motherboard with ALC1220 codec
requires a similar workaround for Clevo laptops to enforce the
DAC/mixer connection path. Set up a quirk entry for that.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205275
Signed-off-by: Christian Lachner <gladiac@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 477589e7ec1d..8722616c6cc6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2447,6 +2447,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC882_FIXUP_EAPD),
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+	SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1276, "MSI-GL73", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1293, "MSI-GP65", ALC1220_FIXUP_CLEVO_P950),
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master
  2020-03-03 15:36 ` [PATCH v2 1/1] ALSA: hda/realtek - " Christian Lachner
@ 2020-03-05 14:52   ` Takashi Iwai
       [not found]     ` <CAE3uWP3Shf+vEwV-wUDUmzizSOCS5cSvND+-=rZijefgkmp2tQ@mail.gmail.com>
  0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2020-03-05 14:52 UTC (permalink / raw)
  To: Christian Lachner; +Cc: perex, tiwai, kailang, alsa-devel, linux-kernel

On Tue, 03 Mar 2020 16:36:19 +0100,
Christian Lachner wrote:
> 
> The Gigabyte X570 Aorus Master motherboard with ALC1220 codec
> requires a similar workaround for Clevo laptops to enforce the
> DAC/mixer connection path. Set up a quirk entry for that.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205275
> Signed-off-by: Christian Lachner <gladiac@gmail.com>

What's the difference from v1?  I already applied v1.


thanks,

Takashi


> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 477589e7ec1d..8722616c6cc6 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -2447,6 +2447,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC882_FIXUP_EAPD),
>  	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
> +	SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_CLEVO_P950),
>  	SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950),
>  	SND_PCI_QUIRK(0x1462, 0x1276, "MSI-GL73", ALC1220_FIXUP_CLEVO_P950),
>  	SND_PCI_QUIRK(0x1462, 0x1293, "MSI-GP65", ALC1220_FIXUP_CLEVO_P950),
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master
       [not found]     ` <CAE3uWP3Shf+vEwV-wUDUmzizSOCS5cSvND+-=rZijefgkmp2tQ@mail.gmail.com>
@ 2020-03-06  5:53       ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-03-06  5:53 UTC (permalink / raw)
  To: Chris; +Cc: perex, tiwai, kailang, alsa-devel, linux-kernel

On Thu, 05 Mar 2020 16:14:10 +0100,
Chris wrote:
> 
> Hello, I am really sorry for the mess-up. It is the exact same patch. I just
> re-sent it because v1 did not show up in the alsa-devel mailinglist because i
> did not do the registration beforehand. Please ignore v2.
> Thanks a lot, Chris

OK, thanks for confirmation.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-06  5:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 15:36 [PATCH v2 0/1] Fix silent output on Gigabyte X570 Aorus Master Christian Lachner
2020-03-03 15:36 ` [PATCH v2 1/1] ALSA: hda/realtek - " Christian Lachner
2020-03-05 14:52   ` Takashi Iwai
     [not found]     ` <CAE3uWP3Shf+vEwV-wUDUmzizSOCS5cSvND+-=rZijefgkmp2tQ@mail.gmail.com>
2020-03-06  5:53       ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).