From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <sean.j.christopherson@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Pu Wen <puwen@hygon.cn>
Subject: [PATCH v2 0/7] KVM: x86: CPUID emulation and tracing fixes
Date: Wed, 4 Mar 2020 17:34:30 -0800 [thread overview]
Message-ID: <20200305013437.8578-1-sean.j.christopherson@intel.com> (raw)
Round two of trying to wrangle kvm_cpuid() into submission. Two more bug
fixes, both related to querying for an "AMD" vendor, in addition to the
fixes in v1 (tracing and Hypervisor/Centaur range checks).
In theory, everything up to the refactoring is non-controversial, i.e. we
can bikeshed the refactoring without delaying the bug fixes.
v2:
- Use Jan's patch to fix the trace bug. [Everyone]
- Rework Hypervisor/Centaur handling so that only the Hypervisor
sub-ranges get the restrictive 0xffffff00 mask, and so that Centaur's
range only gets recognized when the guest vendor is Centaur. [Jim]
- Add the aforementioned bug fixes.
- Add a patch to do build time assertions on the vendor string, which
are hand coded u32s in the emulator (for direct comparison against
CPUID register output).
- Drop the patch to add CPUID.maxphyaddr emulator helper. [Paolo]
- Redo refactoring patches to land them after all the bug fixes
and to do the refactoring without any semantic changes in the
emulator.
Jan Kiszka (1):
KVM: x86: Trace the original requested CPUID function in kvm_cpuid()
Sean Christopherson (6):
KVM: x86: Add helpers to perform CPUID-based guest vendor check
KVM x86: Extend AMD specific guest behavior to Hygon virtual CPUs
KVM: x86: Fix CPUID range checks for Hypervisor and Centaur classes
KVM: x86: Add build-time assertions on validity of vendor strings
KVM: x86: Refactor out-of-range logic to contain the madness
KVM: x86: Refactor kvm_cpuid() param that controls out-of-range logic
arch/x86/include/asm/kvm_emulate.h | 37 +++++++++-
arch/x86/kvm/cpuid.c | 111 +++++++++++++++++++++--------
arch/x86/kvm/cpuid.h | 8 ++-
arch/x86/kvm/emulate.c | 64 ++++++++---------
arch/x86/kvm/mmu/mmu.c | 3 +-
arch/x86/kvm/svm.c | 2 +-
arch/x86/kvm/x86.c | 7 +-
7 files changed, 162 insertions(+), 70 deletions(-)
--
2.24.1
next reply other threads:[~2020-03-05 1:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 1:34 Sean Christopherson [this message]
2020-03-05 1:34 ` [PATCH v2 1/7] KVM: x86: Trace the original requested CPUID function in kvm_cpuid() Sean Christopherson
2020-03-05 17:50 ` Jim Mattson
2020-03-05 1:34 ` [PATCH v2 2/7] KVM: x86: Add helpers to perform CPUID-based guest vendor check Sean Christopherson
2020-03-05 3:48 ` Xiaoyao Li
2020-03-05 19:58 ` Sean Christopherson
2020-03-05 18:07 ` Jim Mattson
2020-03-05 1:34 ` [PATCH v2 3/7] KVM x86: Extend AMD specific guest behavior to Hygon virtual CPUs Sean Christopherson
2020-03-05 1:34 ` [PATCH v2 4/7] KVM: x86: Fix CPUID range checks for Hypervisor and Centaur classes Sean Christopherson
2020-03-05 18:43 ` Jim Mattson
2020-03-05 19:25 ` Sean Christopherson
2020-03-05 21:10 ` Jim Mattson
2020-03-05 21:51 ` Sean Christopherson
2020-03-06 9:03 ` Paolo Bonzini
2020-03-10 17:10 ` Sean Christopherson
2020-03-10 17:23 ` Jim Mattson
2020-03-05 1:34 ` [PATCH v2 5/7] KVM: x86: Add build-time assertions on validity of vendor strings Sean Christopherson
2020-03-05 1:34 ` [PATCH v2 6/7] KVM: x86: Refactor out-of-range logic to contain the madness Sean Christopherson
2020-03-05 1:34 ` [PATCH v2 7/7] KVM: x86: Refactor kvm_cpuid() param that controls out-of-range logic Sean Christopherson
2020-03-05 16:42 ` [PATCH v2 0/7] KVM: x86: CPUID emulation and tracing fixes Paolo Bonzini
2020-03-05 17:12 ` Sean Christopherson
2020-03-06 8:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305013437.8578-1-sean.j.christopherson@intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=puwen@hygon.cn \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).