From: Greg KH <gregkh@linuxfoundation.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Borislav Petkov <bp@alien8.de>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>
Subject: Re: [BUGFIX PATCH] tools: Let O= makes handle a relative path with -C option
Date: Thu, 5 Mar 2020 15:51:59 +0100 [thread overview]
Message-ID: <20200305145159.GB1950999@kroah.com> (raw)
In-Reply-To: <158338818292.25448.7161196505598269976.stgit@devnote2>
On Thu, Mar 05, 2020 at 03:03:03PM +0900, Masami Hiramatsu wrote:
> When I compiled tools/bootconfig from top directory with
> -C option, the O= option didn't work correctly if I passed
> a relative path.
>
> $ make O=./builddir/ -C tools/bootconfig/
> make: Entering directory '/home/mhiramat/ksrc/linux/tools/bootconfig'
> ../scripts/Makefile.include:4: *** O=./builddir/ does not exist. Stop.
> make: Leaving directory '/home/mhiramat/ksrc/linux/tools/bootconfig'
>
> The O= directory existence check failed because the check
> script ran in the build target directory instead of the
> directory where I ran the make command.
>
> To fix that, once change directory to $(PWD) and check O=
> directory, since the PWD is set to where the make command
> runs.
>
> Fixes: c883122acc0d ("perf tools: Let O= makes handle relative paths")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/scripts/Makefile.include | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2020-03-05 14:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 11:24 [PATCH 0/2] tools/bootconfig: Add O= option and enhance error message Masami Hiramatsu
2020-03-03 11:24 ` [PATCH 1/2] bootconfig: Support O=<builddir> option Masami Hiramatsu
2020-03-04 23:04 ` Randy Dunlap
2020-03-05 2:05 ` Masami Hiramatsu
2020-03-05 3:17 ` Steven Rostedt
2020-03-05 4:52 ` Randy Dunlap
2020-03-05 6:03 ` [BUGFIX PATCH] tools: Let O= makes handle a relative path with -C option Masami Hiramatsu
2020-03-05 14:51 ` Greg KH [this message]
2020-03-05 18:50 ` Randy Dunlap
2020-03-06 1:39 ` Masami Hiramatsu
2020-03-06 5:17 ` Randy Dunlap
2020-03-06 7:52 ` Geert Uytterhoeven
2020-03-06 15:07 ` Masami Hiramatsu
2020-03-06 16:26 ` Randy Dunlap
2020-03-06 18:10 ` Masami Hiramatsu
2020-03-06 18:26 ` Randy Dunlap
2020-03-06 16:45 ` Steven Rostedt
2020-03-05 7:41 ` [PATCH 1/2] bootconfig: Support O=<builddir> option Geert Uytterhoeven
2020-03-05 18:51 ` Randy Dunlap
2020-03-03 11:24 ` [PATCH 2/2] tools/bootconfig: Show line and column in parse error Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305145159.GB1950999@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).