From: Randy Dunlap <rdunlap@infradead.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Borislav Petkov <bp@alien8.de>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] bootconfig: Support O=<builddir> option
Date: Wed, 4 Mar 2020 15:04:43 -0800 [thread overview]
Message-ID: <27ae25f5-29c6-62f3-5531-78fcc28b7d3c@infradead.org> (raw)
In-Reply-To: <158323468033.10560.14661631369326294355.stgit@devnote2>
On 3/3/20 3:24 AM, Masami Hiramatsu wrote:
> Support O=<builddir> option to build bootconfig tool in
> the other directory. As same as other tools, if you specify
> O=<builddir>, bootconfig command is build under <builddir>.
Hm. If I use
$ make O=~/tmp -C tools/bootconfig
that works: it builds bootconfig in ~/tmp.
OTOH, if I sit at the top of the kernel source tree
and I enter
$ mkdir builddir
$ make O=builddir -C tools/bootconfig
I get this:
make: Entering directory '/home/rdunlap/lnx/next/linux-next-20200304/tools/bootconfig'
../scripts/Makefile.include:4: *** O=builddir does not exist. Stop.
make: Leaving directory '/home/rdunlap/lnx/next/linux-next-20200304/tools/bootconfig'
so it looks like tools/scripts/Makefile.include doesn't handle this case correctly
(which is how I do all of my builds).
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/bootconfig/Makefile | 27 +++++++++++++++++----------
> tools/bootconfig/test-bootconfig.sh | 14 ++++++++++----
> 2 files changed, 27 insertions(+), 14 deletions(-)
>
> diff --git a/tools/bootconfig/Makefile b/tools/bootconfig/Makefile
> index a6146ac64458..da5975775337 100644
> --- a/tools/bootconfig/Makefile
> +++ b/tools/bootconfig/Makefile
> @@ -1,23 +1,30 @@
> # SPDX-License-Identifier: GPL-2.0
> # Makefile for bootconfig command
> +include ../scripts/Makefile.include
>
> bindir ?= /usr/bin
>
> -HEADER = include/linux/bootconfig.h
> -CFLAGS = -Wall -g -I./include
> +ifeq ($(srctree),)
> +srctree := $(patsubst %/,%,$(dir $(CURDIR)))
> +srctree := $(patsubst %/,%,$(dir $(srctree)))
> +endif
>
> -PROGS = bootconfig
> +LIBSRC = $(srctree)/lib/bootconfig.c $(srctree)/include/linux/bootconfig.h
> +CFLAGS = -Wall -g -I$(CURDIR)/include
>
> -all: $(PROGS)
> +ALL_TARGETS := bootconfig
> +ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
>
> -bootconfig: ../../lib/bootconfig.c main.c $(HEADER)
> +all: $(ALL_PROGRAMS)
> +
> +$(OUTPUT)bootconfig: main.c $(LIBSRC)
> $(CC) $(filter %.c,$^) $(CFLAGS) -o $@
>
> -install: $(PROGS)
> - install bootconfig $(DESTDIR)$(bindir)
> +test: $(ALL_PROGRAMS) test-bootconfig.sh
> + ./test-bootconfig.sh $(OUTPUT)
>
> -test: bootconfig
> - ./test-bootconfig.sh
> +install: $(ALL_PROGRAMS)
> + install $(OUTPUT)bootconfig $(DESTDIR)$(bindir)
>
> clean:
> - $(RM) -f *.o bootconfig
> + $(RM) -f $(OUTPUT)*.o $(ALL_PROGRAMS)
> diff --git a/tools/bootconfig/test-bootconfig.sh b/tools/bootconfig/test-bootconfig.sh
> index 1411f4c3454f..81b350ffd03f 100755
> --- a/tools/bootconfig/test-bootconfig.sh
> +++ b/tools/bootconfig/test-bootconfig.sh
> @@ -3,9 +3,16 @@
>
> echo "Boot config test script"
>
> -BOOTCONF=./bootconfig
> -INITRD=`mktemp initrd-XXXX`
> -TEMPCONF=`mktemp temp-XXXX.bconf`
> +if [ -d "$1" ]; then
> + TESTDIR=$1
> +else
> + TESTDIR=.
> +fi
> +BOOTCONF=${TESTDIR}/bootconfig
> +
> +INITRD=`mktemp ${TESTDIR}/initrd-XXXX`
> +TEMPCONF=`mktemp ${TESTDIR}/temp-XXXX.bconf`
> +OUTFILE=`mktemp ${TESTDIR}/tempout-XXXX`
> NG=0
>
> cleanup() {
> @@ -65,7 +72,6 @@ new_size=$(stat -c %s $INITRD)
> xpass test $new_size -eq $initrd_size
>
> echo "No error messge while applying"
> -OUTFILE=`mktemp tempout-XXXX`
> dd if=/dev/zero of=$INITRD bs=4096 count=1
> printf " \0\0\0 \0\0\0" >> $INITRD
> $BOOTCONF -a $TEMPCONF $INITRD > $OUTFILE 2>&1
>
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
next prev parent reply other threads:[~2020-03-04 23:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 11:24 [PATCH 0/2] tools/bootconfig: Add O= option and enhance error message Masami Hiramatsu
2020-03-03 11:24 ` [PATCH 1/2] bootconfig: Support O=<builddir> option Masami Hiramatsu
2020-03-04 23:04 ` Randy Dunlap [this message]
2020-03-05 2:05 ` Masami Hiramatsu
2020-03-05 3:17 ` Steven Rostedt
2020-03-05 4:52 ` Randy Dunlap
2020-03-05 6:03 ` [BUGFIX PATCH] tools: Let O= makes handle a relative path with -C option Masami Hiramatsu
2020-03-05 14:51 ` Greg KH
2020-03-05 18:50 ` Randy Dunlap
2020-03-06 1:39 ` Masami Hiramatsu
2020-03-06 5:17 ` Randy Dunlap
2020-03-06 7:52 ` Geert Uytterhoeven
2020-03-06 15:07 ` Masami Hiramatsu
2020-03-06 16:26 ` Randy Dunlap
2020-03-06 18:10 ` Masami Hiramatsu
2020-03-06 18:26 ` Randy Dunlap
2020-03-06 16:45 ` Steven Rostedt
2020-03-05 7:41 ` [PATCH 1/2] bootconfig: Support O=<builddir> option Geert Uytterhoeven
2020-03-05 18:51 ` Randy Dunlap
2020-03-03 11:24 ` [PATCH 2/2] tools/bootconfig: Show line and column in parse error Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27ae25f5-29c6-62f3-5531-78fcc28b7d3c@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).