* [PATCH v6] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC
@ 2020-03-06 17:28 H. Nikolaus Schaller
2020-03-07 9:06 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: H. Nikolaus Schaller @ 2020-03-06 17:28 UTC (permalink / raw)
To: Paul Cercueil, Rob Herring, Mark Rutland, Thomas Bogendoerfer
Cc: devicetree, linux-mips, linux-kernel, letux-kernel,
H. Nikolaus Schaller, stable
Interrupts should not be specified by interrupt line but by
gpio parent and reference.
Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
Cc: stable@vger.kernel.org
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
---
arch/mips/boot/dts/ingenic/ci20.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
index 8b5fb635c66f..c340f947baa0 100644
--- a/arch/mips/boot/dts/ingenic/ci20.dts
+++ b/arch/mips/boot/dts/ingenic/ci20.dts
@@ -4,6 +4,7 @@
#include "jz4780.dtsi"
#include <dt-bindings/clock/ingenic,tcu.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/regulator/active-semi,8865-regulator.h>
/ {
@@ -270,7 +271,9 @@
rtc@51 {
compatible = "nxp,pcf8563";
reg = <0x51>;
- interrupts = <110>;
+
+ interrupt-parent = <&gpf>;
+ interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
};
};
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v6] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC
2020-03-06 17:28 [PATCH v6] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller
@ 2020-03-07 9:06 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2020-03-07 9:06 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Paul Cercueil, Rob Herring, Mark Rutland, devicetree, linux-mips,
linux-kernel, letux-kernel, stable
On Fri, Mar 06, 2020 at 06:28:30PM +0100, H. Nikolaus Schaller wrote:
> Interrupts should not be specified by interrupt line but by
> gpio parent and reference.
>
> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
> Cc: stable@vger.kernel.org
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-07 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 17:28 [PATCH v6] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller
2020-03-07 9:06 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).