From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Joe Perches <joe@perches.com>, Guenter Roeck <groeck@google.com>,
Stephen Boyd <swboyd@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Julius Werner <jwerner@chromium.org>,
kernel-janitors@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] MAINTAINERS: include GOOGLE FIRMWARE entry
Date: Mon, 9 Mar 2020 08:05:34 +0100 [thread overview]
Message-ID: <20200309070534.GA4093795@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2003090702440.3325@felia>
On Mon, Mar 09, 2020 at 07:32:10AM +0100, Lukas Bulwahn wrote:
>
>
> On Sun, 8 Mar 2020, Joe Perches wrote:
>
> > On Sun, 2020-03-08 at 15:32 -0700, Guenter Roeck wrote:
> > > On Sun, Mar 8, 2020 at 12:51 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > > > All files in drivers/firmware/google/ are identified as part of THE REST
> > > > according to MAINTAINERS, but they are really maintained by others.
> > []
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> > > > @@ -7111,6 +7111,14 @@ S: Supported
> > > > F: Documentation/networking/device_drivers/google/gve.rst
> > > > F: drivers/net/ethernet/google
> > > >
> > > > +GOOGLE FIRMWARE
> > > > +M: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > +M: Stephen Boyd <swboyd@chromium.org>
> > > > +R: Guenter Roeck <groeck@chromium.org>
> > > > +R: Julius Werner <jwerner@chromium.org>
> > > > +S: Maintained
> > > > +F: drivers/firmware/google/
> > > > +
> > >
> > > FWIW, I would not mind stepping up as maintainer if needed, but I
> > > think we should strongly discourage this kind of auto-assignment of
> > > maintainers and/or reviewers.
> >
> > Auto assignment should definitely _not_ be done.
> >
> > This is an RFC proposal though.
> >
> > Sometimes it's better to not produce an RFC as
> > a patch, but maybe just show a proposed section
> > and ask if is appropriate may be a better style
> > going forward.
> >
>
> Please interpret the RFC patch similar to an email as Joe wrote below,
> simply reaching out to you.
>
> There is no auto-assignment intended, nor did I expect the patch to be
> picked up on the first attempt of uneducated guessing.
>
> There are currently around 3,000 files identified being part of THE REST;
> so they are all assigned to Linus and LKML.
>
> To confirm that they actually are maintained by someone else and reflect
> that in MAINTAINERS, a bit of educated guessing who to contact and to
> which entry to add the files to is required.
>
> I am starting with the "bigger" clustered files in drivers, and then try
> to look at files in include and Documentation/ABI/.
>
> Here is a rough statistics on how many files from each directory are in
> THE REST:
>
> 1368 include
> 566 tools
> 327 lib
> 321 Documentation
> 100 drivers
> 91 kernel
> 84 scripts
> 75 samples
> 13 ipc
> 13 init
> 8 usr
> 2 arch
> 1 virt
When you use the get_maintainer.pl script, it should find reasonable
people/lists for those files, so why not just stick with that? Trying
to classify all of the kernel files to have MAINTAINERS entries seems
like a loosing proposition as there are file that no one has touched in
years.
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-09 7:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 19:51 [PATCH RFC] MAINTAINERS: include GOOGLE FIRMWARE entry Lukas Bulwahn
2020-03-08 19:57 ` Greg Kroah-Hartman
2020-03-08 20:13 ` Joe Perches
2020-03-08 22:32 ` Guenter Roeck
2020-03-08 22:54 ` Joe Perches
2020-03-09 6:32 ` Lukas Bulwahn
2020-03-09 7:05 ` Greg Kroah-Hartman [this message]
2020-03-09 21:03 ` Lukas Bulwahn
2020-03-09 23:12 ` Joe Perches
2020-03-10 6:48 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309070534.GA4093795@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=joe@perches.com \
--cc=jwerner@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).