From: Guenter Roeck <groeck@google.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <swboyd@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Julius Werner <jwerner@chromium.org>,
Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] MAINTAINERS: include GOOGLE FIRMWARE entry
Date: Sun, 8 Mar 2020 15:32:35 -0700 [thread overview]
Message-ID: <CABXOdTcrxoBCz24Ap=YJYZnr+oLAmaR10xZ9ar2mYbE1=RAoug@mail.gmail.com> (raw)
In-Reply-To: <20200308195116.12836-1-lukas.bulwahn@gmail.com>
On Sun, Mar 8, 2020 at 12:51 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> All files in drivers/firmware/google/ are identified as part of THE REST
> according to MAINTAINERS, but they are really maintained by others.
>
> Add a basic entry for drivers/firmware/google/ based on a simple statistics
> on tags of commits in that directory:
>
> $ git log drivers/firmware/google/ | grep '\-by:' \
> | sort | uniq -c | sort -nr
> 62 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 13 Reviewed-by: Guenter Roeck <groeck@chromium.org>
> 12 Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> 11 Reviewed-by: Julius Werner <jwerner@chromium.org>
>
> There is no specific mailing list for this driver, based on observations
> on the patch emails, and the git history suggests the driver is maintained.
>
> This was identified with a small script that finds all files belonging to
> THE REST according to the current MAINTAINERS file, and I investigated
> upon its output.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> MAINTAINERS | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3a0f8115c92c..ed788804daab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7111,6 +7111,14 @@ S: Supported
> F: Documentation/networking/device_drivers/google/gve.rst
> F: drivers/net/ethernet/google
>
> +GOOGLE FIRMWARE
> +M: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> +M: Stephen Boyd <swboyd@chromium.org>
> +R: Guenter Roeck <groeck@chromium.org>
> +R: Julius Werner <jwerner@chromium.org>
> +S: Maintained
> +F: drivers/firmware/google/
> +
FWIW, I would not mind stepping up as maintainer if needed, but I
think we should strongly discourage this kind of auto-assignment of
maintainers and/or reviewers.
Guenter
> GPD POCKET FAN DRIVER
> M: Hans de Goede <hdegoede@redhat.com>
> L: platform-driver-x86@vger.kernel.org
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-03-08 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 19:51 [PATCH RFC] MAINTAINERS: include GOOGLE FIRMWARE entry Lukas Bulwahn
2020-03-08 19:57 ` Greg Kroah-Hartman
2020-03-08 20:13 ` Joe Perches
2020-03-08 22:32 ` Guenter Roeck [this message]
2020-03-08 22:54 ` Joe Perches
2020-03-09 6:32 ` Lukas Bulwahn
2020-03-09 7:05 ` Greg Kroah-Hartman
2020-03-09 21:03 ` Lukas Bulwahn
2020-03-09 23:12 ` Joe Perches
2020-03-10 6:48 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABXOdTcrxoBCz24Ap=YJYZnr+oLAmaR10xZ9ar2mYbE1=RAoug@mail.gmail.com' \
--to=groeck@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=joe@perches.com \
--cc=jwerner@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).