* [PATCH v2 2/3] dt-bindings: arm: add Rockchip rk3036-evb board
2020-03-02 9:27 [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings Johan Jonker
@ 2020-03-02 9:27 ` Johan Jonker
2020-03-10 19:27 ` Rob Herring
2020-03-02 9:27 ` [PATCH v2 3/3] arm64: dts: rockchip: fix compatible property for rk3399-evb Johan Jonker
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Johan Jonker @ 2020-03-02 9:27 UTC (permalink / raw)
To: heiko; +Cc: robh+dt, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
A test with the command below gives this error:
arch/arm/boot/dts/rk3036-evb.dt.yaml: /: compatible:
['rockchip,rk3036-evb', 'rockchip,rk3036']
is not valid under any of the given schemas
This board was somehow never added to the documentation.
Fix this error by adding the rk3036-evb board to rockchip.yaml.
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 203158038..d303790f5 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -468,6 +468,11 @@ properties:
- const: rockchip,r88
- const: rockchip,rk3368
+ - description: Rockchip RK3036 Evaluation board
+ items:
+ - const: rockchip,rk3036-evb
+ - const: rockchip,rk3036
+
- description: Rockchip RK3228 Evaluation board
items:
- const: rockchip,rk3228-evb
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 2/3] dt-bindings: arm: add Rockchip rk3036-evb board
2020-03-02 9:27 ` [PATCH v2 2/3] dt-bindings: arm: add Rockchip rk3036-evb board Johan Jonker
@ 2020-03-10 19:27 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-03-10 19:27 UTC (permalink / raw)
To: Johan Jonker
Cc: heiko, robh+dt, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
On Mon, 2 Mar 2020 10:27:58 +0100, Johan Jonker wrote:
> A test with the command below gives this error:
>
> arch/arm/boot/dts/rk3036-evb.dt.yaml: /: compatible:
> ['rockchip,rk3036-evb', 'rockchip,rk3036']
> is not valid under any of the given schemas
>
> This board was somehow never added to the documentation.
> Fix this error by adding the rk3036-evb board to rockchip.yaml.
>
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] arm64: dts: rockchip: fix compatible property for rk3399-evb
2020-03-02 9:27 [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings Johan Jonker
2020-03-02 9:27 ` [PATCH v2 2/3] dt-bindings: arm: add Rockchip rk3036-evb board Johan Jonker
@ 2020-03-02 9:27 ` Johan Jonker
2020-03-10 19:27 ` [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings Rob Herring
2020-03-11 8:05 ` Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Johan Jonker @ 2020-03-02 9:27 UTC (permalink / raw)
To: heiko; +Cc: robh+dt, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
A test with the command below gives this error:
arch/arm64/boot/dts/rockchip/rk3399-evb.dt.yaml: /: compatible:
['rockchip,rk3399-evb', 'rockchip,rk3399', 'google,rk3399evb-rev2']
is not valid under any of the given schemas
'google,rk3399evb-rev2' was a no longer used variant for Google.
The binding only mentions 'rockchip,rk3399-evb', 'rockchip,rk3399',
so fix this error by removing 'google,rk3399evb-rev2' from
the compatible property in rk3399-evb.dts and change it into
generic rk3399-evb support only.
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
index 77008dca4..d1afd1e1d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
@@ -9,8 +9,7 @@
/ {
model = "Rockchip RK3399 Evaluation Board";
- compatible = "rockchip,rk3399-evb", "rockchip,rk3399",
- "google,rk3399evb-rev2";
+ compatible = "rockchip,rk3399-evb", "rockchip,rk3399";
backlight: backlight {
compatible = "pwm-backlight";
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings
2020-03-02 9:27 [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings Johan Jonker
2020-03-02 9:27 ` [PATCH v2 2/3] dt-bindings: arm: add Rockchip rk3036-evb board Johan Jonker
2020-03-02 9:27 ` [PATCH v2 3/3] arm64: dts: rockchip: fix compatible property for rk3399-evb Johan Jonker
@ 2020-03-10 19:27 ` Rob Herring
2020-03-11 8:05 ` Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-03-10 19:27 UTC (permalink / raw)
To: Johan Jonker
Cc: heiko, robh+dt, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
On Mon, 2 Mar 2020 10:27:57 +0100, Johan Jonker wrote:
> A test with the command below gives this error:
>
> arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible:
> ['rockchip,rk3036-kylin', 'rockchip,rk3036']
> is not valid under any of the given schemas
>
> Normally the dt-binding is the authoritative part, so boards should follow
> the binding, but in the kylin-case the compatible from the .dts is used for
> years in the field now, so fix the binding, as otherwise
> we would break old users.
>
> Fix this error by changing 'rockchip,kylin-rk3036' to
> 'rockchip,rk3036-kylin' in rockchip.yaml.
>
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings
2020-03-02 9:27 [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings Johan Jonker
` (2 preceding siblings ...)
2020-03-10 19:27 ` [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings Rob Herring
@ 2020-03-11 8:05 ` Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2020-03-11 8:05 UTC (permalink / raw)
To: Johan Jonker
Cc: robh+dt, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Montag, 2. März 2020, 10:27:57 CET schrieb Johan Jonker:
> A test with the command below gives this error:
>
> arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible:
> ['rockchip,rk3036-kylin', 'rockchip,rk3036']
> is not valid under any of the given schemas
>
> Normally the dt-binding is the authoritative part, so boards should follow
> the binding, but in the kylin-case the compatible from the .dts is used for
> years in the field now, so fix the binding, as otherwise
> we would break old users.
>
> Fix this error by changing 'rockchip,kylin-rk3036' to
> 'rockchip,rk3036-kylin' in rockchip.yaml.
>
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
applied all 3 for 5.7
Thanks
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread