From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Rishi Gupta <gupt21@gmail.com>
Cc: thierry.reding@gmail.com, s.trumtrar@pengutronix.de,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] pwm: pca9685: replace CONFIG_PM with __maybe_unused to prevent build issues
Date: Wed, 11 Mar 2020 17:44:49 +0100 [thread overview]
Message-ID: <20200311164449.flzzwxqqhcxisil3@pengutronix.de> (raw)
In-Reply-To: <1583941429-10921-1-git-send-email-gupt21@gmail.com>
On Wed, Mar 11, 2020 at 09:13:49PM +0530, Rishi Gupta wrote:
> The __maybe_unused attribute is preferred over CONFIG_PM
> to prevent build time issues. This commit replaces CONFIG_PM
> with this attribute.
I wasn't aware of build time issues and thought this was just about
#ifdef being ugly.
Anyhow, the change is fine,
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-03-11 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 15:43 [PATCH 1/1] pwm: pca9685: replace CONFIG_PM with __maybe_unused to prevent build issues Rishi Gupta
2020-03-11 16:44 ` Uwe Kleine-König [this message]
2020-03-11 19:46 ` rishi gupta
2020-03-11 19:55 ` Uwe Kleine-König
2020-03-21 5:56 ` rishi gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311164449.flzzwxqqhcxisil3@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gupt21@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).