linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: <bjorn.andersson@linaro.org>, <ohad@wizery.com>,
	<linux-remoteproc@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <mathieu.poirier@linaro.org>,
	<s-anna@ti.com>, <afd@ti.com>, Tero Kristo <t-kristo@ti.com>
Subject: [PATCHv8 09/15] remoteproc/omap: Check for undefined mailbox messages
Date: Fri, 13 Mar 2020 10:17:12 +0200	[thread overview]
Message-ID: <20200313081718.30612-10-t-kristo@ti.com> (raw)
In-Reply-To: <20200313081718.30612-1-t-kristo@ti.com>

From: Suman Anna <s-anna@ti.com>

Add some checks in the mailbox callback function to limit
any processing in the mailbox callback function to only
certain currently valid messages, and drop all the remaining
messages. A debug message is added to print any such invalid
messages when the appropriate trace control is enabled.

Co-developed-by: Subramaniam Chanderashekarapuram <subramaniam.ca@ti.com>
Signed-off-by: Subramaniam Chanderashekarapuram <subramaniam.ca@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Andrew F. Davis <afd@ti.com>
Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 drivers/remoteproc/omap_remoteproc.c | 6 ++++++
 drivers/remoteproc/omap_remoteproc.h | 7 +++++++
 2 files changed, 13 insertions(+)

diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
index 09eae548a691..7717a514d41a 100644
--- a/drivers/remoteproc/omap_remoteproc.c
+++ b/drivers/remoteproc/omap_remoteproc.c
@@ -130,6 +130,12 @@ static void omap_rproc_mbox_callback(struct mbox_client *client, void *data)
 		dev_info(dev, "received echo reply from %s\n", name);
 		break;
 	default:
+		if (msg >= RP_MBOX_READY && msg < RP_MBOX_END_MSG)
+			return;
+		if (msg > oproc->rproc->max_notifyid) {
+			dev_dbg(dev, "dropping unknown message 0x%x", msg);
+			return;
+		}
 		/* msg contains the index of the triggered vring */
 		if (rproc_vq_interrupt(oproc->rproc, msg) == IRQ_NONE)
 			dev_dbg(dev, "no message was found in vqid %d\n", msg);
diff --git a/drivers/remoteproc/omap_remoteproc.h b/drivers/remoteproc/omap_remoteproc.h
index f6d2036d383d..72f656c93caa 100644
--- a/drivers/remoteproc/omap_remoteproc.h
+++ b/drivers/remoteproc/omap_remoteproc.h
@@ -56,6 +56,12 @@
  *
  * @RP_MBOX_ABORT_REQUEST: a "please crash" request, used for testing the
  * recovery mechanism (to some extent).
+ *
+ * Introduce new message definitions if any here.
+ *
+ * @RP_MBOX_END_MSG: Indicates end of known/defined messages from remote core
+ * This should be the last definition.
+ *
  */
 enum omap_rp_mbox_messages {
 	RP_MBOX_READY		= 0xFFFFFF00,
@@ -64,6 +70,7 @@ enum omap_rp_mbox_messages {
 	RP_MBOX_ECHO_REQUEST	= 0xFFFFFF03,
 	RP_MBOX_ECHO_REPLY	= 0xFFFFFF04,
 	RP_MBOX_ABORT_REQUEST	= 0xFFFFFF05,
+	RP_MBOX_END_MSG		= 0xFFFFFF06,
 };
 
 #endif /* _OMAP_RPMSG_H */
-- 
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  parent reply	other threads:[~2020-03-13  8:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  8:17 [PATCHv8 00/15] remoteproc: updates for omap remoteproc support Tero Kristo
2020-03-13  8:17 ` [PATCHv8 01/15] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo
2020-03-13  8:17 ` [PATCHv8 02/15] remoteproc/omap: Add device tree support Tero Kristo
2020-03-13  8:17 ` [PATCHv8 03/15] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo
2020-03-14  0:43   ` [PATCHv8 RESEND " Suman Anna
2020-03-20 20:34     ` Mathieu Poirier
2020-03-20 21:38       ` Suman Anna
2020-03-13  8:17 ` [PATCHv8 04/15] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo
2020-03-13  8:17 ` [PATCHv8 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo
2020-03-14  0:43   ` [PATCHv8 RESEND " Suman Anna
2020-03-13  8:17 ` [PATCHv8 06/15] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo
2020-03-13  8:17 ` [PATCHv8 07/15] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo
2020-03-13  8:17 ` [PATCHv8 08/15] remoteproc/omap: Remove the platform_data header Tero Kristo
2020-03-13  8:17 ` Tero Kristo [this message]
2020-03-13  8:17 ` [PATCHv8 10/15] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo
2020-03-13  8:17 ` [PATCHv8 11/15] remoteproc/omap: Add support for system suspend/resume Tero Kristo
2020-03-13  8:17 ` [PATCHv8 12/15] remoteproc/omap: Add support for runtime auto-suspend/resume Tero Kristo
2020-03-20 20:23   ` Mathieu Poirier
2020-03-13  8:17 ` [PATCHv8 13/15] remoteproc/omap: Report device exceptions and trigger recovery Tero Kristo
2020-03-13  8:17 ` [PATCHv8 14/15] remoteproc/omap: Add watchdog functionality for remote processors Tero Kristo
2020-03-20 20:32   ` Mathieu Poirier
2020-03-20 21:48     ` Suman Anna
2020-03-23 15:14       ` Mathieu Poirier
2020-03-13  8:17 ` [PATCHv8 15/15] remoteproc/omap: Switch to SPDX license identifiers Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313081718.30612-10-t-kristo@ti.com \
    --to=t-kristo@ti.com \
    --cc=afd@ti.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).