linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	<linux-remoteproc@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suman Anna <s-anna@ti.com>, "Andrew F. Davis" <afd@ti.com>,
	Tero Kristo <t-kristo@ti.com>
Subject: [PATCHv8 RESEND 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation
Date: Fri, 13 Mar 2020 19:43:37 -0500	[thread overview]
Message-ID: <20200314004337.26556-1-s-anna@ti.com> (raw)
In-Reply-To: <20200313081718.30612-6-t-kristo@ti.com>

An implementation for the rproc ops .da_to_va() has been added
that provides the address translation between device addresses
to kernel virtual addresses for internal RAMs present on that
particular remote processor device. The implementation provides
the translations based on the addresses parsed and stored during
the probe.

This ops gets invoked by the exported rproc_da_to_va() function
and allows the remoteproc core's ELF loader to be able to load
program data directly into the internal memories.

Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reviewed-by: Andrew F. Davis <afd@ti.com>
Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
v8-Resend: Updated to fix compilation issues against rproc-next

 drivers/remoteproc/omap_remoteproc.c | 40 ++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
index cdcc9c227b96..6091666697ed 100644
--- a/drivers/remoteproc/omap_remoteproc.c
+++ b/drivers/remoteproc/omap_remoteproc.c
@@ -245,10 +245,50 @@ static int omap_rproc_stop(struct rproc *rproc)
 	return 0;
 }
 
+/**
+ * omap_rproc_da_to_va() - internal memory translation helper
+ * @rproc: remote processor to apply the address translation for
+ * @da: device address to translate
+ * @len: length of the memory buffer
+ *
+ * Custom function implementing the rproc .da_to_va ops to provide address
+ * translation (device address to kernel virtual address) for internal RAMs
+ * present in a DSP or IPU device). The translated addresses can be used
+ * either by the remoteproc core for loading, or by any rpmsg bus drivers.
+ *
+ * Return: translated virtual address in kernel memory space on success,
+ *         or NULL on failure.
+ */
+static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len)
+{
+	struct omap_rproc *oproc = rproc->priv;
+	int i;
+	u32 offset;
+
+	if (len == 0)
+		return NULL;
+
+	if (!oproc->num_mems)
+		return NULL;
+
+	for (i = 0; i < oproc->num_mems; i++) {
+		if (da >= oproc->mem[i].dev_addr && da + len <=
+		    oproc->mem[i].dev_addr + oproc->mem[i].size) {
+			offset = da - oproc->mem[i].dev_addr;
+			/* __force to make sparse happy with type conversion */
+			return (__force void *)(oproc->mem[i].cpu_addr +
+						offset);
+		}
+	}
+
+	return NULL;
+}
+
 static const struct rproc_ops omap_rproc_ops = {
 	.start		= omap_rproc_start,
 	.stop		= omap_rproc_stop,
 	.kick		= omap_rproc_kick,
+	.da_to_va	= omap_rproc_da_to_va,
 };
 
 static const struct omap_rproc_mem_data ipu_mems[] = {
-- 
2.23.0


  reply	other threads:[~2020-03-14  0:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  8:17 [PATCHv8 00/15] remoteproc: updates for omap remoteproc support Tero Kristo
2020-03-13  8:17 ` [PATCHv8 01/15] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo
2020-03-13  8:17 ` [PATCHv8 02/15] remoteproc/omap: Add device tree support Tero Kristo
2020-03-13  8:17 ` [PATCHv8 03/15] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo
2020-03-14  0:43   ` [PATCHv8 RESEND " Suman Anna
2020-03-20 20:34     ` Mathieu Poirier
2020-03-20 21:38       ` Suman Anna
2020-03-13  8:17 ` [PATCHv8 04/15] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo
2020-03-13  8:17 ` [PATCHv8 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo
2020-03-14  0:43   ` Suman Anna [this message]
2020-03-13  8:17 ` [PATCHv8 06/15] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo
2020-03-13  8:17 ` [PATCHv8 07/15] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo
2020-03-13  8:17 ` [PATCHv8 08/15] remoteproc/omap: Remove the platform_data header Tero Kristo
2020-03-13  8:17 ` [PATCHv8 09/15] remoteproc/omap: Check for undefined mailbox messages Tero Kristo
2020-03-13  8:17 ` [PATCHv8 10/15] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo
2020-03-13  8:17 ` [PATCHv8 11/15] remoteproc/omap: Add support for system suspend/resume Tero Kristo
2020-03-13  8:17 ` [PATCHv8 12/15] remoteproc/omap: Add support for runtime auto-suspend/resume Tero Kristo
2020-03-20 20:23   ` Mathieu Poirier
2020-03-13  8:17 ` [PATCHv8 13/15] remoteproc/omap: Report device exceptions and trigger recovery Tero Kristo
2020-03-13  8:17 ` [PATCHv8 14/15] remoteproc/omap: Add watchdog functionality for remote processors Tero Kristo
2020-03-20 20:32   ` Mathieu Poirier
2020-03-20 21:48     ` Suman Anna
2020-03-23 15:14       ` Mathieu Poirier
2020-03-13  8:17 ` [PATCHv8 15/15] remoteproc/omap: Switch to SPDX license identifiers Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200314004337.26556-1-s-anna@ti.com \
    --to=s-anna@ti.com \
    --cc=afd@ti.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).