* [PATCH] arm64: add blank after 'if'
@ 2020-03-13 14:54 Zheng Wei
2020-03-17 22:28 ` Will Deacon
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Wei @ 2020-03-13 14:54 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Hanjun Guo, Enrico Weigelt,
Allison Randal, Greg Kroah-Hartman, Zheng Wei, Thomas Gleixner,
Yunfeng Ye, linux-arm-kernel, linux-kernel
Cc: kernel, wenhu.wang
add blank after 'if' for armv8_deprecated_init()
to make it comply with kernel coding style.
Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
---
arch/arm64/kernel/armv8_deprecated.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
index 7832b3216370..4cc581af2d96 100644
--- a/arch/arm64/kernel/armv8_deprecated.c
+++ b/arch/arm64/kernel/armv8_deprecated.c
@@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
register_insn_emulation(&cp15_barrier_ops);
if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
- if(system_supports_mixed_endian_el0())
+ if (system_supports_mixed_endian_el0())
register_insn_emulation(&setend_ops);
else
pr_info("setend instruction emulation is not supported on this system\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: add blank after 'if'
2020-03-13 14:54 [PATCH] arm64: add blank after 'if' Zheng Wei
@ 2020-03-17 22:28 ` Will Deacon
2020-03-18 5:32 ` 王文虎
0 siblings, 1 reply; 4+ messages in thread
From: Will Deacon @ 2020-03-17 22:28 UTC (permalink / raw)
To: Zheng Wei
Cc: Catalin Marinas, Hanjun Guo, Enrico Weigelt, Allison Randal,
Greg Kroah-Hartman, Thomas Gleixner, Yunfeng Ye,
linux-arm-kernel, linux-kernel, kernel, wenhu.wang
On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
> add blank after 'if' for armv8_deprecated_init()
> to make it comply with kernel coding style.
>
> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
> ---
> arch/arm64/kernel/armv8_deprecated.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> index 7832b3216370..4cc581af2d96 100644
> --- a/arch/arm64/kernel/armv8_deprecated.c
> +++ b/arch/arm64/kernel/armv8_deprecated.c
> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
> register_insn_emulation(&cp15_barrier_ops);
>
> if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
> - if(system_supports_mixed_endian_el0())
> + if (system_supports_mixed_endian_el0())
> register_insn_emulation(&setend_ops);
> else
> pr_info("setend instruction emulation is not supported on this system\n");
(Catalin: I'm just acking these trivial typo/style fixes to get them out
of my inbox; do whatever you like with them ;)
Acked-by: Will Deacon <will@kernel.org>
Will
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re:Re: [PATCH] arm64: add blank after 'if'
2020-03-17 22:28 ` Will Deacon
@ 2020-03-18 5:32 ` 王文虎
2020-03-18 9:30 ` Catalin Marinas
0 siblings, 1 reply; 4+ messages in thread
From: 王文虎 @ 2020-03-18 5:32 UTC (permalink / raw)
To: Zheng Wei
Cc: Catalin Marinas, Hanjun Guo, Enrico Weigelt, Allison Randal,
Greg Kroah-Hartman, Thomas Gleixner, Yunfeng Ye,
linux-arm-kernel, linux-kernel, kernel, Will Deacon
From: Will Deacon <will@kernel.org>
Date: 2020-03-18 06:28:24
To: Zheng Wei <wei.zheng@vivo.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,Hanjun Guo <guohanjun@huawei.com>,Enrico Weigelt <info@metux.net>,Allison Randal <allison@lohutok.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Thomas Gleixner <tglx@linutronix.de>,Yunfeng Ye <yeyunfeng@huawei.com>,linux-arm-kernel@lists.infradead.org,linux-kernel@vger.kernel.org,kernel@vivo.com,wenhu.wang@vivo.com
Subject: Re: [PATCH] arm64: add blank after 'if'>On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
>> add blank after 'if' for armv8_deprecated_init()
>> to make it comply with kernel coding style.
>>
>> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
>> ---
>> arch/arm64/kernel/armv8_deprecated.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
>> index 7832b3216370..4cc581af2d96 100644
>> --- a/arch/arm64/kernel/armv8_deprecated.c
>> +++ b/arch/arm64/kernel/armv8_deprecated.c
>> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
>> register_insn_emulation(&cp15_barrier_ops);
>>
>> if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
>> - if(system_supports_mixed_endian_el0())
>> + if (system_supports_mixed_endian_el0())
>> register_insn_emulation(&setend_ops);
>> else
>> pr_info("setend instruction emulation is not supported on this system\n");
>
>(Catalin: I'm just acking these trivial typo/style fixes to get them out
>of my inbox; do whatever you like with them ;)
>
>Acked-by: Will Deacon <will@kernel.org>
>
>Will
Shouldn't you have Cc trivial<trivial@kernel.org>?
Asked-by: Wang Wenhu <wenhu.wang@vivo.com>
Wenhu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH] arm64: add blank after 'if'
2020-03-18 5:32 ` 王文虎
@ 2020-03-18 9:30 ` Catalin Marinas
0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2020-03-18 9:30 UTC (permalink / raw)
To: 王文虎
Cc: Zheng Wei, Hanjun Guo, Enrico Weigelt, Allison Randal,
Greg Kroah-Hartman, Thomas Gleixner, Yunfeng Ye,
linux-arm-kernel, linux-kernel, kernel, Will Deacon
On Wed, Mar 18, 2020 at 01:32:28PM +0800, 王文虎 wrote:
> From: Will Deacon <will@kernel.org>
> Date: 2020-03-18 06:28:24
> To: Zheng Wei <wei.zheng@vivo.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>,Hanjun Guo <guohanjun@huawei.com>,Enrico Weigelt <info@metux.net>,Allison Randal <allison@lohutok.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Thomas Gleixner <tglx@linutronix.de>,Yunfeng Ye <yeyunfeng@huawei.com>,linux-arm-kernel@lists.infradead.org,linux-kernel@vger.kernel.org,kernel@vivo.com,wenhu.wang@vivo.com
> Subject: Re: [PATCH] arm64: add blank after 'if'>On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
> >> add blank after 'if' for armv8_deprecated_init()
> >> to make it comply with kernel coding style.
> >>
> >> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
> >> ---
> >> arch/arm64/kernel/armv8_deprecated.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> >> index 7832b3216370..4cc581af2d96 100644
> >> --- a/arch/arm64/kernel/armv8_deprecated.c
> >> +++ b/arch/arm64/kernel/armv8_deprecated.c
> >> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
> >> register_insn_emulation(&cp15_barrier_ops);
> >>
> >> if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
> >> - if(system_supports_mixed_endian_el0())
> >> + if (system_supports_mixed_endian_el0())
> >> register_insn_emulation(&setend_ops);
> >> else
> >> pr_info("setend instruction emulation is not supported on this system\n");
> >
> >(Catalin: I'm just acking these trivial typo/style fixes to get them out
> >of my inbox; do whatever you like with them ;)
> >
> >Acked-by: Will Deacon <will@kernel.org>
> >
> >Will
>
> Shouldn't you have Cc trivial<trivial@kernel.org>?
> Asked-by: Wang Wenhu <wenhu.wang@vivo.com>
I queued them already, they are in arm64 for-next/core. In the future,
it they could as well go in via trivial@kernel.org (as long as there are
no serious conflicts).
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-18 9:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 14:54 [PATCH] arm64: add blank after 'if' Zheng Wei
2020-03-17 22:28 ` Will Deacon
2020-03-18 5:32 ` 王文虎
2020-03-18 9:30 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).