* [PATCH] ARM: dts: rockchip: fix vref-supply for &saradc node rk3288 firefly reload
@ 2020-03-14 14:07 Johan Jonker
2020-03-17 0:26 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Johan Jonker @ 2020-03-14 14:07 UTC (permalink / raw)
To: heiko; +Cc: robh+dt, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
A test with the command below gives this error:
arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml: saradc@ff100000:
'vref-supply' is a required property
PMIC Channel OUT11 with powername 'vcc_18'
(connected through R155 bridge with 'vccio_wl')
is used for the recovery key and ADC_AVDD_1V8.
Fix error by adding 'vcc_18' as vref for the saradc.
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/
rockchip-saradc.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Schematic:
http://www.t-firefly.com/download/Firefly-RK3288-Reload/hardware/MainBoard/
Schematic/FIREFLY-RK3288_RELOAD_V10_Schematic.pdf
---
arch/arm/boot/dts/rk3288-firefly-reload.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rk3288-firefly-reload.dts b/arch/arm/boot/dts/rk3288-firefly-reload.dts
index 1574383fd..8c38bda21 100644
--- a/arch/arm/boot/dts/rk3288-firefly-reload.dts
+++ b/arch/arm/boot/dts/rk3288-firefly-reload.dts
@@ -234,6 +234,7 @@
};
&saradc {
+ vref-supply = <&vcc_18>;
status = "okay";
};
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: fix vref-supply for &saradc node rk3288 firefly reload
2020-03-14 14:07 [PATCH] ARM: dts: rockchip: fix vref-supply for &saradc node rk3288 firefly reload Johan Jonker
@ 2020-03-17 0:26 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2020-03-17 0:26 UTC (permalink / raw)
To: Johan Jonker
Cc: robh+dt, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Am Samstag, 14. März 2020, 15:07:55 CET schrieb Johan Jonker:
> A test with the command below gives this error:
>
> arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml: saradc@ff100000:
> 'vref-supply' is a required property
>
> PMIC Channel OUT11 with powername 'vcc_18'
> (connected through R155 bridge with 'vccio_wl')
> is used for the recovery key and ADC_AVDD_1V8.
>
> Fix error by adding 'vcc_18' as vref for the saradc.
>
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/
> rockchip-saradc.yaml
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
applied for 5.7
Thanks
Heiko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-17 0:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-14 14:07 [PATCH] ARM: dts: rockchip: fix vref-supply for &saradc node rk3288 firefly reload Johan Jonker
2020-03-17 0:26 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).