From: Borislav Petkov <bp@alien8.de>
To: Wei Huang <wei.huang2@amd.com>
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
yazen.ghannam@amd.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-edac@vger.kernel.org, x86@kernel.org,
smita.koralahallichannabasappa@amd.com
Subject: Re: [PATCH 1/1] x86/mce/amd: Add PPIN support for AMD MCE
Date: Mon, 16 Mar 2020 19:08:29 +0100 [thread overview]
Message-ID: <20200316180829.GP26126@zn.tnic> (raw)
In-Reply-To: <20200311044409.2717587-1-wei.huang2@amd.com>
On Tue, Mar 10, 2020 at 11:44:09PM -0500, Wei Huang wrote:
> Newer AMD CPUs support the feature of protected processor identification
> number (PPIN). This patch detects and enables PPIN support on AMD platforms
Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
> and includes PPIN info in MCE records if available. Because this feature is
> almost identical on both Intel and AMD, it re-uses X86_FEATURE_INTEL_PPIN
> feature bit and renames it to X86_FEATURE_PPIN.
Strictly speaking, you can't rename it anymore because it is visible in
/proc/cpuinfo and thus ABI.
Besides, we have already a cpufeatures.h leaf for exactly that word:
/* AMD-defined CPU features, CPUID level 0x80000008 (EBX), word 13 */
which means you can call the AMD define
#define X86_FEATURE_AMD_PPIN ( 13*32+23) /* AMD Protected Processor Inventory Number */
and /proc/cpuinfo will have "amd_ppin" and the code will use the
respective vendor flag to test.
> Signed-off-by: Wei Huang <wei.huang2@amd.com>
> Signed-off-by: Smita Koralahalli Channabasappa <smita.koralahallichannabasappa@amd.com>
What does this SOB mean? Grep Documentation/ for "Co-developed-by" in
case this is what you're trying to express.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-03-16 18:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 4:44 [PATCH 1/1] x86/mce/amd: Add PPIN support for AMD MCE Wei Huang
2020-03-11 16:05 ` Luck, Tony
2020-03-16 18:08 ` Borislav Petkov [this message]
2020-03-16 19:20 ` Wei Huang
2020-03-19 20:14 ` Wei Huang
2020-03-19 20:21 ` Borislav Petkov
2020-03-19 20:58 ` Huang2, Wei
2020-03-19 21:09 ` Borislav Petkov
2020-03-19 21:44 ` Huang2, Wei
2020-03-19 21:56 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316180829.GP26126@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=smita.koralahallichannabasappa@amd.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wei.huang2@amd.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).