From: Borislav Petkov <bp@alien8.de>
To: Wei Huang <whuang2@amd.com>
Cc: Wei Huang <wei.huang2@amd.com>,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
yazen.ghannam@amd.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-edac@vger.kernel.org, x86@kernel.org,
smita.koralahallichannabasappa@amd.com
Subject: Re: [PATCH 1/1] x86/mce/amd: Add PPIN support for AMD MCE
Date: Thu, 19 Mar 2020 21:21:34 +0100 [thread overview]
Message-ID: <20200319202134.GG13073@zn.tnic> (raw)
In-Reply-To: <53d25b8c-dabe-1b91-4d3b-0a223075e42a@amd.com>
On Thu, Mar 19, 2020 at 03:14:53PM -0500, Wei Huang wrote:
> My proposal is to move mce_amd_ppin_init() function to
> ./arch/x86/kernel/cpu/amd.c and probe X86_FEATURE_AMD_PPIN there. This
> is similar to what early_detect_mem_encrypt() does. Later, mce_setup()
> can use X86_FEATURE_AMD_PPIN directly. Is this approach acceptable?
You can add it to arch/x86/kernel/cpu/mce/amd.c just like
intel_ppin_init() is respectively in .../mce/intel.c, as mce/ is where
this thing is used only. We can move it to kernel/cpu/ later if it turns
out that it is needed for something else.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-03-19 20:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 4:44 [PATCH 1/1] x86/mce/amd: Add PPIN support for AMD MCE Wei Huang
2020-03-11 16:05 ` Luck, Tony
2020-03-16 18:08 ` Borislav Petkov
2020-03-16 19:20 ` Wei Huang
2020-03-19 20:14 ` Wei Huang
2020-03-19 20:21 ` Borislav Petkov [this message]
2020-03-19 20:58 ` Huang2, Wei
2020-03-19 21:09 ` Borislav Petkov
2020-03-19 21:44 ` Huang2, Wei
2020-03-19 21:56 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319202134.GG13073@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=smita.koralahallichannabasappa@amd.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wei.huang2@amd.com \
--cc=whuang2@amd.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).